[{"id":12115,"web_url":"https://patchwork.libcamera.org/comment/12115/","msgid":"","date":"2020-08-24T09:56:17","subject":"Re: [libcamera-devel] [PATCH 3/5] libcamera: Drop explicit\n\tconstruction of std::queue","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 22/08/2020 21:00, Laurent Pinchart wrote:\n> Now that libcamera is using C++17 and requires gcc 7 or newer, we can\n> use the implicit std::queue constructor. Simplify the code accordingly.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/libcamera/pipeline/ipu3/cio2.cpp | 4 +---\n> src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 5 ++---\n> 2 files changed, 3 insertions(+), 6 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/cio2.cpp b/src/libcamera/pipeline/ipu3/cio2.cpp\n> index abe6d8a592d6..e43ec70fe3e4 100644\n> --- a/src/libcamera/pipeline/ipu3/cio2.cpp\n> +++ b/src/libcamera/pipeline/ipu3/cio2.cpp\n> @@ -300,9 +300,7 @@ void CIO2Device::tryReturnBuffer(FrameBuffer *buffer)\n> \n> void CIO2Device::freeBuffers()\n> {\n> -\t/* The default std::queue constructor is explicit with gcc 5 and 6. */\n> -\tavailableBuffers_ = std::queue{};\n> -\n> +\tavailableBuffers_ = {};\n> \tbuffers_.clear();\n> \n> \tif (output_->releaseBuffers())\n> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> index eeaf335cbcd2..b8f0549f0c60 100644\n> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> @@ -848,9 +848,8 @@ void PipelineHandlerRPi::stop(Camera *camera)\n> \n> \t/* This also stops the streams. */\n> \tdata->clearIncompleteRequests();\n> -\t/* The default std::queue constructor is explicit with gcc 5 and 6. */\n> -\tdata->bayerQueue_ = std::queue{};\n> -\tdata->embeddedQueue_ = std::queue{};\n> +\tdata->bayerQueue_ = {};\n> +\tdata->embeddedQueue_ = {};\n> \n> \t/* Stop the IPA. */\n> \tdata->ipa_->stop();\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E69CCBE173\n\tfor ;\n\tMon, 24 Aug 2020 09:56:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A43C562849;\n\tMon, 24 Aug 2020 11:56:23 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4D5A860387\n\tfor ;\n\tMon, 24 Aug 2020 11:56:22 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9D9A8279;\n\tMon, 24 Aug 2020 11:56:19 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"PNQcTE+W\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1598262979;\n\tbh=4F+B/FYRxttOXQaxcioPn72boqPI2T83+U/gnHOsFpU=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=PNQcTE+W6XbResnr/fpuVHpGaXh5+0w6Vs6yIs+rNU3sPnQjYTITYrxJrqr2u6jlv\n\tmPBWqFWdnZHlgBsprveeBgyP4KtFhigMBCRMVmoP70Uu3M36R0QNaeVTwIip1lXTNv\n\tXnq7U6FOSepCs8wEXf/2GKm54qVxMXDP1kLokDoQ=","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20200822200037.20892-1-laurent.pinchart@ideasonboard.com>\n\t<20200822200037.20892-4-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"","Date":"Mon, 24 Aug 2020 10:56:17 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20200822200037.20892-4-laurent.pinchart@ideasonboard.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 3/5] libcamera: Drop explicit\n\tconstruction of std::queue","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":12126,"web_url":"https://patchwork.libcamera.org/comment/12126/","msgid":"<20200824211213.GC594558@oden.dyn.berto.se>","date":"2020-08-24T21:12:13","subject":"Re: [libcamera-devel] [PATCH 3/5] libcamera: Drop explicit\n\tconstruction of std::queue","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your patch.\n\nOn 2020-08-22 23:00:35 +0300, Laurent Pinchart wrote:\n> Now that libcamera is using C++17 and requires gcc 7 or newer, we can\n> use the implicit std::queue constructor. Simplify the code accordingly.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/pipeline/ipu3/cio2.cpp | 4 +---\n> src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 5 ++---\n> 2 files changed, 3 insertions(+), 6 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/cio2.cpp b/src/libcamera/pipeline/ipu3/cio2.cpp\n> index abe6d8a592d6..e43ec70fe3e4 100644\n> --- a/src/libcamera/pipeline/ipu3/cio2.cpp\n> +++ b/src/libcamera/pipeline/ipu3/cio2.cpp\n> @@ -300,9 +300,7 @@ void CIO2Device::tryReturnBuffer(FrameBuffer *buffer)\n> \n> void CIO2Device::freeBuffers()\n> {\n> -\t/* The default std::queue constructor is explicit with gcc 5 and 6. */\n> -\tavailableBuffers_ = std::queue{};\n> -\n> +\tavailableBuffers_ = {};\n> \tbuffers_.clear();\n> \n> \tif (output_->releaseBuffers())\n> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> index eeaf335cbcd2..b8f0549f0c60 100644\n> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> @@ -848,9 +848,8 @@ void PipelineHandlerRPi::stop(Camera *camera)\n> \n> \t/* This also stops the streams. */\n> \tdata->clearIncompleteRequests();\n> -\t/* The default std::queue constructor is explicit with gcc 5 and 6. */\n> -\tdata->bayerQueue_ = std::queue{};\n> -\tdata->embeddedQueue_ = std::queue{};\n> +\tdata->bayerQueue_ = {};\n> +\tdata->embeddedQueue_ = {};\n> \n> \t/* Stop the IPA. */\n> \tdata->ipa_->stop();\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B87C4BE173\n\tfor ;\n\tMon, 24 Aug 2020 21:12:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7ED4962818;\n\tMon, 24 Aug 2020 23:12:16 +0200 (CEST)","from mail-lj1-x241.google.com (mail-lj1-x241.google.com\n\t[IPv6:2a00:1450:4864:20::241])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 63BAF616B1\n\tfor ;\n\tMon, 24 Aug 2020 23:12:15 +0200 (CEST)","by mail-lj1-x241.google.com with SMTP id h19so11317768ljg.13\n\tfor ;\n\tMon, 24 Aug 2020 14:12:15 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\te17sm2401118ljg.85.2020.08.24.14.12.14\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 24 Aug 2020 14:12:14 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"iRvir6/X\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=WezaETZ7KF2Nh15RkwAvNc6TuBVeVB72sSoNBEMj3xQ=;\n\tb=iRvir6/XhpSDFGdLnohxg1ienYa/ZEn7qw6o+sjH28Il8v6BGJxkY5NvIM3h1Uzuc6\n\tBsfBQlD5JU/ieOv4/UeDUf5V3nCfasXUEJxkBGmz8auH9aCGPvjOMKhEi5ZMzgO4axvu\n\tICQhDzPdJLwwO0oS67nus2HaaxsrmCjsz3ca/tHNVWhxBQquebapOe7V4JXkRkCDNKsn\n\tz6U3aEm3gRGhY1XZ4d7RIGm1fpREZUSKIeFvR/E9A41vBxaFB33TTrK+/UemtJ+Dk8bY\n\t3anfTtTuWc+SSe+zuOVMfZso3h39G+g87WCA3dbr8Zmrnj+EmgXDNpHhAPC7HsRGASd4\n\tueQg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=WezaETZ7KF2Nh15RkwAvNc6TuBVeVB72sSoNBEMj3xQ=;\n\tb=ACRZyplSM7SN1sf5eVDBnwiZ3DbEgtwM5vJzWsUU43+vsYhZB7k2nAUuRvI2TBMDlL\n\tmIufMY3opj3yaUGXUZuII3rS4LKNwzdb6zrC39MpCMSvVw51xePD5xlbzc0dbaHwJwnn\n\t67kH1Ze5ECixO+Tkg9RRjoilMth8PktQkE6NxG23jmpR+JjGP3s+xIUM7QmAMei2hMWY\n\tFWPbT4eed4vMRYVoAv/SD8GTh4Mpgm7CjewS5bkuP/d6TKHJ+liFRY+AGVuuxlbmouiT\n\t5gbspHAHpsjoSR/ApEk3P58sr12O1S5c3R303hJM5AvCXIhKKh1celN068PFRvOeTJok\n\tiMWg==","X-Gm-Message-State":"AOAM533ccM0d7MXlcsPSYETv19CDhQLRoieEdm6beM5tI6vLL387kNNx\n\tQ60Znc/8E+peXb1Kxj3rETM7LA==","X-Google-Smtp-Source":"ABdhPJxbqUoCamNXPW0gHtfi0ivf+23+9+xTvcT47lRhfp2/Xd6/t1B/jXgWVvSzOiUMTdt6iUZrSQ==","X-Received":"by 2002:a2e:7e0d:: with SMTP id z13mr3531043ljc.12.1598303534850;\n\tMon, 24 Aug 2020 14:12:14 -0700 (PDT)","Date":"Mon, 24 Aug 2020 23:12:13 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Message-ID":"<20200824211213.GC594558@oden.dyn.berto.se>","References":"<20200822200037.20892-1-laurent.pinchart@ideasonboard.com>\n\t<20200822200037.20892-4-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200822200037.20892-4-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 3/5] libcamera: Drop explicit\n\tconstruction of std::queue","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]