[{"id":12108,"web_url":"https://patchwork.libcamera.org/comment/12108/","msgid":"<07cdf472-5fb1-ff78-1414-c73c8ec014da@ideasonboard.com>","date":"2020-08-24T09:38:05","subject":"Re: [libcamera-devel] [PATCH 3/3] v4l2: camera: Merge\n\tgetStreamConfig() with open()","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 22/08/2020 14:46, Laurent Pinchart wrote:\n> The V4L2CameraProxy always calls V4L2Camera::getStreamConfig() right\n> after V4L2Camera::open(), and never afterwards. Simplify the code by\n> returning the initial configuration from V4L2Camera::open() and removing\n> V4L2Camera::getStreamConfig().\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Kieran Bingham \n\n\n> ---\n> src/v4l2/v4l2_camera.cpp | 8 ++------\n> src/v4l2/v4l2_camera.h | 4 ++--\n> src/v4l2/v4l2_camera_proxy.cpp | 3 +--\n> 3 files changed, 5 insertions(+), 10 deletions(-)\n> \n> diff --git a/src/v4l2/v4l2_camera.cpp b/src/v4l2/v4l2_camera.cpp\n> index 61bca0732447..24805d5f3c3f 100644\n> --- a/src/v4l2/v4l2_camera.cpp\n> +++ b/src/v4l2/v4l2_camera.cpp\n> @@ -28,7 +28,7 @@ V4L2Camera::~V4L2Camera()\n> \tclose();\n> }\n> \n> -int V4L2Camera::open()\n> +int V4L2Camera::open(StreamConfiguration *streamConfig)\n> {\n> \tif (camera_->acquire() < 0) {\n> \t\tLOG(V4L2Compat, Error) << \"Failed to acquire camera\";\n> @@ -43,6 +43,7 @@ int V4L2Camera::open()\n> \n> \tbufferAllocator_ = new FrameBufferAllocator(camera_);\n> \n> +\t*streamConfig = config_->at(0);\n> \treturn 0;\n> }\n> \n> @@ -64,11 +65,6 @@ void V4L2Camera::unbind()\n> \tefd_ = -1;\n> }\n> \n> -void V4L2Camera::getStreamConfig(StreamConfiguration *streamConfig)\n> -{\n> -\t*streamConfig = config_->at(0);\n> -}\n> -\n> std::vector V4L2Camera::completedBuffers()\n> {\n> \tstd::vector v;\n> diff --git a/src/v4l2/v4l2_camera.h b/src/v4l2/v4l2_camera.h\n> index be6c4e187363..1fc5ebefef6a 100644\n> --- a/src/v4l2/v4l2_camera.h\n> +++ b/src/v4l2/v4l2_camera.h\n> @@ -37,11 +37,11 @@ public:\n> \tV4L2Camera(std::shared_ptr camera);\n> \t~V4L2Camera();\n> \n> -\tint open();\n> +\tint open(StreamConfiguration *streamConfig);\n> \tvoid close();\n> \tvoid bind(int efd);\n> \tvoid unbind();\n> -\tvoid getStreamConfig(StreamConfiguration *streamConfig);\n> +\n> \tstd::vector completedBuffers();\n> \n> \tint configure(StreamConfiguration *streamConfigOut,\n> diff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp\n> index 80287d8f164e..8ff990f68fcd 100644\n> --- a/src/v4l2/v4l2_camera_proxy.cpp\n> +++ b/src/v4l2/v4l2_camera_proxy.cpp\n> @@ -63,13 +63,12 @@ int V4L2CameraProxy::open(V4L2CameraFile *file)\n> \t * with count = 0.\n> \t */\n> \n> -\tint ret = vcam_->open();\n> +\tint ret = vcam_->open(&streamConfig_);\n> \tif (ret < 0) {\n> \t\trefcount_--;\n> \t\treturn ret;\n> \t}\n> \n> -\tvcam_->getStreamConfig(&streamConfig_);\n> \tsetFmtFromConfig(streamConfig_);\n> \n> \tfiles_.insert(file);\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E664EBE173\n\tfor ;\n\tMon, 24 Aug 2020 09:38:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 805A460387;\n\tMon, 24 Aug 2020 11:38:12 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0968060387\n\tfor ;\n\tMon, 24 Aug 2020 11:38:11 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2C339279;\n\tMon, 24 Aug 2020 11:38:08 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"VKTZqxpU\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1598261888;\n\tbh=ETO5UEFlZQBTM4ejraPyrHX/6/67fTJAN8P+6VC4Xfc=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=VKTZqxpUNtelFR5SXX0XDTwXMXgfHGR+XeC14IISG9sBKugJle5XiDUqStMHYq/E/\n\td2mKLdzhUUQ+gs1b+A8q6tYrVrAstuDyDGNqeAtB6IhkCav/EAuq09SVvC3DNTnPFo\n\tLfQC5NooDQeTHeKZldS3drIOMD86xkgqS4t6JJBs=","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20200822134605.17666-1-laurent.pinchart@ideasonboard.com>\n\t<20200822134605.17666-4-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<07cdf472-5fb1-ff78-1414-c73c8ec014da@ideasonboard.com>","Date":"Mon, 24 Aug 2020 10:38:05 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20200822134605.17666-4-laurent.pinchart@ideasonboard.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 3/3] v4l2: camera: Merge\n\tgetStreamConfig() with open()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":12141,"web_url":"https://patchwork.libcamera.org/comment/12141/","msgid":"<20200825032150.GD1982@pyrite.rasen.tech>","date":"2020-08-25T03:21:50","subject":"Re: [libcamera-devel] [PATCH 3/3] v4l2: camera: Merge\n\tgetStreamConfig() with open()","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Laurent,\n\nOn Sat, Aug 22, 2020 at 04:46:05PM +0300, Laurent Pinchart wrote:\n> The V4L2CameraProxy always calls V4L2Camera::getStreamConfig() right\n> after V4L2Camera::open(), and never afterwards. Simplify the code by\n> returning the initial configuration from V4L2Camera::open() and removing\n> V4L2Camera::getStreamConfig().\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Paul Elder \n\n> ---\n> src/v4l2/v4l2_camera.cpp | 8 ++------\n> src/v4l2/v4l2_camera.h | 4 ++--\n> src/v4l2/v4l2_camera_proxy.cpp | 3 +--\n> 3 files changed, 5 insertions(+), 10 deletions(-)\n> \n> diff --git a/src/v4l2/v4l2_camera.cpp b/src/v4l2/v4l2_camera.cpp\n> index 61bca0732447..24805d5f3c3f 100644\n> --- a/src/v4l2/v4l2_camera.cpp\n> +++ b/src/v4l2/v4l2_camera.cpp\n> @@ -28,7 +28,7 @@ V4L2Camera::~V4L2Camera()\n> \tclose();\n> }\n> \n> -int V4L2Camera::open()\n> +int V4L2Camera::open(StreamConfiguration *streamConfig)\n> {\n> \tif (camera_->acquire() < 0) {\n> \t\tLOG(V4L2Compat, Error) << \"Failed to acquire camera\";\n> @@ -43,6 +43,7 @@ int V4L2Camera::open()\n> \n> \tbufferAllocator_ = new FrameBufferAllocator(camera_);\n> \n> +\t*streamConfig = config_->at(0);\n> \treturn 0;\n> }\n> \n> @@ -64,11 +65,6 @@ void V4L2Camera::unbind()\n> \tefd_ = -1;\n> }\n> \n> -void V4L2Camera::getStreamConfig(StreamConfiguration *streamConfig)\n> -{\n> -\t*streamConfig = config_->at(0);\n> -}\n> -\n> std::vector V4L2Camera::completedBuffers()\n> {\n> \tstd::vector v;\n> diff --git a/src/v4l2/v4l2_camera.h b/src/v4l2/v4l2_camera.h\n> index be6c4e187363..1fc5ebefef6a 100644\n> --- a/src/v4l2/v4l2_camera.h\n> +++ b/src/v4l2/v4l2_camera.h\n> @@ -37,11 +37,11 @@ public:\n> \tV4L2Camera(std::shared_ptr camera);\n> \t~V4L2Camera();\n> \n> -\tint open();\n> +\tint open(StreamConfiguration *streamConfig);\n> \tvoid close();\n> \tvoid bind(int efd);\n> \tvoid unbind();\n> -\tvoid getStreamConfig(StreamConfiguration *streamConfig);\n> +\n> \tstd::vector completedBuffers();\n> \n> \tint configure(StreamConfiguration *streamConfigOut,\n> diff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp\n> index 80287d8f164e..8ff990f68fcd 100644\n> --- a/src/v4l2/v4l2_camera_proxy.cpp\n> +++ b/src/v4l2/v4l2_camera_proxy.cpp\n> @@ -63,13 +63,12 @@ int V4L2CameraProxy::open(V4L2CameraFile *file)\n> \t * with count = 0.\n> \t */\n> \n> -\tint ret = vcam_->open();\n> +\tint ret = vcam_->open(&streamConfig_);\n> \tif (ret < 0) {\n> \t\trefcount_--;\n> \t\treturn ret;\n> \t}\n> \n> -\tvcam_->getStreamConfig(&streamConfig_);\n> \tsetFmtFromConfig(streamConfig_);\n> \n> \tfiles_.insert(file);\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8AF85BD87C\n\tfor ;\n\tTue, 25 Aug 2020 03:22:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 56C8D62851;\n\tTue, 25 Aug 2020 05:22:02 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 412366170D\n\tfor ;\n\tTue, 25 Aug 2020 05:22:01 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3FFDE29E;\n\tTue, 25 Aug 2020 05:21:56 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"aw8O8Azm\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1598325718;\n\tbh=FiFTo3dvRLszkRvlHxMtihuY6EWM4PZ13Cc/pTv/VsE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=aw8O8AzmlU3BQYcdF0Of9Vtu52owMcbRrWozAygW6Nd5k840wbBZUOLYO+uYKo5Al\n\taJIU01nlZILUcF+4KnEZ71OV4RDOw0x4zpFUR9Pct6FBWcc5xq+uhwqqRKwLccXhcA\n\tffab4Kvw92thy2kQ1hkgdOvIpNo3FKooVZdFbm3g=","Date":"Tue, 25 Aug 2020 12:21:50 +0900","From":"paul.elder@ideasonboard.com","To":"Laurent Pinchart ","Message-ID":"<20200825032150.GD1982@pyrite.rasen.tech>","References":"<20200822134605.17666-1-laurent.pinchart@ideasonboard.com>\n\t<20200822134605.17666-4-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200822134605.17666-4-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 3/3] v4l2: camera: Merge\n\tgetStreamConfig() with open()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]