[{"id":12107,"web_url":"https://patchwork.libcamera.org/comment/12107/","msgid":"","date":"2020-08-24T09:35:37","subject":"Re: [libcamera-devel] [PATCH 2/3] v4l2: camera_proxy: Store\n\tv4l2_pix_format instead of v4l2_format","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 22/08/2020 14:46, Laurent Pinchart wrote:\n> The V4L2 compatibility layer only uses the fmt.pix field of\n> curV4L2Format_. There's no need to cache the full v4l2_format, store\n> v4l2_pix_format only and rename the member variable from curV4L2Format_\n> to v4l2PixFormat_. While at it, group the V4L2-related member variables\n> together in the V4L2CameraProxy class.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/v4l2/v4l2_camera_proxy.cpp | 32 ++++++++++++++++----------------\n> src/v4l2/v4l2_camera_proxy.h | 5 +++--\n> 2 files changed, 19 insertions(+), 18 deletions(-)\n> \n> diff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp\n> index 079257f4bf22..80287d8f164e 100644\n> --- a/src/v4l2/v4l2_camera_proxy.cpp\n> +++ b/src/v4l2/v4l2_camera_proxy.cpp\n> @@ -167,17 +167,17 @@ void V4L2CameraProxy::setFmtFromConfig(const StreamConfiguration &streamConfig)\n> \tconst PixelFormatInfo &info = PixelFormatInfo::info(streamConfig.pixelFormat);\n> \tconst Size &size = streamConfig.size;\n> \n> -\tcurV4L2Format_.fmt.pix.width = size.width;\n> -\tcurV4L2Format_.fmt.pix.height = size.height;\n> -\tcurV4L2Format_.fmt.pix.pixelformat = info.v4l2Format;\n> -\tcurV4L2Format_.fmt.pix.field = V4L2_FIELD_NONE;\n> -\tcurV4L2Format_.fmt.pix.bytesperline = streamConfig.stride;\n> -\tcurV4L2Format_.fmt.pix.sizeimage = streamConfig.frameSize;\n> -\tcurV4L2Format_.fmt.pix.colorspace = V4L2_COLORSPACE_SRGB;\n> -\tcurV4L2Format_.fmt.pix.priv = V4L2_PIX_FMT_PRIV_MAGIC;\n> -\tcurV4L2Format_.fmt.pix.ycbcr_enc = V4L2_YCBCR_ENC_DEFAULT;\n> -\tcurV4L2Format_.fmt.pix.quantization = V4L2_QUANTIZATION_DEFAULT;\n> -\tcurV4L2Format_.fmt.pix.xfer_func = V4L2_XFER_FUNC_DEFAULT;\n> +\tv4l2PixFormat_.width = size.width;\n> +\tv4l2PixFormat_.height = size.height;\n> +\tv4l2PixFormat_.pixelformat = info.v4l2Format;\n> +\tv4l2PixFormat_.field = V4L2_FIELD_NONE;\n> +\tv4l2PixFormat_.bytesperline = streamConfig.stride;\n> +\tv4l2PixFormat_.sizeimage = streamConfig.frameSize;\n> +\tv4l2PixFormat_.colorspace = V4L2_COLORSPACE_SRGB;\n> +\tv4l2PixFormat_.priv = V4L2_PIX_FMT_PRIV_MAGIC;\n> +\tv4l2PixFormat_.ycbcr_enc = V4L2_YCBCR_ENC_DEFAULT;\n> +\tv4l2PixFormat_.quantization = V4L2_QUANTIZATION_DEFAULT;\n> +\tv4l2PixFormat_.xfer_func = V4L2_XFER_FUNC_DEFAULT;\n> \n> \tsizeimage_ = streamConfig.frameSize;\n> }\n> @@ -291,7 +291,7 @@ int V4L2CameraProxy::vidioc_g_fmt(V4L2CameraFile *file, struct v4l2_format *arg)\n> \t\treturn -EINVAL;\n> \n> \tmemset(&arg->fmt, 0, sizeof(arg->fmt));\n> -\targ->fmt.pix = curV4L2Format_.fmt.pix;\n> +\targ->fmt.pix = v4l2PixFormat_;\n> \n> \treturn 0;\n> }\n> @@ -488,8 +488,8 @@ int V4L2CameraProxy::vidioc_reqbufs(V4L2CameraFile *file, struct v4l2_requestbuf\n> \tif (bufferCount_ > 0)\n> \t\tfreeBuffers();\n> \n> -\tSize size(curV4L2Format_.fmt.pix.width, curV4L2Format_.fmt.pix.height);\n> -\tV4L2PixelFormat v4l2Format = V4L2PixelFormat(curV4L2Format_.fmt.pix.pixelformat);\n> +\tSize size(v4l2PixFormat_.width, v4l2PixFormat_.height);\n> +\tV4L2PixelFormat v4l2Format = V4L2PixelFormat(v4l2PixFormat_.pixelformat);\n> \tint ret = vcam_->configure(&streamConfig_, size,\n> \t\t\t\t PixelFormatInfo::info(v4l2Format).format,\n> \t\t\t\t arg->count);\n> @@ -511,9 +511,9 @@ int V4L2CameraProxy::vidioc_reqbufs(V4L2CameraFile *file, struct v4l2_requestbuf\n> \tfor (unsigned int i = 0; i < arg->count; i++) {\n> \t\tstruct v4l2_buffer buf = {};\n> \t\tbuf.type = V4L2_BUF_TYPE_VIDEO_CAPTURE;\n> -\t\tbuf.length = curV4L2Format_.fmt.pix.sizeimage;\n> +\t\tbuf.length = v4l2PixFormat_.sizeimage;\n> \t\tbuf.memory = V4L2_MEMORY_MMAP;\n> -\t\tbuf.m.offset = i * curV4L2Format_.fmt.pix.sizeimage;\n> +\t\tbuf.m.offset = i * v4l2PixFormat_.sizeimage;\n> \t\tbuf.index = i;\n> \t\tbuf.flags = V4L2_BUF_FLAG_TIMESTAMP_MONOTONIC;\n> \n> diff --git a/src/v4l2/v4l2_camera_proxy.h b/src/v4l2/v4l2_camera_proxy.h\n> index 79eb87bcea51..92a79abb9e21 100644\n> --- a/src/v4l2/v4l2_camera_proxy.h\n> +++ b/src/v4l2/v4l2_camera_proxy.h\n> @@ -73,13 +73,14 @@ private:\n> \tunsigned int refcount_;\n> \tunsigned int index_;\n> \n> -\tstruct v4l2_format curV4L2Format_;\n> \tStreamConfiguration streamConfig_;\n> -\tstruct v4l2_capability capabilities_;\n> \tunsigned int bufferCount_;\n> \tunsigned int currentBuf_;\n> \tunsigned int sizeimage_;\n> \n> +\tstruct v4l2_capability capabilities_;\n> +\tstruct v4l2_pix_format v4l2PixFormat_;\n> +\n> \tstd::vector buffers_;\n> \tstd::map mmaps_;\n> \n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2149BBD87C\n\tfor ;\n\tMon, 24 Aug 2020 09:35:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9F17A62849;\n\tMon, 24 Aug 2020 11:35:44 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8618860387\n\tfor ;\n\tMon, 24 Aug 2020 11:35:42 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C3E12279;\n\tMon, 24 Aug 2020 11:35:39 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"gxUwyt1B\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1598261740;\n\tbh=wb9iW29QsMJwgbs7Y3kRbUDtOqIPwcjSclTxI7ZvAmo=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=gxUwyt1Bq8CbqmprzgLkqA3jb+YjE1kXFT5sygjJcCkkJXQ7FymeIKrGKSF7CAVBM\n\tXxdao4wNZ7D98NuCUTJkvM0mR4Y4EkWzyRAfJkL5Iq3NjkR7v63uudJiC/9EJwyeKj\n\tXvHYs0j6A4gbf4nNcx2QL0WRfolE6aB1DpmAC+pw=","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20200822134605.17666-1-laurent.pinchart@ideasonboard.com>\n\t<20200822134605.17666-3-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"","Date":"Mon, 24 Aug 2020 10:35:37 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20200822134605.17666-3-laurent.pinchart@ideasonboard.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 2/3] v4l2: camera_proxy: Store\n\tv4l2_pix_format instead of v4l2_format","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":12140,"web_url":"https://patchwork.libcamera.org/comment/12140/","msgid":"<20200825032029.GC1982@pyrite.rasen.tech>","date":"2020-08-25T03:20:29","subject":"Re: [libcamera-devel] [PATCH 2/3] v4l2: camera_proxy: Store\n\tv4l2_pix_format instead of v4l2_format","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Laurent,\n\nOn Sat, Aug 22, 2020 at 04:46:04PM +0300, Laurent Pinchart wrote:\n> The V4L2 compatibility layer only uses the fmt.pix field of\n> curV4L2Format_. There's no need to cache the full v4l2_format, store\n> v4l2_pix_format only and rename the member variable from curV4L2Format_\n> to v4l2PixFormat_. While at it, group the V4L2-related member variables\n> together in the V4L2CameraProxy class.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Paul Elder \n\n> ---\n> src/v4l2/v4l2_camera_proxy.cpp | 32 ++++++++++++++++----------------\n> src/v4l2/v4l2_camera_proxy.h | 5 +++--\n> 2 files changed, 19 insertions(+), 18 deletions(-)\n> \n> diff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp\n> index 079257f4bf22..80287d8f164e 100644\n> --- a/src/v4l2/v4l2_camera_proxy.cpp\n> +++ b/src/v4l2/v4l2_camera_proxy.cpp\n> @@ -167,17 +167,17 @@ void V4L2CameraProxy::setFmtFromConfig(const StreamConfiguration &streamConfig)\n> \tconst PixelFormatInfo &info = PixelFormatInfo::info(streamConfig.pixelFormat);\n> \tconst Size &size = streamConfig.size;\n> \n> -\tcurV4L2Format_.fmt.pix.width = size.width;\n> -\tcurV4L2Format_.fmt.pix.height = size.height;\n> -\tcurV4L2Format_.fmt.pix.pixelformat = info.v4l2Format;\n> -\tcurV4L2Format_.fmt.pix.field = V4L2_FIELD_NONE;\n> -\tcurV4L2Format_.fmt.pix.bytesperline = streamConfig.stride;\n> -\tcurV4L2Format_.fmt.pix.sizeimage = streamConfig.frameSize;\n> -\tcurV4L2Format_.fmt.pix.colorspace = V4L2_COLORSPACE_SRGB;\n> -\tcurV4L2Format_.fmt.pix.priv = V4L2_PIX_FMT_PRIV_MAGIC;\n> -\tcurV4L2Format_.fmt.pix.ycbcr_enc = V4L2_YCBCR_ENC_DEFAULT;\n> -\tcurV4L2Format_.fmt.pix.quantization = V4L2_QUANTIZATION_DEFAULT;\n> -\tcurV4L2Format_.fmt.pix.xfer_func = V4L2_XFER_FUNC_DEFAULT;\n> +\tv4l2PixFormat_.width = size.width;\n> +\tv4l2PixFormat_.height = size.height;\n> +\tv4l2PixFormat_.pixelformat = info.v4l2Format;\n> +\tv4l2PixFormat_.field = V4L2_FIELD_NONE;\n> +\tv4l2PixFormat_.bytesperline = streamConfig.stride;\n> +\tv4l2PixFormat_.sizeimage = streamConfig.frameSize;\n> +\tv4l2PixFormat_.colorspace = V4L2_COLORSPACE_SRGB;\n> +\tv4l2PixFormat_.priv = V4L2_PIX_FMT_PRIV_MAGIC;\n> +\tv4l2PixFormat_.ycbcr_enc = V4L2_YCBCR_ENC_DEFAULT;\n> +\tv4l2PixFormat_.quantization = V4L2_QUANTIZATION_DEFAULT;\n> +\tv4l2PixFormat_.xfer_func = V4L2_XFER_FUNC_DEFAULT;\n> \n> \tsizeimage_ = streamConfig.frameSize;\n> }\n> @@ -291,7 +291,7 @@ int V4L2CameraProxy::vidioc_g_fmt(V4L2CameraFile *file, struct v4l2_format *arg)\n> \t\treturn -EINVAL;\n> \n> \tmemset(&arg->fmt, 0, sizeof(arg->fmt));\n> -\targ->fmt.pix = curV4L2Format_.fmt.pix;\n> +\targ->fmt.pix = v4l2PixFormat_;\n> \n> \treturn 0;\n> }\n> @@ -488,8 +488,8 @@ int V4L2CameraProxy::vidioc_reqbufs(V4L2CameraFile *file, struct v4l2_requestbuf\n> \tif (bufferCount_ > 0)\n> \t\tfreeBuffers();\n> \n> -\tSize size(curV4L2Format_.fmt.pix.width, curV4L2Format_.fmt.pix.height);\n> -\tV4L2PixelFormat v4l2Format = V4L2PixelFormat(curV4L2Format_.fmt.pix.pixelformat);\n> +\tSize size(v4l2PixFormat_.width, v4l2PixFormat_.height);\n> +\tV4L2PixelFormat v4l2Format = V4L2PixelFormat(v4l2PixFormat_.pixelformat);\n> \tint ret = vcam_->configure(&streamConfig_, size,\n> \t\t\t\t PixelFormatInfo::info(v4l2Format).format,\n> \t\t\t\t arg->count);\n> @@ -511,9 +511,9 @@ int V4L2CameraProxy::vidioc_reqbufs(V4L2CameraFile *file, struct v4l2_requestbuf\n> \tfor (unsigned int i = 0; i < arg->count; i++) {\n> \t\tstruct v4l2_buffer buf = {};\n> \t\tbuf.type = V4L2_BUF_TYPE_VIDEO_CAPTURE;\n> -\t\tbuf.length = curV4L2Format_.fmt.pix.sizeimage;\n> +\t\tbuf.length = v4l2PixFormat_.sizeimage;\n> \t\tbuf.memory = V4L2_MEMORY_MMAP;\n> -\t\tbuf.m.offset = i * curV4L2Format_.fmt.pix.sizeimage;\n> +\t\tbuf.m.offset = i * v4l2PixFormat_.sizeimage;\n> \t\tbuf.index = i;\n> \t\tbuf.flags = V4L2_BUF_FLAG_TIMESTAMP_MONOTONIC;\n> \n> diff --git a/src/v4l2/v4l2_camera_proxy.h b/src/v4l2/v4l2_camera_proxy.h\n> index 79eb87bcea51..92a79abb9e21 100644\n> --- a/src/v4l2/v4l2_camera_proxy.h\n> +++ b/src/v4l2/v4l2_camera_proxy.h\n> @@ -73,13 +73,14 @@ private:\n> \tunsigned int refcount_;\n> \tunsigned int index_;\n> \n> -\tstruct v4l2_format curV4L2Format_;\n> \tStreamConfiguration streamConfig_;\n> -\tstruct v4l2_capability capabilities_;\n> \tunsigned int bufferCount_;\n> \tunsigned int currentBuf_;\n> \tunsigned int sizeimage_;\n> \n> +\tstruct v4l2_capability capabilities_;\n> +\tstruct v4l2_pix_format v4l2PixFormat_;\n> +\n> \tstd::vector buffers_;\n> \tstd::map mmaps_;\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 570C8BE173\n\tfor ;\n\tTue, 25 Aug 2020 03:20:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E0DBA61EA0;\n\tTue, 25 Aug 2020 05:20:46 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AF1686170D\n\tfor ;\n\tTue, 25 Aug 2020 05:20:44 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E138829E;\n\tTue, 25 Aug 2020 05:20:36 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"OBCQNdg8\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1598325640;\n\tbh=b5rKUMzSpm0KIVTQ5LyeUpGto2Iji+/D7o12+eLt+NM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=OBCQNdg8q0tlmzVKaND2uY8CcyxXSsdbs65FKXvntPO8e5f2zhfZCNfyXoQ8+YNSF\n\tayPagELgjsYXr/FkUSy4M/XghIR9TLW8aQmyUuTSMypEy0MODJ2r3kbTJnyoRLNxJM\n\tt+gxWQOuvhOdIHC0nvyqP4TT08IkFQEI/tWXzwHs=","Date":"Tue, 25 Aug 2020 12:20:29 +0900","From":"paul.elder@ideasonboard.com","To":"Laurent Pinchart ","Message-ID":"<20200825032029.GC1982@pyrite.rasen.tech>","References":"<20200822134605.17666-1-laurent.pinchart@ideasonboard.com>\n\t<20200822134605.17666-3-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200822134605.17666-3-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 2/3] v4l2: camera_proxy: Store\n\tv4l2_pix_format instead of v4l2_format","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]