{"id":9361,"url":"https://patchwork.libcamera.org/api/patches/9361/?format=json","web_url":"https://patchwork.libcamera.org/patch/9361/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200822134605.17666-2-laurent.pinchart@ideasonboard.com>","date":"2020-08-22T13:46:03","name":"[libcamera-devel,1/3] v4l2: camera_proxy: Pass const reference to setFmtFromConfig()","commit_ref":"a6c831a996360329bbf8e02a68a76fb556ed844b","pull_url":null,"state":"accepted","archived":false,"hash":"5d4ae682345417f0c59d8968fef23492daf308d3","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/9361/mbox/","series":[{"id":1232,"url":"https://patchwork.libcamera.org/api/series/1232/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1232","date":"2020-08-22T13:46:02","name":"v4l2: Miscellaneous cleanups","version":1,"mbox":"https://patchwork.libcamera.org/series/1232/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/9361/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/9361/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A3055BE174\n\tfor ;\n\tSat, 22 Aug 2020 13:46:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C4DF862758;\n\tSat, 22 Aug 2020 15:46:29 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2FEE76212A\n\tfor ;\n\tSat, 22 Aug 2020 15:46:28 +0200 (CEST)","from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BFE6E4FB\n\tfor ;\n\tSat, 22 Aug 2020 15:46:27 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"RuTeVQaf\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1598103987;\n\tbh=YoBvnr6VFlU1YA0d/v0pZ8gRr1ZEXwd5b91OeX700cY=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=RuTeVQafkDTVfPMtkMCgd07NH7I40gVQUgirC+s3QCgPXemQSVDQKk8sb04ek9TCV\n\t4g4yZglZM4VusmKN4Sv/m13su+xLtovjUhxBCAFP8o3Cxr7xYL4rDkow/K9pyRlbac\n\tl9NzEhPJRPPZoDjkWwZ/0eefmcugj2Tjk2NMt664=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Sat, 22 Aug 2020 16:46:03 +0300","Message-Id":"<20200822134605.17666-2-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20200822134605.17666-1-laurent.pinchart@ideasonboard.com>","References":"<20200822134605.17666-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH 1/3] v4l2: camera_proxy: Pass const\n\treference to setFmtFromConfig()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The setFmtFromConfig() method doesn't modify its parameter, make it\nconst.\n\nSigned-off-by: Laurent Pinchart \n---\n src/v4l2/v4l2_camera_proxy.cpp | 4 ++--\n src/v4l2/v4l2_camera_proxy.h | 2 +-\n 2 files changed, 3 insertions(+), 3 deletions(-)","diff":"diff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp\nindex 63affaeec1b3..079257f4bf22 100644\n--- a/src/v4l2/v4l2_camera_proxy.cpp\n+++ b/src/v4l2/v4l2_camera_proxy.cpp\n@@ -162,10 +162,10 @@ bool V4L2CameraProxy::validateMemoryType(uint32_t memory)\n \treturn memory == V4L2_MEMORY_MMAP;\n }\n \n-void V4L2CameraProxy::setFmtFromConfig(StreamConfiguration &streamConfig)\n+void V4L2CameraProxy::setFmtFromConfig(const StreamConfiguration &streamConfig)\n {\n \tconst PixelFormatInfo &info = PixelFormatInfo::info(streamConfig.pixelFormat);\n-\tSize size = streamConfig.size;\n+\tconst Size &size = streamConfig.size;\n \n \tcurV4L2Format_.fmt.pix.width = size.width;\n \tcurV4L2Format_.fmt.pix.height = size.height;\ndiff --git a/src/v4l2/v4l2_camera_proxy.h b/src/v4l2/v4l2_camera_proxy.h\nindex f06b5b87083c..79eb87bcea51 100644\n--- a/src/v4l2/v4l2_camera_proxy.h\n+++ b/src/v4l2/v4l2_camera_proxy.h\n@@ -39,7 +39,7 @@ public:\n private:\n \tbool validateBufferType(uint32_t type);\n \tbool validateMemoryType(uint32_t memory);\n-\tvoid setFmtFromConfig(StreamConfiguration &streamConfig);\n+\tvoid setFmtFromConfig(const StreamConfiguration &streamConfig);\n \tvoid querycap(std::shared_ptr camera);\n \tint tryFormat(struct v4l2_format *arg);\n \tenum v4l2_priority maxPriority();\n","prefixes":["libcamera-devel","1/3"]}