{"id":9342,"url":"https://patchwork.libcamera.org/api/patches/9342/?format=json","web_url":"https://patchwork.libcamera.org/patch/9342/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200821144601.67860-2-email@uajain.com>","date":"2020-08-21T14:46:06","name":"[libcamera-devel,v4,1/5] libcamera: pipeline: uvcvideo: Treat all UVC cameras as external","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"cabc071127a4c631e98a174dec39b4be3f7f2817","submitter":{"id":1,"url":"https://patchwork.libcamera.org/api/people/1/?format=json","name":"Umang Jain","email":"email@uajain.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/9342/mbox/","series":[{"id":1227,"url":"https://patchwork.libcamera.org/api/series/1227/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1227","date":"2020-08-21T14:46:06","name":"android: Camera hotplug support","version":4,"mbox":"https://patchwork.libcamera.org/series/1227/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/9342/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/9342/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F40ABBD87C\n\tfor ;\n\tFri, 21 Aug 2020 14:46:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5169F61FE7;\n\tFri, 21 Aug 2020 16:46:11 +0200 (CEST)","from o1.f.az.sendgrid.net (o1.f.az.sendgrid.net [208.117.55.132])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5C25360383\n\tfor ;\n\tFri, 21 Aug 2020 16:46:08 +0200 (CEST)","by filterdrecv-p3iad2-86945d9569-xwnpr with SMTP id\n\tfilterdrecv-p3iad2-86945d9569-xwnpr-20-5F3FDE2E-87\n\t2020-08-21 14:46:06.855812348 +0000 UTC m=+74586.787788678","from mail.uajain.com (unknown)\n\tby ismtpd0008p1hnd1.sendgrid.net (SG) with ESMTP\n\tid AVVJrOyqR2SNmZOB4qEiJQ Fri, 21 Aug 2020 14:46:06.357 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=uajain.com header.i=@uajain.com\n\theader.b=\"WaqZTsY2\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=uajain.com;\n\th=from:subject:in-reply-to:references:mime-version:to:cc:content-type:\n\tcontent-transfer-encoding;\n\ts=s1; bh=bDhthrO6iz7youdFrsP8Xzu7GFBabmYGQfFNjuzf8Lc=;\n\tb=WaqZTsY2hutRcHqoJGwgw4ttEFkCewsijvh29xo7SUHRYq79vzRitpW61g5TIzfnI8LM\n\t9jXFPDcBXrHl+7dlz6C/cwBQ0QlZCw/8f3bjexoa+XQP9vSECRTJsRhvZ2QKXMZgTi6DRw\n\tEuTBVgiW6xCrZnGpHz0QLbtKILpXETfKs=","From":"Umang Jain ","Date":"Fri, 21 Aug 2020 14:46:06 +0000 (UTC)","Message-Id":"<20200821144601.67860-2-email@uajain.com>","In-Reply-To":"<20200821144601.67860-1-email@uajain.com>","References":"<20200821144601.67860-1-email@uajain.com>","Mime-Version":"1.0","X-SG-EID":"1Q40EQ7YGir8a9gjSIAdTjhngY657NMk9ckeo4dbHZDiOpywc/L3L9rFqlwE4KPcREc2X1LpIgLW8oEasGbeg5/y0q7HvjiQWMRkTS5oElgo/JeCQCPn9EsF5tlGGDhq4LXmXWmJEuIPcNbZFdW6/7ePNjbBuCTboxcjujj2FW5MfpQbnUlVW/RIJKgm6hxW+ID3GLS63dyLAUBmso/UPP+45SSrTl0CGQs5UC7AFpTnGMWLQ5NryqcjNx5h3qFJ688qzzkMoyS+k2XfODpE8Q==","To":"libcamera-devel@lists.libcamera.org","Subject":"[libcamera-devel] [PATCH v4 1/5] libcamera: pipeline: uvcvideo:\n\tTreat all UVC cameras as external","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"We currently have no way to identify if the UVC device is external\nor internal(i.e. non-removable) to the system to set this property.\nUntil we have a starting point to resolve this, treat all UVC cameras.\nAdd a \\todo explaining the situation for the same.\n\nSigned-off-by: Umang Jain \nReviewed-by: Kieran Bingham \nReviewed-by: Laurent Pinchart \nReviewed-by: Niklas Söderlund \n---\n src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 7 +++++++\n 1 file changed, 7 insertions(+)","diff":"diff --git a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\nindex bc892ec..bafe6f1 100644\n--- a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n+++ b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n@@ -14,6 +14,7 @@\n #include \n #include \n #include \n+#include \n #include \n #include \n \n@@ -500,6 +501,12 @@ int UVCCameraData::init(MediaEntity *entity)\n \n \tvideo_->bufferReady.connect(this, &UVCCameraData::bufferReady);\n \n+\t/*\n+\t * \\todo Find a way to tell internal and external UVC cameras apart.\n+\t * Until then, treat all UVC cameras as external.\n+\t */\n+\tproperties_.set(properties::Location, properties::CameraLocationExternal);\n+\n \t/* Initialise the supported controls. */\n \tControlInfoMap::Map ctrls;\n \n","prefixes":["libcamera-devel","v4","1/5"]}