[{"id":12099,"web_url":"https://patchwork.libcamera.org/comment/12099/","msgid":"<20200823224649.GL6002@pendragon.ideasonboard.com>","date":"2020-08-23T22:46:49","subject":"Re: [libcamera-devel] [PATCH] libcamera: object: Fix deleteLater()\n\tsample code","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Umang,\n\nThank you for the patch.\n\nOn Fri, Aug 21, 2020 at 06:40:28AM +0000, Umang Jain wrote:\n> Instead of using \"delete obj\" in the custom deleter of the shared\n> object, we should have been using the \"obj->deleteLater()\" to explain\n> how the deleteLater() API should be used in practice.\n> \n> Fixes: 9558886f7a85 (\"libcamera: object: Add deleteLater() support)\n> Signed-off-by: Umang Jain \n\nOops, indeed.\n\nReviewed-by: Laurent Pinchart \n\nWill push shortly.\n\n> ---\n> src/libcamera/object.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/object.cpp b/src/libcamera/object.cpp\n> index 647ccda..cd83c68 100644\n> --- a/src/libcamera/object.cpp\n> +++ b/src/libcamera/object.cpp\n> @@ -125,7 +125,7 @@ Object::~Object()\n> * struct Deleter : std::default_delete {\n> * void operator()(MyObject *obj)\n> * {\n> - * delete obj;\n> + * obj->deleteLater();\n> * }\n> * };\n> *","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 12192BE173\n\tfor ;\n\tSun, 23 Aug 2020 22:47:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7E2FC6271B;\n\tMon, 24 Aug 2020 00:47:09 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1E4F961EA0\n\tfor ;\n\tMon, 24 Aug 2020 00:47:08 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 968E8279;\n\tMon, 24 Aug 2020 00:47:07 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"tHxAbPhu\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1598222827;\n\tbh=DhbntOQgBxBBjE/4/IIH04t9uXY2XL7m4qgAlD1qYnE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=tHxAbPhu7fb835lMkdxCOZ6xLfKVwVALwSBsVUin38IYhT9AiwEbw3towK5g3drFQ\n\trrT4P4ghY2vCUX26rDDIbazjgmIXrqCmQzxDxFwyKP1I0LJBru47g6g3Ub29BjWQtL\n\tgXxSWXlLFtQfT4uo/cSs1u1m/XvVaHIsVmiz6+w0=","Date":"Mon, 24 Aug 2020 01:46:49 +0300","From":"Laurent Pinchart ","To":"Umang Jain ","Message-ID":"<20200823224649.GL6002@pendragon.ideasonboard.com>","References":"<20200821064023.12722-1-email@uajain.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200821064023.12722-1-email@uajain.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: object: Fix deleteLater()\n\tsample code","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]