[{"id":12047,"web_url":"https://patchwork.libcamera.org/comment/12047/","msgid":"<20200819144258.GN6049@pendragon.ideasonboard.com>","date":"2020-08-19T14:42:58","subject":"Re: [libcamera-devel] [PATCH v3 4/5] android: camera_device: Add a\n\tgetter to get libcamera::Camera pointer","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Umang,\n\nThank you for the patch.\n\nOn Mon, Aug 17, 2020 at 08:26:40PM +0000, Umang Jain wrote:\n> Add a public member function to get the libcamera::Camera pointer\n> associated with the CameraDevice. This will help to find the CameraDevice\n> object in CameraHalManager when the hotplug support is extended in the\n> android layer.\n\ns/android/Android/\n\n> Signed-off-by: Umang Jain \n> ---\n> src/android/camera_device.h | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/src/android/camera_device.h b/src/android/camera_device.h\n> index b149043..7908bc0 100644\n> --- a/src/android/camera_device.h\n> +++ b/src/android/camera_device.h\n> @@ -57,6 +57,7 @@ public:\n> \n> \tunsigned int id() const { return id_; }\n> \tcamera3_device_t *camera3Device() { return &camera3Device_; }\n> +\tconst libcamera::Camera *camera() { return camera_.get(); }\n\nYou can make this a const method\n\n\tconst libcamera::Camera *camera() const { return camera_.get(); }\n\nReviewed-by: Laurent Pinchart \n\n> \n> \tint facing() const { return facing_; }\n> \tint orientation() const { return orientation_; }","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B9A69BE173\n\tfor ;\n\tWed, 19 Aug 2020 14:43:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2F64561ECC;\n\tWed, 19 Aug 2020 16:43:18 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EADF26038C\n\tfor ;\n\tWed, 19 Aug 2020 16:43:16 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6E69429E;\n\tWed, 19 Aug 2020 16:43:16 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"gXA5p462\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1597848196;\n\tbh=Vk5aPkN80ON9F35E6mOgw5VUduB3v+Nw6oPOj9Z45zQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=gXA5p462d2A2vJvBPzfnJPuY8b3mtULkNcJKYarbjrSD+W3j3UvvFQjy+CLPYeBIB\n\tep6eEMIw2qb4909xk46UguJxWw2MEien4RLSBtQ3WAW53xAKMClxJ64vZ1DVL47y1q\n\tjmg+HFN8uig+OFfY+14kMXoqPlXuwvDMaY0nJrdk=","Date":"Wed, 19 Aug 2020 17:42:58 +0300","From":"Laurent Pinchart ","To":"Umang Jain ","Message-ID":"<20200819144258.GN6049@pendragon.ideasonboard.com>","References":"<20200817202629.4277-1-email@uajain.com>\n\t<20200817202629.4277-5-email@uajain.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200817202629.4277-5-email@uajain.com>","Subject":"Re: [libcamera-devel] [PATCH v3 4/5] android: camera_device: Add a\n\tgetter to get libcamera::Camera pointer","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":12055,"web_url":"https://patchwork.libcamera.org/comment/12055/","msgid":"<20200820073059.GF39265@wyvern>","date":"2020-08-20T07:30:59","subject":"Re: [libcamera-devel] [PATCH v3 4/5] android: camera_device: Add a\n\tgetter to get libcamera::Camera pointer","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Umang,\n\nThanks for your work.\n\nOn 2020-08-17 20:26:40 +0000, Umang Jain wrote:\n> Add a public member function to get the libcamera::Camera pointer\n> associated with the CameraDevice. This will help to find the CameraDevice\n> object in CameraHalManager when the hotplug support is extended in the\n> android layer.\n> \n> Signed-off-by: Umang Jain \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/android/camera_device.h | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/src/android/camera_device.h b/src/android/camera_device.h\n> index b149043..7908bc0 100644\n> --- a/src/android/camera_device.h\n> +++ b/src/android/camera_device.h\n> @@ -57,6 +57,7 @@ public:\n> \n> \tunsigned int id() const { return id_; }\n> \tcamera3_device_t *camera3Device() { return &camera3Device_; }\n> +\tconst libcamera::Camera *camera() { return camera_.get(); }\n> \n> \tint facing() const { return facing_; }\n> \tint orientation() const { return orientation_; }\n> -- \n> 2.26.2\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F3B53BE173\n\tfor ;\n\tThu, 20 Aug 2020 07:31:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9176A61E2B;\n\tThu, 20 Aug 2020 09:31:04 +0200 (CEST)","from mail-lf1-x142.google.com (mail-lf1-x142.google.com\n\t[IPv6:2a00:1450:4864:20::142])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B316960380\n\tfor ;\n\tThu, 20 Aug 2020 09:31:02 +0200 (CEST)","by mail-lf1-x142.google.com with SMTP id b30so413673lfj.12\n\tfor ;\n\tThu, 20 Aug 2020 00:31:02 -0700 (PDT)","from localhost (host-78-79-224-122.mobileonline.telia.com.\n\t[78.79.224.122]) by smtp.gmail.com with ESMTPSA id\n\te14sm274807ljl.96.2020.08.20.00.31.00\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 20 Aug 2020 00:31:01 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"vDtqpsP2\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=luLWYe49q2Q4wu8EH0XmvDNobgPQmkPZBu/RnI79ZSk=;\n\tb=vDtqpsP2xN8eP9QYov4mdFYE7cv030Edc47QymJrKUSIRIoVjPhZmD3qNHN8ax8o2Q\n\tBNyTRmVSCVQ28FdBnR9pT1yPc/rAkJYOS/QDa+ejWT7BIEhD+RK8i9/UrLGQMPMv0alk\n\tJMo28MsZ25VRV9THjLOfIHAzr0Sc5Hezd8mLMBmbO5u3016sYDRmlcHk7EM1VGL4kZ5n\n\tctviVsacehPKhb6I6DBICA6Vos/IbPKG6mN4M6OgaNPAtV6bKQjEo0i4mCCoIbbVYIha\n\tAvcm1lAEx+RbtJ566XNpzTlYG0mIOWH2/SxNLvQctKVMmNo+8zsdx/BRZl0J9I2mRGPU\n\tMs4A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=luLWYe49q2Q4wu8EH0XmvDNobgPQmkPZBu/RnI79ZSk=;\n\tb=QKZYjehykNr9vZ1kYKDMRdxMyrtiKLgD+1lcbusJoXtTzjjZJYu+r89L0mYb+279ot\n\tBRbQF6QHmzlDWeVUsy7DKqp3JNLYfh7dTBZjNt27nVXnlRrhwBwM8HeJc/X+bgYMSjLY\n\tvgpYaGUdTKv4eNua2Z+Zj3cUpsBlOGHryUEzYXbJFLakqsL/3UzdBMSNbplFETMcG3W/\n\tUkDNstav+ASN68LiYUAJ+1m7ICQPFRN9SatOpO8Ta8yRThBxrka+6DFFqEDHa933PHGt\n\tcx/qSJL0TgtmFwNRe5nCO6vjTCt4+bwOfsgnL7mEal13HxsfBgIH/L0FGRt+fp+bOliv\n\tLDzQ==","X-Gm-Message-State":"AOAM532E3bSNauw4Jt6vRqV3SHCvD4q5cpxPDo7wowMnvzVH7f5L/53g\n\tcoOafqubP9I6HhiiSPynsSr5GD65IeVhOywur4I=","X-Google-Smtp-Source":"ABdhPJydySOKZHGxny2lTF6ARg/ITTTj4mbBBvFvd8gVDDYDBS+hILoFxmGKHjVyK/1KvP1PMlo3/w==","X-Received":"by 2002:a05:6512:752:: with SMTP id\n\tc18mr970343lfs.53.1597908662163; \n\tThu, 20 Aug 2020 00:31:02 -0700 (PDT)","Date":"Thu, 20 Aug 2020 09:30:59 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Umang Jain ","Message-ID":"<20200820073059.GF39265@wyvern>","References":"<20200817202629.4277-1-email@uajain.com>\n\t<20200817202629.4277-5-email@uajain.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200817202629.4277-5-email@uajain.com>","Subject":"Re: [libcamera-devel] [PATCH v3 4/5] android: camera_device: Add a\n\tgetter to get libcamera::Camera pointer","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]