[{"id":12019,"web_url":"https://patchwork.libcamera.org/comment/12019/","msgid":"<20200814134305.GB2182981@oden.dyn.berto.se>","date":"2020-08-14T13:43:05","subject":"Re: [libcamera-devel] [PATCH] libcamera: request: Facilitate\n\tretrieval of the camera","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Kieran,\n\nOn 2020-08-14 14:37:14 +0100, Kieran Bingham wrote:\n> Provide a means of identifying the Camera object which created the Request.\n> \n> This allows identifying the correct Camera device to work with in completion\n> callbacks which are not otherwise wrapped with a means to identify the\n> Camera responsible for completion.\n> \n> Signed-off-by: Kieran Bingham \n\nAs discussed on IRC I think this is going in the wrong direction for \nwhat we want to do with Request's going forward. I might be wrong and \nthe patch itself is fine,\n\nReviewed-by: Niklas Söderlund \n\n> ---\n> include/libcamera/request.h | 2 ++\n> src/libcamera/request.cpp | 7 +++++++\n> 2 files changed, 9 insertions(+)\n> \n> diff --git a/include/libcamera/request.h b/include/libcamera/request.h\n> index eded68318b7d..ae8d450da20b 100644\n> --- a/include/libcamera/request.h\n> +++ b/include/libcamera/request.h\n> @@ -36,6 +36,8 @@ public:\n> \tRequest &operator=(const Request &) = delete;\n> \t~Request();\n> \n> +\tCamera *camera() const { return camera_; }\n> +\n> \tControlList &controls() { return *controls_; }\n> \tControlList &metadata() { return *metadata_; }\n> \tconst std::map &buffers() const { return bufferMap_; }\n> diff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp\n> index f3753514131a..3ef0e061a270 100644\n> --- a/src/libcamera/request.cpp\n> +++ b/src/libcamera/request.cpp\n> @@ -80,6 +80,13 @@ Request::~Request()\n> \tdelete validator_;\n> }\n> \n> +/**\n> + * \\fn Request::camera()\n> + * \\brief Retrieve the camera that created the request\n> + *\n> + * \\return A pointer to the camera associated with the request\n> + */\n> +\n> /**\n> * \\fn Request::controls()\n> * \\brief Retrieve the request's ControlList\n> -- \n> 2.25.1\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 89AE2BD87D\n\tfor ;\n\tFri, 14 Aug 2020 13:43:09 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D1DC261618;\n\tFri, 14 Aug 2020 15:43:08 +0200 (CEST)","from mail-lj1-x244.google.com (mail-lj1-x244.google.com\n\t[IPv6:2a00:1450:4864:20::244])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 566F06038B\n\tfor ;\n\tFri, 14 Aug 2020 15:43:07 +0200 (CEST)","by mail-lj1-x244.google.com with SMTP id t23so9993485ljc.3\n\tfor ;\n\tFri, 14 Aug 2020 06:43:07 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\td26sm1887390lfq.73.2020.08.14.06.43.05\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 14 Aug 2020 06:43:05 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"KkvQx1SX\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=otwj9KJSXmGf0di2cLAFN4ZZRLH4uLNcC0qrO71dHGc=;\n\tb=KkvQx1SXc+0Tb4og+oF0iLBFeE6BAIG2y5DB+O9UNDPqC2yTkCQtifzg/0BIzr01Jq\n\tq4FKstgNx2T40/q4td4JmS0A5Afb8kIkuJx/pOrNaz7I/BbqZ1xDH7mR6FcbN9wlpcW/\n\tQ/o7m1aSUrFJM6z70+YRmcgGKofitcBFCAlDMuSW6wE5y+P2MREKrHMRItoH6dRW1RWI\n\tmmH1VqhqOCECazktGbRdxrT0YLaT++6TKFSRsFMbRNbxI4FdcNUD/mOI48wEOVSj0K2B\n\tJvCPFzZEtd9ur5s7+6HkQ6hkbYRhJWDtGerQYDft380/CNpFdIPEjbKcWoivFtvEcwJT\n\tw9pw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=otwj9KJSXmGf0di2cLAFN4ZZRLH4uLNcC0qrO71dHGc=;\n\tb=PsUX1xkA1rmUi23wFXd215vj9CWxtyogrXVglcNfg66AXLdWIWRRLrAf1BpxzLhDil\n\tCmPFnaZWTFvRXkLuTOo5srbsPVWBhY/pF8vhntmKJuqugGgUOho3k3wmyB6+gSYeHGg2\n\tGWtfjEVbVEgfYqbdxgPwSBKGG1UeLJfMU8mQm9DGo+7RqCdSNO5PxD0VZO5DO0+A2J99\n\tGqqHrPC/lMJAcjcWI6bqIN5CEPGEeDHln7ogMoI20vt+i7ztCphxgjwlex5QLgzyp7Q/\n\tkKlANY0o4Z6XthiIbQZ4A1peqyJ/2iWmopRaz6ItYq6RLoGISg4TxLwVxuz3UjIiE+kp\n\tIXrQ==","X-Gm-Message-State":"AOAM531MyySNUdwr6CiJLWgx0XBZ9fOnoOQXZ7x/UkKQLBJnXUple+x7\n\tvhViAhw9xmEm8NG4GmsSqP7wkQ==","X-Google-Smtp-Source":"ABdhPJywdKbODgwxPVsE7uPu355DaNCjNe4lEJHkRri1DWi4o4whHDIusjLWzi99z7EfbhS5g++vGg==","X-Received":"by 2002:a2e:b175:: with SMTP id\n\ta21mr1373122ljm.385.1597412586635; \n\tFri, 14 Aug 2020 06:43:06 -0700 (PDT)","Date":"Fri, 14 Aug 2020 15:43:05 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Kieran Bingham ","Message-ID":"<20200814134305.GB2182981@oden.dyn.berto.se>","References":"<20200814133714.46846-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200814133714.46846-1-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: request: Facilitate\n\tretrieval of the camera","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":12020,"web_url":"https://patchwork.libcamera.org/comment/12020/","msgid":"<2fc166f8-8a23-f3da-f184-3d621c48da00@ideasonboard.com>","date":"2020-08-14T13:55:39","subject":"Re: [libcamera-devel] [PATCH] libcamera: request: Facilitate\n\tretrieval of the camera","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Niklas,\n\nOn 14/08/2020 14:43, Niklas Söderlund wrote:\n> Hi Kieran,\n> \n> On 2020-08-14 14:37:14 +0100, Kieran Bingham wrote:\n>> Provide a means of identifying the Camera object which created the Request.\n>>\n>> This allows identifying the correct Camera device to work with in completion\n>> callbacks which are not otherwise wrapped with a means to identify the\n>> Camera responsible for completion.\n>>\n>> Signed-off-by: Kieran Bingham \n> \n> As discussed on IRC I think this is going in the wrong direction for \n> what we want to do with Request's going forward. I might be wrong and \n> the patch itself is fine,\n> \n> Reviewed-by: Niklas Söderlund \n\nThanks, indeed I posted the patch so it could be discussed and\ndetermined here ;-)\n\n--\nKieran\n\n\n> \n>> ---\n>> include/libcamera/request.h | 2 ++\n>> src/libcamera/request.cpp | 7 +++++++\n>> 2 files changed, 9 insertions(+)\n>>\n>> diff --git a/include/libcamera/request.h b/include/libcamera/request.h\n>> index eded68318b7d..ae8d450da20b 100644\n>> --- a/include/libcamera/request.h\n>> +++ b/include/libcamera/request.h\n>> @@ -36,6 +36,8 @@ public:\n>> \tRequest &operator=(const Request &) = delete;\n>> \t~Request();\n>> \n>> +\tCamera *camera() const { return camera_; }\n>> +\n>> \tControlList &controls() { return *controls_; }\n>> \tControlList &metadata() { return *metadata_; }\n>> \tconst std::map &buffers() const { return bufferMap_; }\n>> diff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp\n>> index f3753514131a..3ef0e061a270 100644\n>> --- a/src/libcamera/request.cpp\n>> +++ b/src/libcamera/request.cpp\n>> @@ -80,6 +80,13 @@ Request::~Request()\n>> \tdelete validator_;\n>> }\n>> \n>> +/**\n>> + * \\fn Request::camera()\n>> + * \\brief Retrieve the camera that created the request\n>> + *\n>> + * \\return A pointer to the camera associated with the request\n>> + */\n>> +\n>> /**\n>> * \\fn Request::controls()\n>> * \\brief Retrieve the request's ControlList\n>> -- \n>> 2.25.1\n>>\n>> _______________________________________________\n>> libcamera-devel mailing list\n>> libcamera-devel@lists.libcamera.org\n>> https://lists.libcamera.org/listinfo/libcamera-devel\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1519FBD87C\n\tfor ;\n\tFri, 14 Aug 2020 13:55:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7C438613EC;\n\tFri, 14 Aug 2020 15:55:44 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EAD9A6038B\n\tfor ;\n\tFri, 14 Aug 2020 15:55:42 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4EA3F551;\n\tFri, 14 Aug 2020 15:55:42 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ClneEimb\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1597413342;\n\tbh=dRq8JYHOTJxlDopPjX0zOUgnVZRZuDpPDZz/xB3aIAU=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=ClneEimbCMCiyCsKY9tp2UxzZvgY3y6QISx45lSlKstK5tVJPTuq36o3BA4PYQyay\n\tFawzId5Cg+Xq0v+ydknTgQ9ETBPCAqDhIrMe7DDFpFLxn5flBWisf3x7DYvl7SMYQ+\n\tC45rsboIE9EOGrnxvZi5uN/EeTAwG5r7Jir+R2WQ=","To":"=?utf-8?q?Niklas_S=C3=B6derlund?= ","References":"<20200814133714.46846-1-kieran.bingham@ideasonboard.com>\n\t<20200814134305.GB2182981@oden.dyn.berto.se>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<2fc166f8-8a23-f3da-f184-3d621c48da00@ideasonboard.com>","Date":"Fri, 14 Aug 2020 14:55:39 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20200814134305.GB2182981@oden.dyn.berto.se>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH] libcamera: request: Facilitate\n\tretrieval of the camera","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]