{"id":9327,"url":"https://patchwork.libcamera.org/api/patches/9327/?format=json","web_url":"https://patchwork.libcamera.org/patch/9327/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200814104509.189023-4-niklas.soderlund@ragnatech.se>","date":"2020-08-14T10:45:09","name":"[libcamera-devel,v2,3/3] libcamera: camera: Mark controls() and properties() as const operations","commit_ref":"54ca46968a18ab938fc61f9424f421a004f50405","pull_url":null,"state":"accepted","archived":false,"hash":"656c0c7f19f9eeb36cafc49914ac3de2483d953c","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/?format=json","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/9327/mbox/","series":[{"id":1220,"url":"https://patchwork.libcamera.org/api/series/1220/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1220","date":"2020-08-14T10:45:06","name":"libcamera: Mark controls and property accessors as const operations","version":2,"mbox":"https://patchwork.libcamera.org/series/1220/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/9327/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/9327/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 78B7DBD87D\n\tfor ;\n\tFri, 14 Aug 2020 10:45:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D024B61618;\n\tFri, 14 Aug 2020 12:45:22 +0200 (CEST)","from vsp-unauthed02.binero.net (vsp-unauthed02.binero.net\n\t[195.74.38.227])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3D3EC613B4\n\tfor ;\n\tFri, 14 Aug 2020 12:45:21 +0200 (CEST)","from bismarck.berto.se (p54ac52a8.dip0.t-ipconnect.de\n\t[84.172.82.168]) by bin-vsp-out-02.atm.binero.net (Halon) with ESMTPA\n\tid 3fafff09-de1b-11ea-a39b-005056917f90;\n\tFri, 14 Aug 2020 12:45:20 +0200 (CEST)"],"X-Halon-ID":"3fafff09-de1b-11ea-a39b-005056917f90","Authorized-sender":"niklas.soderlund@fsdn.se","From":"=?utf-8?q?Niklas_S=C3=B6derlund?= ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 14 Aug 2020 12:45:09 +0200","Message-Id":"<20200814104509.189023-4-niklas.soderlund@ragnatech.se>","X-Mailer":"git-send-email 2.28.0","In-Reply-To":"<20200814104509.189023-1-niklas.soderlund@ragnatech.se>","References":"<20200814104509.189023-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v2 3/3] libcamera: camera: Mark controls()\n\tand properties() as const operations","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Reading the controls and properties does not modify the camera's state\nand can be marked as const operations.\n\nSigned-off-by: Niklas Söderlund \nReviewed-by: Kieran Bingham \n---\n* Changes since v1\n- Spelling in commit message.\n---\n include/libcamera/camera.h | 4 ++--\n src/libcamera/camera.cpp | 4 ++--\n 2 files changed, 4 insertions(+), 4 deletions(-)","diff":"diff --git a/include/libcamera/camera.h b/include/libcamera/camera.h\nindex 48d88d64a0a94050..272c12c3c47392fc 100644\n--- a/include/libcamera/camera.h\n+++ b/include/libcamera/camera.h\n@@ -86,8 +86,8 @@ public:\n \tint acquire();\n \tint release();\n \n-\tconst ControlInfoMap &controls();\n-\tconst ControlList &properties();\n+\tconst ControlInfoMap &controls() const;\n+\tconst ControlList &properties() const;\n \n \tconst std::set &streams() const;\n \tstd::unique_ptr generateConfiguration(const StreamRoles &roles = {});\ndiff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\nindex 820fa1e3065e5f88..1685697b8ebbebcb 100644\n--- a/src/libcamera/camera.cpp\n+++ b/src/libcamera/camera.cpp\n@@ -658,7 +658,7 @@ int Camera::release()\n *\n * \\return A ControlInfoMap listing the controls supported by the camera\n */\n-const ControlInfoMap &Camera::controls()\n+const ControlInfoMap &Camera::controls() const\n {\n \treturn p_->pipe_->controls(this);\n }\n@@ -671,7 +671,7 @@ const ControlInfoMap &Camera::controls()\n *\n * \\return A ControlList of properties supported by the camera\n */\n-const ControlList &Camera::properties()\n+const ControlList &Camera::properties() const\n {\n \treturn p_->pipe_->properties(this);\n }\n","prefixes":["libcamera-devel","v2","3/3"]}