[{"id":12025,"web_url":"https://patchwork.libcamera.org/comment/12025/","msgid":"<20200816131432.GG32174@pendragon.ideasonboard.com>","date":"2020-08-16T13:14:32","subject":"Re: [libcamera-devel] [PATCH v4 5/7] libcamera: pipeline: uvcvideo:\n\tSet sensor model property","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patch.\n\nOn Fri, Aug 14, 2020 at 12:37:20AM +0200, Niklas Söderlund wrote:\n> Set the sensor model property from the model reported in the media\n> graph.\n> \n> Signed-off-by: Niklas Söderlund \n> Reviewed-by: Kieran Bingham \n> ---\n> * Changes since v1\n> - Ensure model string only contains ASCII characters.\n> ---\n> src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 4 ++++\n> 1 file changed, 4 insertions(+)\n> \n> diff --git a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> index b12083a7a74dae54..a55049c5179bd78e 100644\n> --- a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> +++ b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> @@ -14,6 +14,7 @@\n> #include \n> #include \n> #include \n> +#include \n> #include \n> #include \n> \n> @@ -500,6 +501,9 @@ int UVCCameraData::init(MediaDevice *media)\n> \n> \tvideo_->bufferReady.connect(this, &UVCCameraData::bufferReady);\n> \n> +\t/* Initialize the camera properties. */\n> +\tproperties_.set(properties::Model, utils::toAscii(media->model()));\n> +\n\nSimilary to 3/7, the implementation is fine, but 1/7 needs to be\nfinalized before acking this.\n\n> \t/* Initialise the supported controls. */\n> \tControlInfoMap::Map ctrls;\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 19EE1BD879\n\tfor ;\n\tSun, 16 Aug 2020 13:14:50 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D6A366138F;\n\tSun, 16 Aug 2020 15:14:49 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 066BA60918\n\tfor ;\n\tSun, 16 Aug 2020 15:14:48 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8CD6FF9;\n\tSun, 16 Aug 2020 15:14:47 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"tL2pvgAj\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1597583687;\n\tbh=Lcwx8T4wh7iTOtEmKOpp5cGE0So7Vl5hc0Ea51gUAG8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=tL2pvgAjJamqznH6oqzIJk32IhYXz/SAbZ0NsAKoWOt6M2C3fWODSoE5G8OXUqZQV\n\t9TVFk6n+LsKpmhfZAu0syvR0Kj7v3wz0jqIm5Lk+/uawTdsjIxZcm5H9umdTYoq9uW\n\ttgIKQGsCvAwxvbYDdpj8pk6L7C/jerwsw5Rmg+Zs=","Date":"Sun, 16 Aug 2020 16:14:32 +0300","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Message-ID":"<20200816131432.GG32174@pendragon.ideasonboard.com>","References":"<20200813223722.4050835-1-niklas.soderlund@ragnatech.se>\n\t<20200813223722.4050835-6-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200813223722.4050835-6-niklas.soderlund@ragnatech.se>","Subject":"Re: [libcamera-devel] [PATCH v4 5/7] libcamera: pipeline: uvcvideo:\n\tSet sensor model property","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]