[{"id":12021,"web_url":"https://patchwork.libcamera.org/comment/12021/","msgid":"<20200816114930.GA32174@pendragon.ideasonboard.com>","date":"2020-08-16T11:49:30","subject":"Re: [libcamera-devel] [PATCH v4 1/7] libcamera: properties: Add\n\tmodel property","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patch.\n\nOn Fri, Aug 14, 2020 at 12:37:16AM +0200, Niklas Söderlund wrote:\n> The model property describes the camera model name.\n> \n> Signed-off-by: Niklas Söderlund \n> Reviewed-by: Kieran Bingham \n> ---\n> * Changes since v3\n> - s/as ASCII/in ASCII/\n> ---\n> src/libcamera/property_ids.yaml | 7 +++++++\n> 1 file changed, 7 insertions(+)\n> \n> diff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml\n> index 74ad0195d6310367..d3b2c3fb7f540012 100644\n> --- a/src/libcamera/property_ids.yaml\n> +++ b/src/libcamera/property_ids.yaml\n> @@ -387,6 +387,13 @@ controls:\n> | |\n> +--------------------+\n> \n> + - Model:\n> + type: string\n> + description: |\n> + Model name of the camera sensor. The format of the string is free-form\n> + and should be encoded in ASCII. Example model names are 'ov5670',\n\n\"should\" is only a recommendation, this needs to be a requirement.\n\n> + 'imx219' or 'Logitech Webcam C930e'.\n\nI'm sorry, but this is still inconsistent. The commit message says\n\"camera model name\", here the documentation states \"model name of the\ncamera sensor\". \"Logitech Webcam C930e\" is not a camera sensor model.\n\nThis needs more documentation. Saying \"it's free-form\" and giving a few\nexamples isn't enough, we need text that clearly documents the property.\nExamples are allowed, but may not replace the definition, only\ncomplement it.\n\n> +\n> - UnitCellSize:\n> type: Size\n> description: |","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DF467BD879\n\tfor ;\n\tSun, 16 Aug 2020 11:49:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6192D6170D;\n\tSun, 16 Aug 2020 13:49:48 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5820160385\n\tfor ;\n\tSun, 16 Aug 2020 13:49:46 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B5E9929F;\n\tSun, 16 Aug 2020 13:49:45 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"lATpSHdq\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1597578585;\n\tbh=ZdZy2zQGnWleq7tnHO6jFDC/wp3o54S6j9DR5coDOyE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=lATpSHdqbGsyvNWcQUKlg+tGeJtQMS/dfkE/4qRkgS40EgrjdCSYzWLrXpyzBwDAM\n\t4FNgFQgBME9/FlLxFMhng83ECGxeQxZo0s3HeFzZkO/3UtMDQOGL7nvKzlmFLf1KwA\n\tzuBzIvq94Qln8AUF04B06wj3Y46QOKxlZ85VHG6k=","Date":"Sun, 16 Aug 2020 14:49:30 +0300","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Message-ID":"<20200816114930.GA32174@pendragon.ideasonboard.com>","References":"<20200813223722.4050835-1-niklas.soderlund@ragnatech.se>\n\t<20200813223722.4050835-2-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200813223722.4050835-2-niklas.soderlund@ragnatech.se>","Subject":"Re: [libcamera-devel] [PATCH v4 1/7] libcamera: properties: Add\n\tmodel property","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]