[{"id":12060,"web_url":"https://patchwork.libcamera.org/comment/12060/","msgid":"<20200820084227.267v5ux257t4rj4t@uno.localdomain>","date":"2020-08-20T08:42:27","subject":"Re: [libcamera-devel] [PATCH 05/13] libcamera: pipeline: rkisp1:\n\tCreate RkISP1Frames from camera data","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Niklas,\n\nOn Thu, Aug 13, 2020 at 02:52:38AM +0200, Niklas Söderlund wrote:\n> Create RkISP1Frames from camera data instead of picking information out\n> form it. This is done to prepare for multi stream support where more\n> information from the camera data will be needed.\n>\n> Signed-off-by: Niklas Söderlund \n> ---\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 13 +++++++------\n> 1 file changed, 7 insertions(+), 6 deletions(-)\n>\n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> index a1cda12d244f2d97..9d5a52d352aefabc 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> @@ -52,6 +52,7 @@ static const std::array RKISP1_RSZ_MP_FORMATS{\n>\n> class PipelineHandlerRkISP1;\n> class RkISP1ActionQueueBuffers;\n> +class RkISP1CameraData;\n>\n> enum RkISP1ActionType {\n> \tSetSensor,\n> @@ -77,7 +78,7 @@ class RkISP1Frames\n> public:\n> \tRkISP1Frames(PipelineHandler *pipe);\n>\n> -\tRkISP1FrameInfo *create(unsigned int frame, Request *request, Stream *stream);\n> +\tRkISP1FrameInfo *create(const RkISP1CameraData *data, Request *request);\n\nShould data be a const & ?\n\nThis apart, the patch looks good\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> \tint destroy(unsigned int frame);\n> \tvoid clear();\n>\n> @@ -242,8 +243,10 @@ RkISP1Frames::RkISP1Frames(PipelineHandler *pipe)\n> {\n> }\n>\n> -RkISP1FrameInfo *RkISP1Frames::create(unsigned int frame, Request *request, Stream *stream)\n> +RkISP1FrameInfo *RkISP1Frames::create(const RkISP1CameraData *data, Request *request)\n> {\n> +\tunsigned int frame = data->frame_;\n> +\n> \tif (pipe_->availableParamBuffers_.empty()) {\n> \t\tLOG(RkISP1, Error) << \"Parameters buffer underrun\";\n> \t\treturn nullptr;\n> @@ -256,7 +259,7 @@ RkISP1FrameInfo *RkISP1Frames::create(unsigned int frame, Request *request, Stre\n> \t}\n> \tFrameBuffer *statBuffer = pipe_->availableStatBuffers_.front();\n>\n> -\tFrameBuffer *videoBuffer = request->findBuffer(stream);\n> +\tFrameBuffer *videoBuffer = request->findBuffer(&data->stream_);\n> \tif (!videoBuffer) {\n> \t\tLOG(RkISP1, Error)\n> \t\t\t<< \"Attempt to queue request with invalid stream\";\n> @@ -880,10 +883,8 @@ void PipelineHandlerRkISP1::stop(Camera *camera)\n> int PipelineHandlerRkISP1::queueRequestDevice(Camera *camera, Request *request)\n> {\n> \tRkISP1CameraData *data = cameraData(camera);\n> -\tStream *stream = &data->stream_;\n>\n> -\tRkISP1FrameInfo *info = data->frameInfo_.create(data->frame_, request,\n> -\t\t\t\t\t\t\tstream);\n> +\tRkISP1FrameInfo *info = data->frameInfo_.create(data, request);\n> \tif (!info)\n> \t\treturn -ENOENT;\n>\n> --\n> 2.28.0\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CE6BCBD87C\n\tfor ;\n\tThu, 20 Aug 2020 08:38:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6D6AB61F0F;\n\tThu, 20 Aug 2020 10:38:47 +0200 (CEST)","from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net\n\t[217.70.183.196])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D8B9F61ED9\n\tfor ;\n\tThu, 20 Aug 2020 10:38:45 +0200 (CEST)","from uno.localdomain (host-82-52-18-94.retail.telecomitalia.it\n\t[82.52.18.94]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 09BDCE000D;\n\tThu, 20 Aug 2020 08:38:44 +0000 (UTC)"],"X-Originating-IP":"82.52.18.94","Date":"Thu, 20 Aug 2020 10:42:27 +0200","From":"Jacopo Mondi ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Message-ID":"<20200820084227.267v5ux257t4rj4t@uno.localdomain>","References":"<20200813005246.3265807-1-niklas.soderlund@ragnatech.se>\n\t<20200813005246.3265807-6-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200813005246.3265807-6-niklas.soderlund@ragnatech.se>","Subject":"Re: [libcamera-devel] [PATCH 05/13] libcamera: pipeline: rkisp1:\n\tCreate RkISP1Frames from camera data","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":12074,"web_url":"https://patchwork.libcamera.org/comment/12074/","msgid":"<20200820150231.GK6593@pendragon.ideasonboard.com>","date":"2020-08-20T15:02:31","subject":"Re: [libcamera-devel] [PATCH 05/13] libcamera: pipeline: rkisp1:\n\tCreate RkISP1Frames from camera data","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patch.\n\nOn Thu, Aug 20, 2020 at 10:42:27AM +0200, Jacopo Mondi wrote:\n> On Thu, Aug 13, 2020 at 02:52:38AM +0200, Niklas Söderlund wrote:\n> > Create RkISP1Frames from camera data instead of picking information out\n> > form it. This is done to prepare for multi stream support where more\n\ns/form/from/\n\n> > information from the camera data will be needed.\n> >\n> > Signed-off-by: Niklas Söderlund \n> > ---\n> > src/libcamera/pipeline/rkisp1/rkisp1.cpp | 13 +++++++------\n> > 1 file changed, 7 insertions(+), 6 deletions(-)\n> >\n> > diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> > index a1cda12d244f2d97..9d5a52d352aefabc 100644\n> > --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> > +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> > @@ -52,6 +52,7 @@ static const std::array RKISP1_RSZ_MP_FORMATS{\n> >\n> > class PipelineHandlerRkISP1;\n> > class RkISP1ActionQueueBuffers;\n> > +class RkISP1CameraData;\n> >\n> > enum RkISP1ActionType {\n> > \tSetSensor,\n> > @@ -77,7 +78,7 @@ class RkISP1Frames\n> > public:\n> > \tRkISP1Frames(PipelineHandler *pipe);\n> >\n> > -\tRkISP1FrameInfo *create(unsigned int frame, Request *request, Stream *stream);\n> > +\tRkISP1FrameInfo *create(const RkISP1CameraData *data, Request *request);\n> \n> Should data be a const & ?\n> \n> This apart, the patch looks good\n> Reviewed-by: Jacopo Mondi \n>\n> > \tint destroy(unsigned int frame);\n> > \tvoid clear();\n> >\n> > @@ -242,8 +243,10 @@ RkISP1Frames::RkISP1Frames(PipelineHandler *pipe)\n> > {\n> > }\n> >\n> > -RkISP1FrameInfo *RkISP1Frames::create(unsigned int frame, Request *request, Stream *stream)\n> > +RkISP1FrameInfo *RkISP1Frames::create(const RkISP1CameraData *data, Request *request)\n> > {\n> > +\tunsigned int frame = data->frame_;\n> > +\n\nYou could do away with the local variable by using data->frame_ directly\nif desired.\n\nReviewed-by: Laurent Pinchart \n\n> > \tif (pipe_->availableParamBuffers_.empty()) {\n> > \t\tLOG(RkISP1, Error) << \"Parameters buffer underrun\";\n> > \t\treturn nullptr;\n> > @@ -256,7 +259,7 @@ RkISP1FrameInfo *RkISP1Frames::create(unsigned int frame, Request *request, Stre\n> > \t}\n> > \tFrameBuffer *statBuffer = pipe_->availableStatBuffers_.front();\n> >\n> > -\tFrameBuffer *videoBuffer = request->findBuffer(stream);\n> > +\tFrameBuffer *videoBuffer = request->findBuffer(&data->stream_);\n> > \tif (!videoBuffer) {\n> > \t\tLOG(RkISP1, Error)\n> > \t\t\t<< \"Attempt to queue request with invalid stream\";\n> > @@ -880,10 +883,8 @@ void PipelineHandlerRkISP1::stop(Camera *camera)\n> > int PipelineHandlerRkISP1::queueRequestDevice(Camera *camera, Request *request)\n> > {\n> > \tRkISP1CameraData *data = cameraData(camera);\n> > -\tStream *stream = &data->stream_;\n> >\n> > -\tRkISP1FrameInfo *info = data->frameInfo_.create(data->frame_, request,\n> > -\t\t\t\t\t\t\tstream);\n> > +\tRkISP1FrameInfo *info = data->frameInfo_.create(data, request);\n> > \tif (!info)\n> > \t\treturn -ENOENT;\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 66BA9BD87C\n\tfor ;\n\tThu, 20 Aug 2020 15:02:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0BC6A61F7B;\n\tThu, 20 Aug 2020 17:02:51 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A0AE760381\n\tfor ;\n\tThu, 20 Aug 2020 17:02:49 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2CAB423D;\n\tThu, 20 Aug 2020 17:02:49 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"SiofKvDX\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1597935769;\n\tbh=xbo4uuwVEWL8o3cS3tXTsyJBvc7OBwqTnWaT7VcbD5s=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=SiofKvDXKWjp514rWL8MxJ/tXuWZ/rXlMLo3mgyx3fa1GnIjl9eUZgUm3lmg2L2Dt\n\t4Xc5moLHwmrRWjp55GvdicHTaIZLgIpIKHSURinnfz+zb6CbsYoW0OtKgqpAYD2FBu\n\tZdjkS5Inxj2k9b6vXG/e6Sh3V/XZg1bx11PeQIBw=","Date":"Thu, 20 Aug 2020 18:02:31 +0300","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Message-ID":"<20200820150231.GK6593@pendragon.ideasonboard.com>","References":"<20200813005246.3265807-1-niklas.soderlund@ragnatech.se>\n\t<20200813005246.3265807-6-niklas.soderlund@ragnatech.se>\n\t<20200820084227.267v5ux257t4rj4t@uno.localdomain>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200820084227.267v5ux257t4rj4t@uno.localdomain>","Subject":"Re: [libcamera-devel] [PATCH 05/13] libcamera: pipeline: rkisp1:\n\tCreate RkISP1Frames from camera data","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":12488,"web_url":"https://patchwork.libcamera.org/comment/12488/","msgid":"<20200914093134.GD1127199@oden.dyn.berto.se>","date":"2020-09-14T09:31:34","subject":"Re: [libcamera-devel] [PATCH 05/13] libcamera: pipeline: rkisp1:\n\tCreate RkISP1Frames from camera data","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nOn 2020-08-20 10:42:27 +0200, Jacopo Mondi wrote:\n> Hi Niklas,\n> \n> On Thu, Aug 13, 2020 at 02:52:38AM +0200, Niklas Söderlund wrote:\n> > Create RkISP1Frames from camera data instead of picking information out\n> > form it. This is done to prepare for multi stream support where more\n> > information from the camera data will be needed.\n> >\n> > Signed-off-by: Niklas Söderlund \n> > ---\n> > src/libcamera/pipeline/rkisp1/rkisp1.cpp | 13 +++++++------\n> > 1 file changed, 7 insertions(+), 6 deletions(-)\n> >\n> > diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> > index a1cda12d244f2d97..9d5a52d352aefabc 100644\n> > --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> > +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> > @@ -52,6 +52,7 @@ static const std::array RKISP1_RSZ_MP_FORMATS{\n> >\n> > class PipelineHandlerRkISP1;\n> > class RkISP1ActionQueueBuffers;\n> > +class RkISP1CameraData;\n> >\n> > enum RkISP1ActionType {\n> > \tSetSensor,\n> > @@ -77,7 +78,7 @@ class RkISP1Frames\n> > public:\n> > \tRkISP1Frames(PipelineHandler *pipe);\n> >\n> > -\tRkISP1FrameInfo *create(unsigned int frame, Request *request, Stream *stream);\n> > +\tRkISP1FrameInfo *create(const RkISP1CameraData *data, Request *request);\n> \n> Should data be a const & ?\n\nIt could but camera data is a pointer in all other places and I see no \nharm in keeping it the same here.\n\n> \n> This apart, the patch looks good\n> Reviewed-by: Jacopo Mondi \n> \n> Thanks\n> j\n> \n> > \tint destroy(unsigned int frame);\n> > \tvoid clear();\n> >\n> > @@ -242,8 +243,10 @@ RkISP1Frames::RkISP1Frames(PipelineHandler *pipe)\n> > {\n> > }\n> >\n> > -RkISP1FrameInfo *RkISP1Frames::create(unsigned int frame, Request *request, Stream *stream)\n> > +RkISP1FrameInfo *RkISP1Frames::create(const RkISP1CameraData *data, Request *request)\n> > {\n> > +\tunsigned int frame = data->frame_;\n> > +\n> > \tif (pipe_->availableParamBuffers_.empty()) {\n> > \t\tLOG(RkISP1, Error) << \"Parameters buffer underrun\";\n> > \t\treturn nullptr;\n> > @@ -256,7 +259,7 @@ RkISP1FrameInfo *RkISP1Frames::create(unsigned int frame, Request *request, Stre\n> > \t}\n> > \tFrameBuffer *statBuffer = pipe_->availableStatBuffers_.front();\n> >\n> > -\tFrameBuffer *videoBuffer = request->findBuffer(stream);\n> > +\tFrameBuffer *videoBuffer = request->findBuffer(&data->stream_);\n> > \tif (!videoBuffer) {\n> > \t\tLOG(RkISP1, Error)\n> > \t\t\t<< \"Attempt to queue request with invalid stream\";\n> > @@ -880,10 +883,8 @@ void PipelineHandlerRkISP1::stop(Camera *camera)\n> > int PipelineHandlerRkISP1::queueRequestDevice(Camera *camera, Request *request)\n> > {\n> > \tRkISP1CameraData *data = cameraData(camera);\n> > -\tStream *stream = &data->stream_;\n> >\n> > -\tRkISP1FrameInfo *info = data->frameInfo_.create(data->frame_, request,\n> > -\t\t\t\t\t\t\tstream);\n> > +\tRkISP1FrameInfo *info = data->frameInfo_.create(data, request);\n> > \tif (!info)\n> > \t\treturn -ENOENT;\n> >\n> > --\n> > 2.28.0\n> >\n> > _______________________________________________\n> > libcamera-devel mailing list\n> > libcamera-devel@lists.libcamera.org\n> > https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CEC01C3B5B\n\tfor ;\n\tMon, 14 Sep 2020 09:31:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 38E0462D99;\n\tMon, 14 Sep 2020 11:31:38 +0200 (CEST)","from mail-lj1-x243.google.com (mail-lj1-x243.google.com\n\t[IPv6:2a00:1450:4864:20::243])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C28986036B\n\tfor ;\n\tMon, 14 Sep 2020 11:31:36 +0200 (CEST)","by mail-lj1-x243.google.com with SMTP id s205so18014764lja.7\n\tfor ;\n\tMon, 14 Sep 2020 02:31:36 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\tj127sm3612879lfd.6.2020.09.14.02.31.35\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 14 Sep 2020 02:31:35 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"w//GNXhI\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=FC0xVWnsT7Y3zOYaV0Fp5yXbDq4mnQlW2krKssZyEgo=;\n\tb=w//GNXhIWZjl0mLX2a1n/BKlI0SiWUgeG2Bgf2wc8YX3YUMdAcXwQifwRMtfaN7n5G\n\t7zHvU5qNdDtFVUW3MgX+54iEPg68c1I+U9e2XoUZRpVjbNwlyCnkaaf4nhHwXz3ZqCWh\n\t53WvMwyT7sGDqHXRNJ+x6VUu0Ugts4YCom2GfvZKZwl/tnfNObKZYj8hx9FAsoluTrRQ\n\tdssrRxWVRrjLXDVv8X9xX9191DcEvOr5+WLJCj003LG6GPdQysJsCzSNsxUgjYuUwW5Q\n\tlBi8NTEauEIlNYVIPRFF0oVeTW4gCBSlnliql/HzHreQR7ok6YWNFKP3BVt69eKKVtK/\n\t0f4A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=FC0xVWnsT7Y3zOYaV0Fp5yXbDq4mnQlW2krKssZyEgo=;\n\tb=MdU3PDHQkvzOLQchVKCI7tXxqLuXkKv9j7qJDzNr8hmXP7aCpTa1AYq6MeuEhxtGVB\n\tQSmwuHLkKg3BU/gAvc1+3sTVx0GkQurFMEYJqbgQNa7gUHtjY1AkDoFsXyTXhz4ipBZH\n\t1LsMBBXEXttDRxHYmUasI9RmykWPAv/9xJaXnDFoCXL6yvFeiCIFCY2/97NMQ+wIQbxN\n\tsBmBCyZ+jkWD4ME0I4HNQqekn+ik7ksWlU81/SGNjcZ9quD84jwWhg7akAgwA1gUGJKA\n\tzc12EKp2kss/VJZfeEKgiyL2QX2ncJc2KWioI2hdYFXiadQ+03BuWKgjKSNTpk/qC4zH\n\tmrLw==","X-Gm-Message-State":"AOAM532M893EBHnMNkNwbbw2mx6laxxPxxoXFkZbDbb09KhGGeiqmdnD\n\tZIjRtnew4ceRLv2XEFUc1t1QlA==","X-Google-Smtp-Source":"ABdhPJxtF5tZzaQ53EdjJQ8xgJgEgRXAlQlbu0X0n8a2byvXTHuB7bp7RqOsKT1Nnvgh9ZdQo/Empw==","X-Received":"by 2002:a2e:9782:: with SMTP id y2mr4954893lji.91.1600075896078; \n\tMon, 14 Sep 2020 02:31:36 -0700 (PDT)","Date":"Mon, 14 Sep 2020 11:31:34 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Jacopo Mondi ","Message-ID":"<20200914093134.GD1127199@oden.dyn.berto.se>","References":"<20200813005246.3265807-1-niklas.soderlund@ragnatech.se>\n\t<20200813005246.3265807-6-niklas.soderlund@ragnatech.se>\n\t<20200820084227.267v5ux257t4rj4t@uno.localdomain>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200820084227.267v5ux257t4rj4t@uno.localdomain>","Subject":"Re: [libcamera-devel] [PATCH 05/13] libcamera: pipeline: rkisp1:\n\tCreate RkISP1Frames from camera data","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]