{"id":9273,"url":"https://patchwork.libcamera.org/api/patches/9273/?format=json","web_url":"https://patchwork.libcamera.org/patch/9273/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200810120406.52654-2-email@uajain.com>","date":"2020-08-10T12:04:11","name":"[libcamera-devel,v2,1/4] libcamera: pipeline: uvcvideo: Treat all UVC cameras as external","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"a6a8c3453b67df0478e7f08862dfa2de5f9607fe","submitter":{"id":1,"url":"https://patchwork.libcamera.org/api/people/1/?format=json","name":"Umang Jain","email":"email@uajain.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/9273/mbox/","series":[{"id":1210,"url":"https://patchwork.libcamera.org/api/series/1210/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1210","date":"2020-08-10T12:04:11","name":"android: Camera hotplug support","version":2,"mbox":"https://patchwork.libcamera.org/series/1210/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/9273/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/9273/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6460CBD87E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 10 Aug 2020 12:04:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 48CA560F72;\n\tMon, 10 Aug 2020 14:04:15 +0200 (CEST)","from o1.f.az.sendgrid.net (o1.f.az.sendgrid.net [208.117.55.132])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 69CE66038C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 10 Aug 2020 14:04:13 +0200 (CEST)","by filterdrecv-p3mdw1-7ff865655c-m68sw with SMTP id\n\tfilterdrecv-p3mdw1-7ff865655c-m68sw-20-5F3137BB-94\n\t2020-08-10 12:04:11.916873617 +0000 UTC m=+1014473.745401019","from mail.uajain.com (unknown)\n\tby ismtpd0005p1maa1.sendgrid.net (SG) with ESMTP id\n\t_BTqMKDXRNmn_uxe1HbCpA for <libcamera-devel@lists.libcamera.org>;\n\tMon, 10 Aug 2020 12:04:11.571 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=uajain.com header.i=@uajain.com\n\theader.b=\"TJMaHJ2d\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=uajain.com;\n\th=from:subject:in-reply-to:references:mime-version:to:cc:\n\tcontent-transfer-encoding:content-type;\n\ts=s1; bh=4S5AU31LwYsKdg3XtpmVn1HGzj2LiTc8pFtq4RaXXR4=;\n\tb=TJMaHJ2dA6e2b/CYn10bUdmDRjrfSOH7c/b9F2irvC+WbOUhZBbw5Q3G7gVsSOpAonlw\n\t39mS61ScHV7dgl+b11gA0mIJimF12Yqo2F618oVCJ/OBKZ4DeN4gbwWDgNyEIkc10iKjgY\n\t/0UEO/tV32/euVIrLaAfKzbQmxZCiPmBs=","From":"Umang Jain <email@uajain.com>","Date":"Mon, 10 Aug 2020 12:04:11 +0000 (UTC)","Message-Id":"<20200810120406.52654-2-email@uajain.com>","In-Reply-To":"<20200810120406.52654-1-email@uajain.com>","References":"<20200810120406.52654-1-email@uajain.com>","Mime-Version":"1.0","X-SG-EID":"1Q40EQ7YGir8a9gjSIAdTjhngY657NMk9ckeo4dbHZDiOpywc/L3L9rFqlwE4KPc9vLW9W8H4bP+KZ0PPVtunxkrf1/W/GGIxTt+w0T9coG+TvKWFla874XTCVC06G0uYrHkhIxtRas0H6PgWUg0T6cUukIag/BVGRRbUiJV9R89aK7U+SUJLSeul57LTwW/3FGpcMdnGUcTz930fJIqKz7lopIJdr/eZ0jw4hB5gKlZToXN6WVvM3l5JloVGt5rWNVS6bMc0byH4KY+GO1FlQ==","To":"libcamera-devel@lists.libcamera.org","Subject":"[libcamera-devel] [PATCH v2 1/4] libcamera: pipeline: uvcvideo:\n\tTreat all UVC cameras as external","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"Treat all UVC cameras as external for android framework to know that\nthey are external.\n\nSigned-off-by: Umang Jain <email@uajain.com>\n---\n src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 4 ++++\n 1 file changed, 4 insertions(+)","diff":"diff --git a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\nindex bc892ec..ed61d12 100644\n--- a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n+++ b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n@@ -14,6 +14,7 @@\n #include <libcamera/camera.h>\n #include <libcamera/control_ids.h>\n #include <libcamera/controls.h>\n+#include <libcamera/property_ids.h>\n #include <libcamera/request.h>\n #include <libcamera/stream.h>\n \n@@ -500,6 +501,9 @@ int UVCCameraData::init(MediaEntity *entity)\n \n \tvideo_->bufferReady.connect(this, &UVCCameraData::bufferReady);\n \n+\t/* Initialise Camera Property. Treat all UVC cameras as external. */\n+\tproperties_.set(properties::Location, properties::CameraLocationExternal);\n+\n \t/* Initialise the supported controls. */\n \tControlInfoMap::Map ctrls;\n \n","prefixes":["libcamera-devel","v2","1/4"]}