[{"id":11944,"web_url":"https://patchwork.libcamera.org/comment/11944/","msgid":"<20200808103242.GF3387836@oden.dyn.berto.se>","date":"2020-08-08T10:32:42","subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: controls: Define\n\tAwbLocked control","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nThanks for your work.\n\nOn 2020-08-08 12:00:45 +0200, Jacopo Mondi wrote:\n> Define a control to report the AWB algorithm locking state.\n> The control definition is copied from the AeLocked one.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/control_ids.yaml | 11 +++++++++++\n> 1 file changed, 11 insertions(+)\n> \n> diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\n> index 3560d4a81882..4c415545dcae 100644\n> --- a/src/libcamera/control_ids.yaml\n> +++ b/src/libcamera/control_ids.yaml\n> @@ -208,6 +208,17 @@ controls:\n> value: 7\n> description: Maximum allowed value (place any new values above here).\n> \n> + - AwbLocked:\n> + type: bool\n> + description: |\n> + Report the lock status of a running AWB algorithm.\n> +\n> + If the AWB algorithm is locked the value shall be set to true, if it's\n> + converging it shall be set to false. If the AWB algorithm is not\n> + running the control shall not be present in the metadata control list.\n> +\n> + \\sa AwbEnable\n> +\n> - ColourGains:\n> type: float\n> description: |\n> -- \n> 2.27.0\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2025CBD87C\n\tfor ;\n\tSat, 8 Aug 2020 10:32:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DEDE360DDE;\n\tSat, 8 Aug 2020 12:32:45 +0200 (CEST)","from mail-lj1-x244.google.com (mail-lj1-x244.google.com\n\t[IPv6:2a00:1450:4864:20::244])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A92506038E\n\tfor ;\n\tSat, 8 Aug 2020 12:32:43 +0200 (CEST)","by mail-lj1-x244.google.com with SMTP id w25so4715179ljo.12\n\tfor ;\n\tSat, 08 Aug 2020 03:32:43 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\tu10sm4946538lju.113.2020.08.08.03.32.42\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSat, 08 Aug 2020 03:32:42 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"laYPC7Cr\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=ySjCmnvB8w4c7yUzoAcg2QtJs2APDHiO9AlgAqmGNSQ=;\n\tb=laYPC7CrvBg3F055Gah6HOp7zCkeApILhD4LskD9B1z3r+QqWiw+gDX3alF16jOqSe\n\tXaN7YcYCsJZjo2Vrj+BtwUUT48o0hxQ8oh8SAHaifeRJGNhQ1fdh5qb4LJhMxyDQk7Yh\n\t8OjgGTZdhXC2RSZv/HiynDHlrM9UqRR/jlxlIrXvi+cQvqP9P9uNSEZC80Yn2CcHLID5\n\tqTBM+TTcPHJR78IMnPk/rhLUi4Xo7v0JTNqNeNRefIuQZd0Ipkq0xLI/Ti6cpmguBhCG\n\tsPgpLLs4abMwqWmpWarqMPajHr9oj8hb8kCfMAhfGNiqegjiV6AopVn1Q7Vo2gr4Xx3O\n\tTk1A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=ySjCmnvB8w4c7yUzoAcg2QtJs2APDHiO9AlgAqmGNSQ=;\n\tb=hg8OYmZMlHlXV2tEAIw0EYacts4YXAZt2S6uAWi3jCGijVd02Toov6exMq5UHxuHap\n\tt9hb6osFkgKrVav7xOFn8HOWtTqZLzVWDRPi2hbUWBh/xc2BfLiOELYawquOt48cf3jE\n\t5+l87VRshLqnSpu3pFXzwKC7KZY3ufMjSbRcsD9PhrS5aSpjW0JzBidSv6AFiVposFS9\n\t/QpYcZCbIXN/LDaDjgJVcPRvuddgR/8FTkH6Plh1QujPJNvqia40uljM02iW/XnDTvkO\n\tFUFqYqTIZA03/6B+d+febEY4L4O3qxoTUFtlBkryglsG8dTNXdTnWiyi8xApNqI/RQaG\n\tuqLA==","X-Gm-Message-State":"AOAM532cD7ZeU4CIZqdkdQ2QZfxHHhsa70p3/V3DmNIV9vdY0VUV7imL\n\t2W33dAFe49EyzC4jztgyJ0u3Hyhw6T4=","X-Google-Smtp-Source":"ABdhPJyKKh+9XCvezlz578viQ8xG7rzPLkrCu6MTx5Ecd2QPrQ5JNWR9fDw5nMpKmjZWEXVlSYbBEw==","X-Received":"by 2002:a2e:81cc:: with SMTP id\n\ts12mr7881171ljg.232.1596882763140; \n\tSat, 08 Aug 2020 03:32:43 -0700 (PDT)","Date":"Sat, 8 Aug 2020 12:32:42 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Jacopo Mondi ","Message-ID":"<20200808103242.GF3387836@oden.dyn.berto.se>","References":"<20200808100046.5347-1-jacopo@jmondi.org>\n\t<20200808100046.5347-2-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200808100046.5347-2-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: controls: Define\n\tAwbLocked control","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]