[{"id":11942,"web_url":"https://patchwork.libcamera.org/comment/11942/","msgid":"<20200808070214.GA5917@pendragon.ideasonboard.com>","date":"2020-08-08T07:02:14","subject":"Re: [libcamera-devel] [PATCH 5/7] cam: Rename cameraName variable","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patch.\n\nOn Thu, Aug 06, 2020 at 03:09:35PM +0200, Niklas Söderlund wrote:\n> When converting Camera::name() to Camera::id() one variable in cam was\n> left unnoticed, rename it to cameraId.\n> \n> Signed-off-by: Niklas Söderlund \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/cam/main.cpp | 6 +++---\n> 1 file changed, 3 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/cam/main.cpp b/src/cam/main.cpp\n> index fb7bcbd9c67ec672..cc3facd5a5b22092 100644\n> --- a/src/cam/main.cpp\n> +++ b/src/cam/main.cpp\n> @@ -95,13 +95,13 @@ int CamApp::init(int argc, char **argv)\n> \t}\n> \n> \tif (options_.isSet(OptCamera)) {\n> -\t\tconst std::string &cameraName = options_[OptCamera];\n> +\t\tconst std::string &cameraId = options_[OptCamera];\n> \t\tchar *endptr;\n> -\t\tunsigned long index = strtoul(cameraName.c_str(), &endptr, 10);\n> +\t\tunsigned long index = strtoul(cameraId.c_str(), &endptr, 10);\n> \t\tif (*endptr == '\\0' && index > 0 && index <= cm_->cameras().size())\n> \t\t\tcamera_ = cm_->cameras()[index - 1];\n> \t\telse\n> -\t\t\tcamera_ = cm_->get(cameraName);\n> +\t\t\tcamera_ = cm_->get(cameraId);\n> \n> \t\tif (!camera_) {\n> \t\t\tstd::cout << \"Camera \"","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 87EA7BD87C\n\tfor ;\n\tSat, 8 Aug 2020 07:02:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EBEBF60E4D;\n\tSat, 8 Aug 2020 09:02:28 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D5DDB6038D\n\tfor ;\n\tSat, 8 Aug 2020 09:02:27 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 43706F9;\n\tSat, 8 Aug 2020 09:02:27 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"d28acp6l\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1596870147;\n\tbh=StKZvH2jclqX55W8yUTQeaLOAEVHKP2XC+k/Sf1kIYI=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=d28acp6lkPNQlegODSPeuxDd0pr6HDdxpIBfsPNbcJqFKL9j/vh0rgGQW4yBktUo8\n\tbOLGPC+UjL7cLat214fc1zfkYl8kQGeBYh+7fKvIRS3CwmCCgzylcyQ7UmRWfP4u5D\n\tMuT88uEGP4V+xcgbsE+IzNzq1FQLy3XLwTfPoaf0=","Date":"Sat, 8 Aug 2020 10:02:14 +0300","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Message-ID":"<20200808070214.GA5917@pendragon.ideasonboard.com>","References":"<20200806130937.2991606-1-niklas.soderlund@ragnatech.se>\n\t<20200806130937.2991606-6-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200806130937.2991606-6-niklas.soderlund@ragnatech.se>","Subject":"Re: [libcamera-devel] [PATCH 5/7] cam: Rename cameraName variable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]