[{"id":11949,"web_url":"https://patchwork.libcamera.org/comment/11949/","msgid":"<20200808202025.GC6186@pendragon.ideasonboard.com>","date":"2020-08-08T20:20:25","subject":"Re: [libcamera-devel] [PATCH 2/7] libcamera: camera_sensor: Set\n\tsensor model property","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patch.\n\nOn Thu, Aug 06, 2020 at 03:09:32PM +0200, Niklas Söderlund wrote:\n> Set the sensor model property.\n\nPatch 1/7 documents a camera model property, while this is a sensor\nmodel. All this needs to be clarified. Same for patch 4/7.\n\n> Signed-off-by: Niklas Söderlund \n> ---\n> src/libcamera/camera_sensor.cpp | 2 ++\n> 1 file changed, 2 insertions(+)\n> \n> diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\n> index d2679a4b80ce0d42..731ccf29de0ad442 100644\n> --- a/src/libcamera/camera_sensor.cpp\n> +++ b/src/libcamera/camera_sensor.cpp\n> @@ -200,6 +200,8 @@ int CameraSensor::init()\n> \telse\n> \t\tmodel_ = entityName;\n> \n> +\tproperties_.set(properties::Model, model_);\n> +\n> \t/* Create and open the subdev. */\n> \tsubdev_ = std::make_unique(entity_);\n> \tint ret = subdev_->open();","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D46C3BD87C\n\tfor ;\n\tSat, 8 Aug 2020 20:20:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9EF5C6038E;\n\tSat, 8 Aug 2020 22:20:45 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6A6676038D\n\tfor ;\n\tSat, 8 Aug 2020 22:20:43 +0200 (CEST)","from pendragon.ideasonboard.com (85-76-78-184-nat.elisa-mobile.fi\n\t[85.76.78.184])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DB294F9;\n\tSat, 8 Aug 2020 22:20:42 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"EnkpDu3u\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1596918043;\n\tbh=11kpbSQPwO+Rh3VgamznWuDnsOQ8PV+F18MD/23O9cs=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=EnkpDu3up32U2CxpGpKMlXn2qFvjrk8CU+Vgb+QVpSniCvGjYzYpaExI3G2j6qK70\n\tRG2wHFQK61w6gC9BmSYAfh3W+z3+s6SIegeBFyrKoayJBShEEmbTcYGpvpNmNN76K/\n\tW7jpZ4oSo5ZBXRFz24SpTHDDs7tKqfxqZVOuzwc4=","Date":"Sat, 8 Aug 2020 23:20:25 +0300","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Message-ID":"<20200808202025.GC6186@pendragon.ideasonboard.com>","References":"<20200806130937.2991606-1-niklas.soderlund@ragnatech.se>\n\t<20200806130937.2991606-3-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200806130937.2991606-3-niklas.soderlund@ragnatech.se>","Subject":"Re: [libcamera-devel] [PATCH 2/7] libcamera: camera_sensor: Set\n\tsensor model property","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":11953,"web_url":"https://patchwork.libcamera.org/comment/11953/","msgid":"<20200808210216.GH3387836@oden.dyn.berto.se>","date":"2020-08-08T21:02:16","subject":"Re: [libcamera-devel] [PATCH 2/7] libcamera: camera_sensor: Set\n\tsensor model property","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your feedback.\n\nOn 2020-08-08 23:20:25 +0300, Laurent Pinchart wrote:\n> Hi Niklas,\n> \n> Thank you for the patch.\n> \n> On Thu, Aug 06, 2020 at 03:09:32PM +0200, Niklas Söderlund wrote:\n> > Set the sensor model property.\n> \n> Patch 1/7 documents a camera model property, while this is a sensor\n> model. All this needs to be clarified. Same for patch 4/7.\n\nWe already do this with Location and Rotation, what makes Model \ndifferent?\n\n> \n> > Signed-off-by: Niklas Söderlund \n> > ---\n> > src/libcamera/camera_sensor.cpp | 2 ++\n> > 1 file changed, 2 insertions(+)\n> > \n> > diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\n> > index d2679a4b80ce0d42..731ccf29de0ad442 100644\n> > --- a/src/libcamera/camera_sensor.cpp\n> > +++ b/src/libcamera/camera_sensor.cpp\n> > @@ -200,6 +200,8 @@ int CameraSensor::init()\n> > \telse\n> > \t\tmodel_ = entityName;\n> > \n> > +\tproperties_.set(properties::Model, model_);\n> > +\n> > \t/* Create and open the subdev. */\n> > \tsubdev_ = std::make_unique(entity_);\n> > \tint ret = subdev_->open();\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BDDA2BD87D\n\tfor ;\n\tSat, 8 Aug 2020 21:02:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4D7A66038D;\n\tSat, 8 Aug 2020 23:02:19 +0200 (CEST)","from mail-lj1-x244.google.com (mail-lj1-x244.google.com\n\t[IPv6:2a00:1450:4864:20::244])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5CF396038D\n\tfor ;\n\tSat, 8 Aug 2020 23:02:18 +0200 (CEST)","by mail-lj1-x244.google.com with SMTP id w25so5692402ljo.12\n\tfor ;\n\tSat, 08 Aug 2020 14:02:18 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\ti19sm6392848lfi.14.2020.08.08.14.02.16\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSat, 08 Aug 2020 14:02:16 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"oxKJDnEZ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=99LzbQwDAMfBzl9ugCN22CNW6hHGLdqcPQL8OUUmeaE=;\n\tb=oxKJDnEZ/cdew3yxhrihshCLFR8g/NFl4PCmrPCKQIxreW46lMj4HfBXcaQXg/fc0p\n\tqiZ77oF2WANaJHgle30OQLd6KMv8kxu+LdudHL1m1Nyl6VOnk5fvYaWHWw26DPp5nPF6\n\t9ryRUeznHTFYLUoq7cao4Jos35UrSOu0VrriwEAFE2BvcGsbEfFmpm1AAOFsY4zalJbF\n\tgDYSlGP7lbuv0JOIgCUcT5lZv1X7j3s42q/4BSInxP5otxp9nnY/L2Nkk14F+TdYc94b\n\ttJeBvjT0F19AoDNy+w+cSP+80cQmOsiONzO2TPO08lKA/Y29AMhE2YzHGpicmlL1aBkS\n\thuPg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=99LzbQwDAMfBzl9ugCN22CNW6hHGLdqcPQL8OUUmeaE=;\n\tb=sLwhAPj5HmXL6VwzdbyG1v/PHrFFn3TTE5dTu7uli9TN731/4HmNJVeQYBsRuOVaIL\n\t38Elf61FHouvaOnAJjyF490Awyj0WQZMMkOP+a6SuIyY3v/5FBUNysew2G/9F83gsKFD\n\thfq6t9xD8981YMbEJp2REMLTodvAEBySjgrh1hfkAH0zZibn4kHVFvNxjkbknDoAUcEp\n\tRYnkUkdzw4aaCP15u2psJVHprc4Bk7Ngsr7S1WphUw5YUpMiLDusYIJ0GF2rlZJhr67x\n\try/ZFIaFRKLhbBIvK90EXGH6lvU6sLQFjc+NCtdXsyQQrSbOzbe2SAtaFZddrCdGYmVs\n\tEUyg==","X-Gm-Message-State":"AOAM533XFXjoEFekE3IUaAKQBlyg3STkLoLG1Xs8nU0nO8VFxgLoRMgl\n\t3L6Fgj/XmlJjAq/C4FtwSJXZQg==","X-Google-Smtp-Source":"ABdhPJwDRaS1hpNqSmcDTQpeYui0BkpPXrPF0wVs96LRz8ULjWwrsTMa7MgEZ/Sxi9Ir954X0H2niw==","X-Received":"by 2002:a2e:850b:: with SMTP id\n\tj11mr8376275lji.254.1596920537410; \n\tSat, 08 Aug 2020 14:02:17 -0700 (PDT)","Date":"Sat, 8 Aug 2020 23:02:16 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Message-ID":"<20200808210216.GH3387836@oden.dyn.berto.se>","References":"<20200806130937.2991606-1-niklas.soderlund@ragnatech.se>\n\t<20200806130937.2991606-3-niklas.soderlund@ragnatech.se>\n\t<20200808202025.GC6186@pendragon.ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200808202025.GC6186@pendragon.ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 2/7] libcamera: camera_sensor: Set\n\tsensor model property","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":11954,"web_url":"https://patchwork.libcamera.org/comment/11954/","msgid":"<20200808212622.GU6186@pendragon.ideasonboard.com>","date":"2020-08-08T21:26:22","subject":"Re: [libcamera-devel] [PATCH 2/7] libcamera: camera_sensor: Set\n\tsensor model property","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nOn Sat, Aug 08, 2020 at 11:02:16PM +0200, Niklas Söderlund wrote:\n> On 2020-08-08 23:20:25 +0300, Laurent Pinchart wrote:\n> > On Thu, Aug 06, 2020 at 03:09:32PM +0200, Niklas Söderlund wrote:\n> > > Set the sensor model property.\n> > \n> > Patch 1/7 documents a camera model property, while this is a sensor\n> > model. All this needs to be clarified. Same for patch 4/7.\n> \n> We already do this with Location and Rotation, what makes Model \n> different?\n\nThe fact that they have more extensive documentation :-) The only\ndocumentation of the Model property is \"Camera model name\". That's\npretty terse to know if this patch is right or not.\n\n> > > Signed-off-by: Niklas Söderlund \n> > > ---\n> > > src/libcamera/camera_sensor.cpp | 2 ++\n> > > 1 file changed, 2 insertions(+)\n> > > \n> > > diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\n> > > index d2679a4b80ce0d42..731ccf29de0ad442 100644\n> > > --- a/src/libcamera/camera_sensor.cpp\n> > > +++ b/src/libcamera/camera_sensor.cpp\n> > > @@ -200,6 +200,8 @@ int CameraSensor::init()\n> > > \telse\n> > > \t\tmodel_ = entityName;\n> > > \n> > > +\tproperties_.set(properties::Model, model_);\n> > > +\n> > > \t/* Create and open the subdev. */\n> > > \tsubdev_ = std::make_unique(entity_);\n> > > \tint ret = subdev_->open();","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EAF1FBD87C\n\tfor ;\n\tSat, 8 Aug 2020 21:26:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 703066038E;\n\tSat, 8 Aug 2020 23:26:39 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DB17D6038D\n\tfor ;\n\tSat, 8 Aug 2020 23:26:37 +0200 (CEST)","from pendragon.ideasonboard.com (85-76-78-184-nat.elisa-mobile.fi\n\t[85.76.78.184])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 366E7F9;\n\tSat, 8 Aug 2020 23:26:37 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"CjqcJzbP\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1596921997;\n\tbh=W6MASR/4px/xEivLh0bG4F+yOUJdl5W1nrzs8PfOQB4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=CjqcJzbPwwG980C+8BPHgZ4ifQOYno1qWoP2U3IqhOReLcfRCGaz1QXzpSLUg8ZI2\n\tdZuoDEa0yL8LbtJaMklLXYxPL0v3Y35LH3jXtIxcB8mzAH4LXzMkrglizQA6aQMLEm\n\tKTItrHHNMIp2KyKjZzGbcWt+30zgEP7qGJyqzj5c=","Date":"Sun, 9 Aug 2020 00:26:22 +0300","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Message-ID":"<20200808212622.GU6186@pendragon.ideasonboard.com>","References":"<20200806130937.2991606-1-niklas.soderlund@ragnatech.se>\n\t<20200806130937.2991606-3-niklas.soderlund@ragnatech.se>\n\t<20200808202025.GC6186@pendragon.ideasonboard.com>\n\t<20200808210216.GH3387836@oden.dyn.berto.se>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200808210216.GH3387836@oden.dyn.berto.se>","Subject":"Re: [libcamera-devel] [PATCH 2/7] libcamera: camera_sensor: Set\n\tsensor model property","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]