[{"id":11948,"web_url":"https://patchwork.libcamera.org/comment/11948/","msgid":"<20200808201909.GB6186@pendragon.ideasonboard.com>","date":"2020-08-08T20:19:09","subject":"Re: [libcamera-devel] [PATCH 1/7] libcamera: properties: Add model\n\tproperty","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patch.\n\nOn Thu, Aug 06, 2020 at 03:09:31PM +0200, Niklas Söderlund wrote:\n> The model property describes the camera model string.\n> \n> Signed-off-by: Niklas Söderlund \n> ---\n> src/libcamera/property_ids.yaml | 5 +++++\n> 1 file changed, 5 insertions(+)\n> \n> diff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml\n> index 74ad0195d6310367..5c597bfc6e2d4089 100644\n> --- a/src/libcamera/property_ids.yaml\n> +++ b/src/libcamera/property_ids.yaml\n> @@ -387,6 +387,11 @@ controls:\n> | |\n> +--------------------+\n> \n> + - Model:\n> + type: string\n> + description: |\n> + Camera model name\n\nThis needs more documentation, possibly with examples. It also needs to\ndefine how the string should be encoded (likely UTF-8, but for some\nproperties we may want to restrict it to ASCII). The encoding should\nprobably be defined somewhere globally.\n\n> +\n> - UnitCellSize:\n> type: Size\n> description: |","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B17F5BD87C\n\tfor ;\n\tSat, 8 Aug 2020 20:19:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2F0CE60DF1;\n\tSat, 8 Aug 2020 22:19:27 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E2C366038D\n\tfor ;\n\tSat, 8 Aug 2020 22:19:25 +0200 (CEST)","from pendragon.ideasonboard.com (85-76-78-184-nat.elisa-mobile.fi\n\t[85.76.78.184])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C3525F9;\n\tSat, 8 Aug 2020 22:19:24 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Ggub1r4T\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1596917965;\n\tbh=YvQ+O1YIt8QLw7S9yJCa+lRt2I7XelFtfcuGps9yCdw=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Ggub1r4TrUnvDR4A997i1VJlGf+2W29egaJEfzodhgTs6f9uVRhsDCwY0ANlx15oj\n\tXGvU3KtGEhn1dophpXXYuK2GPLb6O95HDTHCozCS/YDbrbrxKZu0XOxkL01D6lCZuL\n\tzA1dxEgjYG+BOzRK5rugE2rIGHZ+xzBQoIvrJgEY=","Date":"Sat, 8 Aug 2020 23:19:09 +0300","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Message-ID":"<20200808201909.GB6186@pendragon.ideasonboard.com>","References":"<20200806130937.2991606-1-niklas.soderlund@ragnatech.se>\n\t<20200806130937.2991606-2-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200806130937.2991606-2-niklas.soderlund@ragnatech.se>","Subject":"Re: [libcamera-devel] [PATCH 1/7] libcamera: properties: Add model\n\tproperty","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]