[{"id":12010,"web_url":"https://patchwork.libcamera.org/comment/12010/","msgid":"","date":"2020-08-14T09:32:27","subject":"Re: [libcamera-devel] [PATCH 1/3] libcamera: pipeline_handler: Make\n\tcameraData() a const operation","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Niklas,\n\nOhh another series making things that should be const ... const ... ;-)\nThis makes me happy too.\n\nOn 06/08/2020 13:53, Niklas Söderlund wrote:\n> There is nothing blocking cameraData() from being a constant operation.\n> The assert already enforces that a std::map::at() operation would always\n> succeed. Switch to using at() and mark the method as a const operation.\n> \n> Signed-off-by: Niklas Söderlund \n\nSounds good to me!\n\nReviewed-by: Kieran Bingham \n\n> ---\n> include/libcamera/internal/pipeline_handler.h | 2 +-\n> src/libcamera/pipeline_handler.cpp | 4 ++--\n> 2 files changed, 3 insertions(+), 3 deletions(-)\n> \n> diff --git a/include/libcamera/internal/pipeline_handler.h b/include/libcamera/internal/pipeline_handler.h\n> index 22e629a8401d1e4e..d5321ef56df358d0 100644\n> --- a/include/libcamera/internal/pipeline_handler.h\n> +++ b/include/libcamera/internal/pipeline_handler.h\n> @@ -96,7 +96,7 @@ protected:\n> \n> \tvirtual int queueRequestDevice(Camera *camera, Request *request) = 0;\n> \n> -\tCameraData *cameraData(const Camera *camera);\n> +\tCameraData *cameraData(const Camera *camera) const;\n> \n> \tCameraManager *manager_;\n> \n> diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\n> index ccd45edc847b9e3f..bc9c1d4b09c5437d 100644\n> --- a/src/libcamera/pipeline_handler.cpp\n> +++ b/src/libcamera/pipeline_handler.cpp\n> @@ -595,10 +595,10 @@ void PipelineHandler::disconnect()\n> * valid until the pipeline handler is destroyed. It shall not be deleted\n> * manually by the caller.\n> */\n> -CameraData *PipelineHandler::cameraData(const Camera *camera)\n> +CameraData *PipelineHandler::cameraData(const Camera *camera) const\n> {\n> \tASSERT(cameraData_.count(camera));\n> -\treturn cameraData_[camera].get();\n> +\treturn cameraData_.at(camera).get();\n> }\n> \n> /**\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1E2F1BD87D\n\tfor ;\n\tFri, 14 Aug 2020 09:32:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 92D69615F4;\n\tFri, 14 Aug 2020 11:32:31 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2DE7E60386\n\tfor ;\n\tFri, 14 Aug 2020 11:32:30 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8AAE9331;\n\tFri, 14 Aug 2020 11:32:29 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"GDc0aWKi\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1597397549;\n\tbh=jpxnFqkDVDzSUiZDWGXIWI9bQlwTGAfN8vuMaYcUAkY=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=GDc0aWKiCj2oFmGM1oMCpZhAe/3vHzeuI24Baoy7nU+n2vAyQxiPwsRYL1nBf/UGl\n\tPRZ8wxo63Myhs5fE32YS2GOemWRFeZWXJLfdxQQfubylmYcCKiicgVOq/4LNEpeDIr\n\tdZjHQt00sdnb92hDoca6lTRHUs6A6cthDUswh7O0=","To":"=?utf-8?q?Niklas_S=C3=B6derlund?= ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20200806125330.2983325-1-niklas.soderlund@ragnatech.se>\n\t<20200806125330.2983325-2-niklas.soderlund@ragnatech.se>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"","Date":"Fri, 14 Aug 2020 10:32:27 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20200806125330.2983325-2-niklas.soderlund@ragnatech.se>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 1/3] libcamera: pipeline_handler: Make\n\tcameraData() a const operation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":12014,"web_url":"https://patchwork.libcamera.org/comment/12014/","msgid":"<20200814093532.GA15283@pendragon.ideasonboard.com>","date":"2020-08-14T09:35:32","subject":"Re: [libcamera-devel] [PATCH 1/3] libcamera: pipeline_handler: Make\n\tcameraData() a const operation","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patch.\n\nOn Thu, Aug 06, 2020 at 02:53:28PM +0200, Niklas Söderlund wrote:\n> There is nothing blocking cameraData() from being a constant operation.\n> The assert already enforces that a std::map::at() operation would always\n> succeed. Switch to using at() and mark the method as a const operation.\n> \n> Signed-off-by: Niklas Söderlund \n> ---\n> include/libcamera/internal/pipeline_handler.h | 2 +-\n> src/libcamera/pipeline_handler.cpp | 4 ++--\n> 2 files changed, 3 insertions(+), 3 deletions(-)\n> \n> diff --git a/include/libcamera/internal/pipeline_handler.h b/include/libcamera/internal/pipeline_handler.h\n> index 22e629a8401d1e4e..d5321ef56df358d0 100644\n> --- a/include/libcamera/internal/pipeline_handler.h\n> +++ b/include/libcamera/internal/pipeline_handler.h\n> @@ -96,7 +96,7 @@ protected:\n> \n> \tvirtual int queueRequestDevice(Camera *camera, Request *request) = 0;\n> \n> -\tCameraData *cameraData(const Camera *camera);\n> +\tCameraData *cameraData(const Camera *camera) const;\n\nCameraData holds part of the pipeline state. As such, returning a\nnon-const pointer from a const function, while not breaking compilation,\nconceptually breaks const-correctness.\n\nWould it be enough for your use case to have both\n\n\tCameraData *cameraData(const Camera *camera);\n\tconst CameraData *cameraData(const Camera *camera) const;\n\n?\n\n> \n> \tCameraManager *manager_;\n> \n> diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\n> index ccd45edc847b9e3f..bc9c1d4b09c5437d 100644\n> --- a/src/libcamera/pipeline_handler.cpp\n> +++ b/src/libcamera/pipeline_handler.cpp\n> @@ -595,10 +595,10 @@ void PipelineHandler::disconnect()\n> * valid until the pipeline handler is destroyed. It shall not be deleted\n> * manually by the caller.\n> */\n> -CameraData *PipelineHandler::cameraData(const Camera *camera)\n> +CameraData *PipelineHandler::cameraData(const Camera *camera) const\n> {\n> \tASSERT(cameraData_.count(camera));\n> -\treturn cameraData_[camera].get();\n> +\treturn cameraData_.at(camera).get();\n> }\n> \n> /**","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AAC62BD87C\n\tfor ;\n\tFri, 14 Aug 2020 09:35:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 732C760386;\n\tFri, 14 Aug 2020 11:35:49 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8786E60386\n\tfor ;\n\tFri, 14 Aug 2020 11:35:47 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 24BA7331;\n\tFri, 14 Aug 2020 11:35:47 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"jlUXT2Y2\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1597397747;\n\tbh=tgb84gviZ4alk4yt64MRQeVHUVUEy+8L2SR0dRa4/1A=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=jlUXT2Y2Mlk55MJkzFnzqbkwh3p8JHx/8Jb/Nao+u4N2qjHJwYTEPAJy7hp2EBI4y\n\tzU8jyNedFPRXdSbZAF+Sx2XeRBTXgV3CCzKRV9cznAN/aeVdk/J4dKW49F6vfInthu\n\tyTfgbyF6NpWpY/ddpcUE8I7BQUqqDB1EfpgToP1M=","Date":"Fri, 14 Aug 2020 12:35:32 +0300","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Message-ID":"<20200814093532.GA15283@pendragon.ideasonboard.com>","References":"<20200806125330.2983325-1-niklas.soderlund@ragnatech.se>\n\t<20200806125330.2983325-2-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200806125330.2983325-2-niklas.soderlund@ragnatech.se>","Subject":"Re: [libcamera-devel] [PATCH 1/3] libcamera: pipeline_handler: Make\n\tcameraData() a const operation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":12015,"web_url":"https://patchwork.libcamera.org/comment/12015/","msgid":"<20200814101855.GB1995759@oden.dyn.berto.se>","date":"2020-08-14T10:18:55","subject":"Re: [libcamera-devel] [PATCH 1/3] libcamera: pipeline_handler: Make\n\tcameraData() a const operation","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your feedback.\n\nOn 2020-08-14 12:35:32 +0300, Laurent Pinchart wrote:\n> Hi Niklas,\n> \n> Thank you for the patch.\n> \n> On Thu, Aug 06, 2020 at 02:53:28PM +0200, Niklas Söderlund wrote:\n> > There is nothing blocking cameraData() from being a constant operation.\n> > The assert already enforces that a std::map::at() operation would always\n> > succeed. Switch to using at() and mark the method as a const operation.\n> > \n> > Signed-off-by: Niklas Söderlund \n> > ---\n> > include/libcamera/internal/pipeline_handler.h | 2 +-\n> > src/libcamera/pipeline_handler.cpp | 4 ++--\n> > 2 files changed, 3 insertions(+), 3 deletions(-)\n> > \n> > diff --git a/include/libcamera/internal/pipeline_handler.h b/include/libcamera/internal/pipeline_handler.h\n> > index 22e629a8401d1e4e..d5321ef56df358d0 100644\n> > --- a/include/libcamera/internal/pipeline_handler.h\n> > +++ b/include/libcamera/internal/pipeline_handler.h\n> > @@ -96,7 +96,7 @@ protected:\n> > \n> > \tvirtual int queueRequestDevice(Camera *camera, Request *request) = 0;\n> > \n> > -\tCameraData *cameraData(const Camera *camera);\n> > +\tCameraData *cameraData(const Camera *camera) const;\n> \n> CameraData holds part of the pipeline state. As such, returning a\n> non-const pointer from a const function, while not breaking compilation,\n> conceptually breaks const-correctness.\n> \n> Would it be enough for your use case to have both\n> \n> \tCameraData *cameraData(const Camera *camera);\n> \tconst CameraData *cameraData(const Camera *camera) const;\n> \n> ?\n\nThanks for spotting this, not sure how this brain fart happened. Your \nproposed change solves my issue in a nicer and foremost correct way, \nwill send a v2.\n\n> \n> > \n> > \tCameraManager *manager_;\n> > \n> > diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\n> > index ccd45edc847b9e3f..bc9c1d4b09c5437d 100644\n> > --- a/src/libcamera/pipeline_handler.cpp\n> > +++ b/src/libcamera/pipeline_handler.cpp\n> > @@ -595,10 +595,10 @@ void PipelineHandler::disconnect()\n> > * valid until the pipeline handler is destroyed. It shall not be deleted\n> > * manually by the caller.\n> > */\n> > -CameraData *PipelineHandler::cameraData(const Camera *camera)\n> > +CameraData *PipelineHandler::cameraData(const Camera *camera) const\n> > {\n> > \tASSERT(cameraData_.count(camera));\n> > -\treturn cameraData_[camera].get();\n> > +\treturn cameraData_.at(camera).get();\n> > }\n> > \n> > /**\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 95594BD87D\n\tfor ;\n\tFri, 14 Aug 2020 10:18:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1A4C4613D6;\n\tFri, 14 Aug 2020 12:18:59 +0200 (CEST)","from mail-lj1-x244.google.com (mail-lj1-x244.google.com\n\t[IPv6:2a00:1450:4864:20::244])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5478E60918\n\tfor ;\n\tFri, 14 Aug 2020 12:18:58 +0200 (CEST)","by mail-lj1-x244.google.com with SMTP id t23so9388034ljc.3\n\tfor ;\n\tFri, 14 Aug 2020 03:18:58 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\ta16sm1714901ljj.108.2020.08.14.03.18.56\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 14 Aug 2020 03:18:56 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"NFZEoKk0\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=stwlQ/30TRwqIHl0cTdhbwff6DlcsHjIIiwySjanb+k=;\n\tb=NFZEoKk0sxvXhND6fIAFEUMS95AatiXv8ONC9f4fisUMUydMWN154FzlxMfqHO6dRg\n\tHJp479FMFqas9KTKevMXfGmkk0ED8J3hbFWYGgdiaCYVTWniJXOamJKsuctzoIM3VgPH\n\tHA3D+o6McssTymYU2+HUyWsxeKMuhXnuIhALYCa8n2Fn7gyrullWOi2qh0+/C7mDl4X9\n\t02Hivb3aTJ7GRrpa/gMv1J6HSqBc//ffS/AAB9nSn6FqWBuOmGHcwigOoYni1skcHnpU\n\td5OYBboiA4D0A7QOBklx+GnJySySdXMj97XKCn5roEuMuyv1x1vHyjgL/1J2MVLkg9GJ\n\tPXig==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=stwlQ/30TRwqIHl0cTdhbwff6DlcsHjIIiwySjanb+k=;\n\tb=Dg6zXjU6Be2+5He0MgK1QTopfBvMgwdc1WB0Xq0GFRVpuKS/HBOlb/SW2zTQaiJmKi\n\tdqQc9vz+CzXuxGFqYV7Z3oIaMTZyX0QbTm5uzwnErhunmcaaq/vszp3JkYNaxpoNloYZ\n\tzSSnKH83fND+nOrNqYtBF4DdAx1kmD4wf+uoLYPv731i4wWMgdkr6f3/rjhdnmd+bq2y\n\tqegRL9AEN+qXzI0foCWeu0YKz0teyY7NETV+uY0bBXHkFL3VB+DRvK2kfxPbEQEfyeh7\n\tjcYudDL28eVxvbTa2EfsXmrnb3mgI8YdsQY7mzeTPjroxjbFmJmDNz17DYA6lAVD4Fg+\n\tqfZQ==","X-Gm-Message-State":"AOAM532Dzuf+6581J92Y2V7X5HqKERN5z7L9djM2hiGNxidyfGzX9H3A\n\tA6kmlde5f0WlUHvlK1YgW50xu7lZHJEYnA==","X-Google-Smtp-Source":"ABdhPJx43H4AvMMZ8goOShtg9/ztUdptqjs63W9i07mUhl2ZAH7EtUBD5S63XlDcrEhSnJJrImT/fw==","X-Received":"by 2002:a05:651c:1182:: with SMTP id\n\tw2mr913760ljo.197.1597400337657; \n\tFri, 14 Aug 2020 03:18:57 -0700 (PDT)","Date":"Fri, 14 Aug 2020 12:18:55 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Message-ID":"<20200814101855.GB1995759@oden.dyn.berto.se>","References":"<20200806125330.2983325-1-niklas.soderlund@ragnatech.se>\n\t<20200806125330.2983325-2-niklas.soderlund@ragnatech.se>\n\t<20200814093532.GA15283@pendragon.ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200814093532.GA15283@pendragon.ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 1/3] libcamera: pipeline_handler: Make\n\tcameraData() a const operation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]