{"id":9236,"url":"https://patchwork.libcamera.org/api/patches/9236/?format=json","web_url":"https://patchwork.libcamera.org/patch/9236/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200805151507.227503-10-kieran.bingham@ideasonboard.com>","date":"2020-08-05T15:15:03","name":"[libcamera-devel,v4,09/13] android: camera_device: Query plane length","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"f17b925405aa011639453ab57d0330a3e55f9d91","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/9236/mbox/","series":[{"id":1198,"url":"https://patchwork.libcamera.org/api/series/1198/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1198","date":"2020-08-05T15:14:54","name":"android: JPEG support","version":4,"mbox":"https://patchwork.libcamera.org/series/1198/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/9236/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/9236/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E12FFBD87A\n\tfor ;\n\tWed, 5 Aug 2020 15:15:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AEB7C6088E;\n\tWed, 5 Aug 2020 17:15:19 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 236B16087E\n\tfor ;\n\tWed, 5 Aug 2020 17:15:16 +0200 (CEST)","from Q.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net\n\t[86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 968502C0;\n\tWed, 5 Aug 2020 17:15:15 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"tlSLJqaM\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1596640515;\n\tbh=cLrxAI8ZbDotkQjFuJKk/8/i7PqD7BKXIjPauSR67Fw=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=tlSLJqaMZf6KNaY/ekJUWEamdTdmuYhukpD4/9ysEfIiaCc0rWvaz+8dfEfCwZpMv\n\t5GVl5L4C0nSgxSOIVxHeqiNxjd7WLlUsRjg0i8lhXT1p1AMCZYHOFiDyzw6zsAxaUh\n\tt47jMGVWnDxSIdkASDzDIEMbffpP3RUwtLcPwiAc=","From":"Kieran Bingham ","To":"libcamera devel ","Date":"Wed, 5 Aug 2020 16:15:03 +0100","Message-Id":"<20200805151507.227503-10-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20200805151507.227503-1-kieran.bingham@ideasonboard.com>","References":"<20200805151507.227503-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v4 09/13] android: camera_device: Query\n\tplane length","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Use lseek to query the length of planes where possible rather than leaving\nthe plane.length as zero, which prevents mapping buffers for software\nprocessing.\n\nReviewed-by: Laurent Pinchart \nSigned-off-by: Kieran Bingham \n\n---\nv3\n - Return nullptr if we fail to query plane length\n\nv2:\n - no longer support an invalid plane length.\n---\n src/android/camera_device.cpp | 13 +++++++------\n 1 file changed, 7 insertions(+), 6 deletions(-)","diff":"diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex 27bcf3ab1930..a5c135ce03eb 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -1132,12 +1132,13 @@ FrameBuffer *CameraDevice::createFrameBuffer(const buffer_handle_t camera3buffer\n \t\t\treturn nullptr;\n \t\t}\n \n-\t\t/*\n-\t\t * Setting length to zero here is OK as the length is only used\n-\t\t * to map the memory of the plane. Libcamera do not need to poke\n-\t\t * at the memory content queued by the HAL.\n-\t\t */\n-\t\tplane.length = 0;\n+\t\toff_t length = lseek(plane.fd.fd(), 0, SEEK_END);\n+\t\tif (length == -1) {\n+\t\t\tLOG(HAL, Error) << \"Failed to query plane length\";\n+\t\t\treturn nullptr;\n+\t\t}\n+\n+\t\tplane.length = length;\n \t\tplanes.push_back(std::move(plane));\n \t}\n \n","prefixes":["libcamera-devel","v4","09/13"]}