{"id":9234,"url":"https://patchwork.libcamera.org/api/patches/9234/?format=json","web_url":"https://patchwork.libcamera.org/patch/9234/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200805151507.227503-8-kieran.bingham@ideasonboard.com>","date":"2020-08-05T15:15:01","name":"[libcamera-devel,v4,07/13] android: camera_device: Report an error in notifyError()","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"6a6f80239b8efe7f32ac228987adb428ccadcba1","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/9234/mbox/","series":[{"id":1198,"url":"https://patchwork.libcamera.org/api/series/1198/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1198","date":"2020-08-05T15:14:54","name":"android: JPEG support","version":4,"mbox":"https://patchwork.libcamera.org/series/1198/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/9234/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/9234/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0E7E2BD87A\n\tfor ;\n\tWed, 5 Aug 2020 15:15:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CE95F60392;\n\tWed, 5 Aug 2020 17:15:18 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5710260737\n\tfor ;\n\tWed, 5 Aug 2020 17:15:15 +0200 (CEST)","from Q.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net\n\t[86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8C522FED;\n\tWed, 5 Aug 2020 17:15:14 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"WhMjvyPD\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1596640514;\n\tbh=yY0O3lcI4a/vDxUU+xyYQw0f0jKZNbE3mUORFiDzGU0=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=WhMjvyPDb7Y8mIB6oXNTSoNKgwt0DfhzE1vlEXDfix+7fSIQ7WnT7TvzwUiEKnBhA\n\tkXurl4X67C18RHnsaFsJgSgEtdRjuYunzSPEkWIZyCf2h2Tk/dJBx6+lVaBQSo0Y7N\n\tADVRffQxcgraRiXpLNOvyH9dTJOGQA/s3HjklTxE=","From":"Kieran Bingham ","To":"libcamera devel ","Date":"Wed, 5 Aug 2020 16:15:01 +0100","Message-Id":"<20200805151507.227503-8-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20200805151507.227503-1-kieran.bingham@ideasonboard.com>","References":"<20200805151507.227503-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v4 07/13] android: camera_device: Report\n\tan error in notifyError()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"If an error is generated, try to be verbose about it in the libcamera logs.\n\nReviewed-by: Niklas Söderlund \nReviewed-by: Laurent Pinchart \nReviewed-by: Jacopo Mondi \nSigned-off-by: Kieran Bingham \n\n---\nv2:\n - Add todo to note possible debug info expansion\n - Fix typo\n - Print .toString() formatted pixel format\n\nv3:\n - Remove colon from todo:\n---\n src/android/camera_device.cpp | 7 +++++++\n 1 file changed, 7 insertions(+)","diff":"diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex 6235ef52df88..60af59ce154c 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -1294,6 +1294,13 @@ void CameraDevice::notifyError(uint32_t frameNumber, camera3_stream_t *stream)\n {\n \tcamera3_notify_msg_t notify = {};\n \n+\t/*\n+\t * \\todo Report and identify the stream number or configuration to\n+\t * clarify the stream that failed.\n+\t */\n+\tLOG(HAL, Error) << \"Error occurred on frame \" << frameNumber << \" (\"\n+\t\t\t<< toPixelFormat(stream->format).toString() << \")\";\n+\n \tnotify.type = CAMERA3_MSG_ERROR;\n \tnotify.message.error.error_stream = stream;\n \tnotify.message.error.frame_number = frameNumber;\n","prefixes":["libcamera-devel","v4","07/13"]}