[{"id":11918,"web_url":"https://patchwork.libcamera.org/comment/11918/","msgid":"<20200806123809.GB11947@pendragon.ideasonboard.com>","date":"2020-08-06T12:38:09","subject":"Re: [libcamera-devel] [PATCH v4 03/13] libcamera: buffer: Create a\n\tMappedBuffer","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Wed, Aug 05, 2020 at 04:14:57PM +0100, Kieran Bingham wrote:\n> Provide a MappedFrameBuffer helper class which will map\n> all of the Planes within a FrameBuffer and provide CPU addressable\n> pointers for those planes.\n> \n> The MappedFrameBuffer implements the interface of the MappedBuffer\n> allowing other buffer types to be constructed of the same form, with a\n> common interface and cleanup.\n> \n> This allows MappedBuffer instances to be created from Camera3Buffer types.\n> \n> Mappings are removed upon destruction.\n> \n> Signed-off-by: Kieran Bingham \n> \n> ---\n> v3\n> - Documentation fixups\n> \n> v4:\n> - Use reference when unmapping, rather than a copy of the planes.\n> - Move MappedPlane to MappedBuffer::Plane\n> - Remove valid_\n> - Make constructor protected\n> - Rename move constructor parameters from rhs to other\n> - Rework move constructor documentation.\n> ---\n> include/libcamera/internal/buffer.h | 47 +++++++++\n> src/libcamera/buffer.cpp | 152 +++++++++++++++++++++++++++-\n> 2 files changed, 198 insertions(+), 1 deletion(-)\n> create mode 100644 include/libcamera/internal/buffer.h\n> \n> diff --git a/include/libcamera/internal/buffer.h b/include/libcamera/internal/buffer.h\n> new file mode 100644\n> index 000000000000..b7b0173f93f5\n> --- /dev/null\n> +++ b/include/libcamera/internal/buffer.h\n> @@ -0,0 +1,47 @@\n> +/* SPDX-License-Identifier: LGPL-2.1-or-later */\n> +/*\n> + * Copyright (C) 2020, Google Inc.\n> + *\n> + * buffer.h - Internal buffer handling\n> + */\n> +#ifndef __LIBCAMERA_INTERNAL_BUFFER_H__\n> +#define __LIBCAMERA_INTERNAL_BUFFER_H__\n> +\n> +#include \n> +#include \n> +\n> +#include \n> +#include \n> +\n> +namespace libcamera {\n> +\n> +class MappedBuffer\n> +{\n> +public:\n> +\tusing Plane = Span;\n> +\n> +\t~MappedBuffer();\n> +\n> +\tMappedBuffer(MappedBuffer &&other);\n> +\tMappedBuffer &operator=(MappedBuffer &&other);\n> +\n> +\tbool isValid() const { return error_ == 0; }\n> +\tint error() const { return error_; }\n> +\tconst std::vector &maps() const { return maps_; }\n> +\n> +protected:\n> +\tMappedBuffer();\n> +\n> +\tint error_;\n> +\tstd::vector maps_;\n> +};\n> +\n> +class MappedFrameBuffer : public MappedBuffer\n> +{\n> +public:\n> +\tMappedFrameBuffer(const FrameBuffer *buffer, int flags);\n> +};\n> +\n> +} /* namespace libcamera */\n> +\n> +#endif /* __LIBCAMERA_INTERNAL_BUFFER_H__ */\n> diff --git a/src/libcamera/buffer.cpp b/src/libcamera/buffer.cpp\n> index 8278f8a92af4..8666f1992a77 100644\n> --- a/src/libcamera/buffer.cpp\n> +++ b/src/libcamera/buffer.cpp\n> @@ -6,6 +6,7 @@\n> */\n> \n> #include \n> +#include \"libcamera/internal/buffer.h\"\n> \n> #include \n> #include \n> @@ -15,7 +16,8 @@\n> #include \"libcamera/internal/log.h\"\n> \n> /**\n> - * \\file buffer.h\n> + * \\file libcamera/buffer.h\n\nI wonder, do you need a \\brief after each \\file entry ?\n\n> + * \\file libcamera/internal/buffer.h\n> * \\brief Buffer handling\n> */\n> \n> @@ -290,4 +292,152 @@ int FrameBuffer::copyFrom(const FrameBuffer *src)\n> \treturn 0;\n> }\n> \n> +/**\n> + * \\class MappedBuffer\n> + * \\brief Provide an interface to support managing memory mapped buffers\n> + *\n> + * The MappedBuffer interface provides access to a set of MappedPlanes which\n> + * are available for access by the CPU.\n> + *\n> + * This class is not meant to be constructed directly, but instead derived\n> + * classes should be used to implement the correct mapping of a source buffer.\n> + *\n> + * This allows treating CPU accessible memory through a generic interface\n> + * regardless of whether it originates from a libcamera FrameBuffer or other\n> + * source.\n> + */\n> +\n> +/**\n> + * \\typedef MappedBuffer::Plane\n> + * \\brief A mapped region of memory accessible to the CPU\n> + *\n> + * The MappedBuffer::Plane uses the Span interface to describe the mapped memory\n> + * region.\n> + */\n> +\n> +/**\n> + * \\brief Construct an empty MappedBuffer\n> + *\n> + * Base class initialisation for MappedBuffer.\n\nYou can drop this sentence, still no need to explain C++ :-)\n\n> + */\n> +MappedBuffer::MappedBuffer()\n> +\t: error_(0)\n> +{\n> +}\n> +\n> +/**\n> + * \\brief Move constructor, construct the MappedBuffer with the contents of \\a\n> + * other using move semantics\n> + * \\param[in] other The other MappedBuffer\n> + *\n> + * Moving a MappedBuffer moves the mappings contained in the \\a other to the new\n> + * MappedBuffer and invalidates the \\a other.\n> + *\n> + * No mappings are unmapped or destroyed in this process.\n> + */\n> +MappedBuffer::MappedBuffer(MappedBuffer &&other)\n> +{\n> +\t*this = std::move(other);\n> +}\n> +\n> +/**\n> + * \\brief Move assignment operator, replace the mappings with those of \\a other\n> + * mappings\n\nShould it be s/other mappings/other/ ?\n\n> + * \\param[in] other The other MappedBuffer\n> + *\n> + * Moving a MappedBuffer moves the mappings contained in the \\a other to the new\n> + * MappedBuffer and invalidates the \\a other.\n> + *\n> + * No mappings are unmapped or destroyed in this process.\n> + */\n> +MappedBuffer &MappedBuffer::operator=(MappedBuffer &&other)\n> +{\n> +\terror_ = other.error_;\n> +\tmaps_ = std::move(other.maps_);\n> +\tother.error_ = -ENOENT;\n> +\n> +\treturn *this;\n> +}\n> +\n> +MappedBuffer::~MappedBuffer()\n> +{\n> +\tfor (Plane &map : maps_)\n> +\t\tmunmap(map.data(), map.size());\n> +}\n> +\n> +/**\n> + * \\fn MappedBuffer::isValid()\n> + * \\brief Check if the MappedBuffer instance is valid\n> + * \\return True if the MappedBuffer has valid mappings, false otherwise\n> + */\n> +\n> +/**\n> + * \\fn MappedBuffer::error()\n> + * \\brief Retrieve the map error status\n> + *\n> + * This function retrieves the error status from the MappedBuffer.\n> + * The error status is a negative number as defined by errno.h. If\n> + * no error occurred, this function returns 0.\n> + *\n> + * \\return 0 on success or a negative error code otherwise\n\nI think this function always succeeds :-) Maybe \"\\return The map error\ncode\" ?\n\nReviewed-by: Laurent Pinchart \n\n> + */\n> +\n> +/**\n> + * \\fn MappedBuffer::maps()\n> + * \\brief Retrieve the mapped planes\n> + *\n> + * This function retrieves the successfully mapped planes stored as a vector\n> + * of Span to provide access to the mapped memory.\n> + *\n> + * \\return A vector of the mapped planes\n> + */\n> +\n> +/**\n> + * \\var MappedBuffer::error_\n> + * \\brief Stores the error value if present\n> + *\n> + * MappedBuffer derived classes shall set this to a negative value as defined\n> + * by errno.h if an error occured during the mapping process.\n> + */\n> +\n> +/**\n> + * \\var MappedBuffer::maps_\n> + * \\brief Stores the internal\n> + *\n> + * MappedBuffer derived classes shall store the mappings they create in this\n> + * vector which is parsed during destruct to unmap any memory mappings which\n> + * completed successfully.\n> + */\n> +\n> +/**\n> + * \\class MappedFrameBuffer\n> + * \\brief Map a FrameBuffer using the MappedBuffer interface\n> + */\n> +\n> +/**\n> + * \\brief Map all planes of a FrameBuffer\n> + * \\param[in] buffer FrameBuffer to be mapped\n> + * \\param[in] flags Protection flags to apply to map\n> + *\n> + * Construct an object to map a frame buffer for CPU access.\n> + * The flags are passed directly to mmap and should be either PROT_READ,\n> + * PROT_WRITE, or a bitwise-or combination of both.\n> + */\n> +MappedFrameBuffer::MappedFrameBuffer(const FrameBuffer *buffer, int flags)\n> +{\n> +\tmaps_.reserve(buffer->planes().size());\n> +\n> +\tfor (const FrameBuffer::Plane &plane : buffer->planes()) {\n> +\t\tvoid *address = mmap(nullptr, plane.length, flags,\n> +\t\t\t\t MAP_SHARED, plane.fd.fd(), 0);\n> +\t\tif (address == MAP_FAILED) {\n> +\t\t\terror_ = -errno;\n> +\t\t\tLOG(Buffer, Error) << \"Failed to mmap plane\";\n> +\t\t\tbreak;\n> +\t\t}\n> +\n> +\t\tmaps_.emplace_back(static_cast(address), plane.length);\n> +\t}\n> +}\n> +\n> } /* namespace libcamera */","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A9988BD87A\n\tfor ;\n\tThu, 6 Aug 2020 12:38:25 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3A87F6055A;\n\tThu, 6 Aug 2020 14:38:25 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D3D6260554\n\tfor ;\n\tThu, 6 Aug 2020 14:38:22 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C77A350E;\n\tThu, 6 Aug 2020 14:38:21 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"r/pr5v9m\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1596717502;\n\tbh=Q+fwVHFln5Hqg8aW+PkCIBgHlm4HkIHzu4mD7GJKgic=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=r/pr5v9m7PM7KSlyE/+0MvJT7jUb3cXq3X0ZDZiVyDXgaWNYpqQq4uQNnhveCYySu\n\tK9ue55KWicUeey8MZHx2OQb0FnX98VSr3tpphZnMnSqjcRykLNk0SUkFVn209FjPUk\n\tLgq9TLJlPXKep+fnxiHNkw8fJykm3RZeeSYZ9qx4=","Date":"Thu, 6 Aug 2020 15:38:09 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"<20200806123809.GB11947@pendragon.ideasonboard.com>","References":"<20200805151507.227503-1-kieran.bingham@ideasonboard.com>\n\t<20200805151507.227503-4-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200805151507.227503-4-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v4 03/13] libcamera: buffer: Create a\n\tMappedBuffer","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":11922,"web_url":"https://patchwork.libcamera.org/comment/11922/","msgid":"<226a1ff9-bf89-5985-6716-0e32e5cc095d@ideasonboard.com>","date":"2020-08-06T13:01:04","subject":"Re: [libcamera-devel] [PATCH v4 03/13] libcamera: buffer: Create a\n\tMappedBuffer","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 06/08/2020 13:38, Laurent Pinchart wrote:\n> Hi Kieran,\n> \n> Thank you for the patch.\n> \n> On Wed, Aug 05, 2020 at 04:14:57PM +0100, Kieran Bingham wrote:\n>> Provide a MappedFrameBuffer helper class which will map\n>> all of the Planes within a FrameBuffer and provide CPU addressable\n>> pointers for those planes.\n>>\n>> The MappedFrameBuffer implements the interface of the MappedBuffer\n>> allowing other buffer types to be constructed of the same form, with a\n>> common interface and cleanup.\n>>\n>> This allows MappedBuffer instances to be created from Camera3Buffer types.\n>>\n>> Mappings are removed upon destruction.\n>>\n>> Signed-off-by: Kieran Bingham \n>>\n>> ---\n>> v3\n>> - Documentation fixups\n>>\n>> v4:\n>> - Use reference when unmapping, rather than a copy of the planes.\n>> - Move MappedPlane to MappedBuffer::Plane\n>> - Remove valid_\n>> - Make constructor protected\n>> - Rename move constructor parameters from rhs to other\n>> - Rework move constructor documentation.\n>> ---\n>> include/libcamera/internal/buffer.h | 47 +++++++++\n>> src/libcamera/buffer.cpp | 152 +++++++++++++++++++++++++++-\n>> 2 files changed, 198 insertions(+), 1 deletion(-)\n>> create mode 100644 include/libcamera/internal/buffer.h\n>>\n>> diff --git a/include/libcamera/internal/buffer.h b/include/libcamera/internal/buffer.h\n>> new file mode 100644\n>> index 000000000000..b7b0173f93f5\n>> --- /dev/null\n>> +++ b/include/libcamera/internal/buffer.h\n>> @@ -0,0 +1,47 @@\n>> +/* SPDX-License-Identifier: LGPL-2.1-or-later */\n>> +/*\n>> + * Copyright (C) 2020, Google Inc.\n>> + *\n>> + * buffer.h - Internal buffer handling\n>> + */\n>> +#ifndef __LIBCAMERA_INTERNAL_BUFFER_H__\n>> +#define __LIBCAMERA_INTERNAL_BUFFER_H__\n>> +\n>> +#include \n>> +#include \n>> +\n>> +#include \n>> +#include \n>> +\n>> +namespace libcamera {\n>> +\n>> +class MappedBuffer\n>> +{\n>> +public:\n>> +\tusing Plane = Span;\n>> +\n>> +\t~MappedBuffer();\n>> +\n>> +\tMappedBuffer(MappedBuffer &&other);\n>> +\tMappedBuffer &operator=(MappedBuffer &&other);\n>> +\n>> +\tbool isValid() const { return error_ == 0; }\n>> +\tint error() const { return error_; }\n>> +\tconst std::vector &maps() const { return maps_; }\n>> +\n>> +protected:\n>> +\tMappedBuffer();\n>> +\n>> +\tint error_;\n>> +\tstd::vector maps_;\n>> +};\n>> +\n>> +class MappedFrameBuffer : public MappedBuffer\n>> +{\n>> +public:\n>> +\tMappedFrameBuffer(const FrameBuffer *buffer, int flags);\n>> +};\n>> +\n>> +} /* namespace libcamera */\n>> +\n>> +#endif /* __LIBCAMERA_INTERNAL_BUFFER_H__ */\n>> diff --git a/src/libcamera/buffer.cpp b/src/libcamera/buffer.cpp\n>> index 8278f8a92af4..8666f1992a77 100644\n>> --- a/src/libcamera/buffer.cpp\n>> +++ b/src/libcamera/buffer.cpp\n>> @@ -6,6 +6,7 @@\n>> */\n>> \n>> #include \n>> +#include \"libcamera/internal/buffer.h\"\n>> \n>> #include \n>> #include \n>> @@ -15,7 +16,8 @@\n>> #include \"libcamera/internal/log.h\"\n>> \n>> /**\n>> - * \\file buffer.h\n>> + * \\file libcamera/buffer.h\n> \n> I wonder, do you need a \\brief after each \\file entry ?\n\nActually, I can see that they should.\n\nWith this, only internal/buffer.h is described in the api-html.\n\n> \n>> + * \\file libcamera/internal/buffer.h\n>> * \\brief Buffer handling\n\nupdating with\n\n/**\n * \\file libcamera/buffer.h\n * \\brief Buffer handling\n *\n * \\file libcamera/internal/buffer.h\n * \\brief Internal buffer handling support\n */\n\nWhich now correctly renders in api-html/files.html\n\n\n>> */\n>> \n>> @@ -290,4 +292,152 @@ int FrameBuffer::copyFrom(const FrameBuffer *src)\n>> \treturn 0;\n>> }\n>> \n>> +/**\n>> + * \\class MappedBuffer\n>> + * \\brief Provide an interface to support managing memory mapped buffers\n>> + *\n>> + * The MappedBuffer interface provides access to a set of MappedPlanes which\n>> + * are available for access by the CPU.\n>> + *\n>> + * This class is not meant to be constructed directly, but instead derived\n>> + * classes should be used to implement the correct mapping of a source buffer.\n>> + *\n>> + * This allows treating CPU accessible memory through a generic interface\n>> + * regardless of whether it originates from a libcamera FrameBuffer or other\n>> + * source.\n>> + */\n>> +\n>> +/**\n>> + * \\typedef MappedBuffer::Plane\n>> + * \\brief A mapped region of memory accessible to the CPU\n>> + *\n>> + * The MappedBuffer::Plane uses the Span interface to describe the mapped memory\n>> + * region.\n>> + */\n>> +\n>> +/**\n>> + * \\brief Construct an empty MappedBuffer\n>> + *\n>> + * Base class initialisation for MappedBuffer.\n> \n> You can drop this sentence, still no need to explain C++ :-)\n> \n\nDropped.\n\n\n>> + */\n>> +MappedBuffer::MappedBuffer()\n>> +\t: error_(0)\n>> +{\n>> +}\n>> +\n>> +/**\n>> + * \\brief Move constructor, construct the MappedBuffer with the contents of \\a\n>> + * other using move semantics\n>> + * \\param[in] other The other MappedBuffer\n>> + *\n>> + * Moving a MappedBuffer moves the mappings contained in the \\a other to the new\n>> + * MappedBuffer and invalidates the \\a other.\n>> + *\n>> + * No mappings are unmapped or destroyed in this process.\n>> + */\n>> +MappedBuffer::MappedBuffer(MappedBuffer &&other)\n>> +{\n>> +\t*this = std::move(other);\n>> +}\n>> +\n>> +/**\n>> + * \\brief Move assignment operator, replace the mappings with those of \\a other\n>> + * mappings\n> \n> Should it be s/other mappings/other/ ?\n> \n\nIndeed.\n\n\n>> + * \\param[in] other The other MappedBuffer\n>> + *\n>> + * Moving a MappedBuffer moves the mappings contained in the \\a other to the new\n>> + * MappedBuffer and invalidates the \\a other.\n>> + *\n>> + * No mappings are unmapped or destroyed in this process.\n>> + */\n>> +MappedBuffer &MappedBuffer::operator=(MappedBuffer &&other)\n>> +{\n>> +\terror_ = other.error_;\n>> +\tmaps_ = std::move(other.maps_);\n>> +\tother.error_ = -ENOENT;\n>> +\n>> +\treturn *this;\n>> +}\n>> +\n>> +MappedBuffer::~MappedBuffer()\n>> +{\n>> +\tfor (Plane &map : maps_)\n>> +\t\tmunmap(map.data(), map.size());\n>> +}\n>> +\n>> +/**\n>> + * \\fn MappedBuffer::isValid()\n>> + * \\brief Check if the MappedBuffer instance is valid\n>> + * \\return True if the MappedBuffer has valid mappings, false otherwise\n>> + */\n>> +\n>> +/**\n>> + * \\fn MappedBuffer::error()\n>> + * \\brief Retrieve the map error status\n>> + *\n>> + * This function retrieves the error status from the MappedBuffer.\n>> + * The error status is a negative number as defined by errno.h. If\n>> + * no error occurred, this function returns 0.\n>> + *\n>> + * \\return 0 on success or a negative error code otherwise\n> \n> I think this function always succeeds :-) Maybe \"\\return The map error\n> code\" ?\n\nOoops, indeed it does.\n\nCorrected,\n\n> \n> Reviewed-by: Laurent Pinchart \n\nCollected,\n\nAnd will push after a final re-test cycle.\n\nThanks.\n\n--\nKieran\n\n\n> \n>> + */\n>> +\n>> +/**\n>> + * \\fn MappedBuffer::maps()\n>> + * \\brief Retrieve the mapped planes\n>> + *\n>> + * This function retrieves the successfully mapped planes stored as a vector\n>> + * of Span to provide access to the mapped memory.\n>> + *\n>> + * \\return A vector of the mapped planes\n>> + */\n>> +\n>> +/**\n>> + * \\var MappedBuffer::error_\n>> + * \\brief Stores the error value if present\n>> + *\n>> + * MappedBuffer derived classes shall set this to a negative value as defined\n>> + * by errno.h if an error occured during the mapping process.\n>> + */\n>> +\n>> +/**\n>> + * \\var MappedBuffer::maps_\n>> + * \\brief Stores the internal\n>> + *\n>> + * MappedBuffer derived classes shall store the mappings they create in this\n>> + * vector which is parsed during destruct to unmap any memory mappings which\n>> + * completed successfully.\n>> + */\n>> +\n>> +/**\n>> + * \\class MappedFrameBuffer\n>> + * \\brief Map a FrameBuffer using the MappedBuffer interface\n>> + */\n>> +\n>> +/**\n>> + * \\brief Map all planes of a FrameBuffer\n>> + * \\param[in] buffer FrameBuffer to be mapped\n>> + * \\param[in] flags Protection flags to apply to map\n>> + *\n>> + * Construct an object to map a frame buffer for CPU access.\n>> + * The flags are passed directly to mmap and should be either PROT_READ,\n>> + * PROT_WRITE, or a bitwise-or combination of both.\n>> + */\n>> +MappedFrameBuffer::MappedFrameBuffer(const FrameBuffer *buffer, int flags)\n>> +{\n>> +\tmaps_.reserve(buffer->planes().size());\n>> +\n>> +\tfor (const FrameBuffer::Plane &plane : buffer->planes()) {\n>> +\t\tvoid *address = mmap(nullptr, plane.length, flags,\n>> +\t\t\t\t MAP_SHARED, plane.fd.fd(), 0);\n>> +\t\tif (address == MAP_FAILED) {\n>> +\t\t\terror_ = -errno;\n>> +\t\t\tLOG(Buffer, Error) << \"Failed to mmap plane\";\n>> +\t\t\tbreak;\n>> +\t\t}\n>> +\n>> +\t\tmaps_.emplace_back(static_cast(address), plane.length);\n>> +\t}\n>> +}\n>> +\n>> } /* namespace libcamera */\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F0D98BD86F\n\tfor ;\n\tThu, 6 Aug 2020 13:01:09 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7CB4260599;\n\tThu, 6 Aug 2020 15:01:09 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 08CAE60554\n\tfor ;\n\tThu, 6 Aug 2020 15:01:08 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6475D50E;\n\tThu, 6 Aug 2020 15:01:07 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"uuZmtbWX\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1596718867;\n\tbh=GavkOgODaOXfFnL5snM+sBwtZEhNKH2uDOoM8SPdVEk=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=uuZmtbWXYvZ5QpcMq8YRYEAl0xQPCJomzQZavwPMnrDXmQpmHXqbAJgLK/9iNUWaN\n\tcVFvEZPNwID6GE1RkoxsBMXpL/QVNAYIQpqtzNoW98TMOejUaIc16DQUDlIupts8KD\n\t4luBXaottUItdvy+MUGXg3U2CAWJPd1Qtsxz/53c=","To":"Laurent Pinchart ","References":"<20200805151507.227503-1-kieran.bingham@ideasonboard.com>\n\t<20200805151507.227503-4-kieran.bingham@ideasonboard.com>\n\t<20200806123809.GB11947@pendragon.ideasonboard.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<226a1ff9-bf89-5985-6716-0e32e5cc095d@ideasonboard.com>","Date":"Thu, 6 Aug 2020 14:01:04 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20200806123809.GB11947@pendragon.ideasonboard.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH v4 03/13] libcamera: buffer: Create a\n\tMappedBuffer","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]