[{"id":1298,"web_url":"https://patchwork.libcamera.org/comment/1298/","msgid":"<20190406162013.GA4817@pendragon.ideasonboard.com>","date":"2019-04-06T16:20:13","subject":"Re: [libcamera-devel] [PATCH] libcamera: Add missing header files\n\tto meson.build","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patch.\n\nOn Fri, Apr 05, 2019 at 10:01:10PM +0200, Niklas Söderlund wrote:\n> Signed-off-by: Niklas Söderlund \n\nYou may have wanted to explain why you don't include geometry.h here, or\neven include it, but otherwise,\n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/meson.build | 2 ++\n> 1 file changed, 2 insertions(+)\n> \n> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n> index b2fe0e4f4080c6fd..cd36ac3075180ef6 100644\n> --- a/src/libcamera/meson.build\n> +++ b/src/libcamera/meson.build\n> @@ -25,12 +25,14 @@ libcamera_sources = files([\n> libcamera_headers = files([\n> 'include/device_enumerator.h',\n> 'include/event_dispatcher_poll.h',\n> + 'include/formats.h',\n> 'include/log.h',\n> 'include/media_device.h',\n> 'include/media_object.h',\n> 'include/pipeline_handler.h',\n> 'include/utils.h',\n> 'include/v4l2_device.h',\n> + 'include/v4l2_subdevice.h',\n> ])\n> \n> libcamera_internal_includes = include_directories('include')","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0D24160B1B\n\tfor ;\n\tSat, 6 Apr 2019 18:20:29 +0200 (CEST)","from pendragon.ideasonboard.com (unknown [91.183.39.81])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7ABBA99F;\n\tSat, 6 Apr 2019 18:20:28 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1554567628;\n\tbh=R9c6s6u6H8cm78TltsRBQU21EmS30DZsd2XMzeTfRS0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=BDlp6sTPGhNiHrXAt0AogqvcXeyJSikiPsU0BKMSIpcf3mA3Azec0h8N2h6PWM0IN\n\t2Npw46f7nkDTHndwZ4QGydM7/41XHGtyz4Z/C7q8LnPIMnrfj2cmG7jb9pw28h558p\n\tpYWAWJmoRRic3dlbjIaHHuc783Ref+fBsd+oNz98=","Date":"Sat, 6 Apr 2019 19:20:13 +0300","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190406162013.GA4817@pendragon.ideasonboard.com>","References":"<20190405200110.596-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190405200110.596-1-niklas.soderlund@ragnatech.se>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH] libcamera: Add missing header files\n\tto meson.build","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sat, 06 Apr 2019 16:20:29 -0000"}},{"id":1327,"web_url":"https://patchwork.libcamera.org/comment/1327/","msgid":"<20190409155117.GR15350@bigcity.dyn.berto.se>","date":"2019-04-09T15:51:17","subject":"Re: [libcamera-devel] [PATCH] libcamera: Add missing header files\n\tto meson.build","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi,\n\nOn 2019-04-06 19:20:13 +0300, Laurent Pinchart wrote:\n> Hi Niklas,\n> \n> Thank you for the patch.\n> \n> On Fri, Apr 05, 2019 at 10:01:10PM +0200, Niklas Söderlund wrote:\n> > Signed-off-by: Niklas Söderlund \n> \n> You may have wanted to explain why you don't include geometry.h here, or\n> even include it, but otherwise,\n\nOr I can wait so that geometry.h is already moved before pushing :-)\n\n> \n> Reviewed-by: Laurent Pinchart \n\nThanks this is now pushed to master.\n\n> \n> > ---\n> > src/libcamera/meson.build | 2 ++\n> > 1 file changed, 2 insertions(+)\n> > \n> > diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n> > index b2fe0e4f4080c6fd..cd36ac3075180ef6 100644\n> > --- a/src/libcamera/meson.build\n> > +++ b/src/libcamera/meson.build\n> > @@ -25,12 +25,14 @@ libcamera_sources = files([\n> > libcamera_headers = files([\n> > 'include/device_enumerator.h',\n> > 'include/event_dispatcher_poll.h',\n> > + 'include/formats.h',\n> > 'include/log.h',\n> > 'include/media_device.h',\n> > 'include/media_object.h',\n> > 'include/pipeline_handler.h',\n> > 'include/utils.h',\n> > 'include/v4l2_device.h',\n> > + 'include/v4l2_subdevice.h',\n> > ])\n> > \n> > libcamera_internal_includes = include_directories('include')\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart","headers":{"Return-Path":"","Received":["from mail-lj1-x243.google.com (mail-lj1-x243.google.com\n\t[IPv6:2a00:1450:4864:20::243])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6927D60004\n\tfor ;\n\tTue, 9 Apr 2019 17:51:19 +0200 (CEST)","by mail-lj1-x243.google.com with SMTP id h16so14900075ljg.11\n\tfor ;\n\tTue, 09 Apr 2019 08:51:19 -0700 (PDT)","from localhost (89-233-230-99.cust.bredband2.com. [89.233.230.99])\n\tby smtp.gmail.com with ESMTPSA id\n\tw20sm792457lfl.50.2019.04.09.08.51.17\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tTue, 09 Apr 2019 08:51:17 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=nRVh3PLk0y0nB2xOgAHDwNsIGiDfE6qXaZtUqjeMokI=;\n\tb=c8/DMXzhd2EyM+YJCghQKdIaKXzVOcpcjBZntVEiCoDUMd6OPnhl9gK9iD61hlX3hl\n\tBB+b6LJs1rhGVv9JIXAz235tmSEZbTNjL2EinI3zVjNLtOsTVdjRQpBX7ki6c7dT7n6w\n\tsBYZ/4NYbh/druDZUbL0rLF/8czdKud1OtiaNIaDElCzQRZ3Xw/sjSqSTgCHrd5Q3Am/\n\tCsJSL92coPBYOCtU5cDMbFbQsRPqk7DV91qzzwbzMzRptXBWl4hBJ5xqQ9ym/V+hqx1h\n\tGYhxg5kzyzDGz/WXz4/4rXq/ucR8I0O1ZdZvx1OilndvKCxRW3JjScaQ1m3L1cQVgxUS\n\tebpw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=nRVh3PLk0y0nB2xOgAHDwNsIGiDfE6qXaZtUqjeMokI=;\n\tb=bF3FDs28odvdmPSusJFcLOn+6WkskWvFAAnl3q0lfrYHU7tiJSjxlIgRz8pTOhBlul\n\tBX6Ve1gEi8o3WGSzzoDoAetmT8EdHWgbKCOgcOJbc5cadProFldUXIj5P4obnoTFl8Ul\n\t551X60Wc/I/aeapWpAVH2417WaPY5UBGnMgq5SA65TUna49cfWw8uDP00G6wzeOR5/BP\n\tt/GWN433I+TN7oxiQiqHJdsdtEU6Y+5j4kDVVF+zRtaE36Cgt3CCnsTiEgeNdQi6cvmj\n\t7e4llbWuwhBGVaYoGKymjDLUu07iCj8k04se019A2WYe1RNoGskjeRUbB3OxegEi14Ry\n\tNlOw==","X-Gm-Message-State":"APjAAAU18gtumYqiK+6BUZZTDpZxh1wrMcEgKxWElTBYsM5BtEVhv47f\n\txAM0SqL6bDYtYY2FH5BXp58qLFQzGOg=","X-Google-Smtp-Source":"APXvYqy+mhy/VRdPqOoh7Ie2UA+nnJqu+IhInVj7yYBP9bLnOdEBQNKpBL7NWXjKBe/BOFIx5ulgZA==","X-Received":"by 2002:a2e:2244:: with SMTP id i65mr5003374lji.81.1554825078848;\n\tTue, 09 Apr 2019 08:51:18 -0700 (PDT)","Date":"Tue, 9 Apr 2019 17:51:17 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190409155117.GR15350@bigcity.dyn.berto.se>","References":"<20190405200110.596-1-niklas.soderlund@ragnatech.se>\n\t<20190406162013.GA4817@pendragon.ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190406162013.GA4817@pendragon.ideasonboard.com>","User-Agent":"Mutt/1.11.3 (2019-02-01)","Subject":"Re: [libcamera-devel] [PATCH] libcamera: Add missing header files\n\tto meson.build","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 09 Apr 2019 15:51:19 -0000"}}]