{"id":9224,"url":"https://patchwork.libcamera.org/api/patches/9224/?format=json","web_url":"https://patchwork.libcamera.org/patch/9224/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200805151437.157155-2-email@uajain.com>","date":"2020-08-05T15:14:43","name":"[libcamera-devel,1/2] android: camera_hal_manager: Set camera module callbacks","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"1835c9e0e60262e561acd29aaa67994627094659","submitter":{"id":1,"url":"https://patchwork.libcamera.org/api/people/1/?format=json","name":"Umang Jain","email":"email@uajain.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/9224/mbox/","series":[{"id":1197,"url":"https://patchwork.libcamera.org/api/series/1197/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1197","date":"2020-08-05T15:14:43","name":"android: Camera hotplug support","version":1,"mbox":"https://patchwork.libcamera.org/series/1197/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/9224/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/9224/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 64DBBBD86F\n\tfor ;\n\tWed, 5 Aug 2020 15:14:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A0320605C8;\n\tWed, 5 Aug 2020 17:14:46 +0200 (CEST)","from o1.f.az.sendgrid.net (o1.f.az.sendgrid.net [208.117.55.132])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EA0B060392\n\tfor ;\n\tWed, 5 Aug 2020 17:14:44 +0200 (CEST)","by filterdrecv-p3mdw1-7ff865655c-v2mn4 with SMTP id\n\tfilterdrecv-p3mdw1-7ff865655c-v2mn4-20-5F2ACCE3-53\n\t2020-08-05 15:14:43.355425338 +0000 UTC m=+593902.314865933","from mail.uajain.com (unknown)\n\tby ismtpd0004p1hnd1.sendgrid.net (SG) with ESMTP id\n\tHIWX1sRURUuFpQHMgSJtKw for ;\n\tWed, 05 Aug 2020 15:14:43.055 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=uajain.com header.i=@uajain.com\n\theader.b=\"A3GSacnY\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=uajain.com;\n\th=from:subject:in-reply-to:references:mime-version:to:cc:\n\tcontent-transfer-encoding:content-type;\n\ts=s1; bh=VhMV+U4GddRuc6p3Gs2zRH6oPbOEximacaN90MzUup0=;\n\tb=A3GSacnYuW2LAAGaBry4Cc3fla4txoDoTGayaESj9ZX1UBsjZXu07uej743mO6RRRqmn\n\ts+xjAF5k+8iBKuxs8NsjBzTJZvjWyPOohNCmUEIngW8UYdjbbcptAsD9DWSnBnDFVn/0Gs\n\t/Tic5vEpy4BNZO14CiAdGBAWWFR0O+M6M=","From":"Umang Jain ","Date":"Wed, 05 Aug 2020 15:14:43 +0000 (UTC)","Message-Id":"<20200805151437.157155-2-email@uajain.com>","In-Reply-To":"<20200805151437.157155-1-email@uajain.com>","References":"<20200805151437.157155-1-email@uajain.com>","Mime-Version":"1.0","X-SG-EID":"1Q40EQ7YGir8a9gjSIAdTjhngY657NMk9ckeo4dbHZDiOpywc/L3L9rFqlwE4KPcBLpXFhl3+P87RHKL8hWvbDKSmLgbXwLsI2/vRybnYQhtpZ/KUcQqhLGSjdYkhGTZFAAYeIqDmlyA4qRwSulFlKtMrf0POxZpGW6s5Bm2XdszttcJN802lE6RKdRe3svBqeLFh3ro1fLi/wQaSeK7Nax5kB+ZQ1806hVwrCmPAiy/PGrb/9PlkkqHjtLCJxcabapGcXrXLaANkIxVyOke5w==","To":"libcamera-devel@lists.libcamera.org","Subject":"[libcamera-devel] [PATCH 1/2] android: camera_hal_manager: Set\n\tcamera module callbacks","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"camera_module_callbacks are invoked to inform the framework about\nthe events occuring module-wide. Allow to set these callbacks in\ncamera_hal_manager as this will be used to integration camera hotplug\nsupport via camera_module_callbacks::camera_device_status_change in\nsubsequent commit.\n\nSigned-off-by: Umang Jain \n---\n src/android/camera3_hal.cpp | 2 +-\n src/android/camera_hal_manager.cpp | 7 +++++++\n src/android/camera_hal_manager.h | 3 +++\n 3 files changed, 11 insertions(+), 1 deletion(-)","diff":"diff --git a/src/android/camera3_hal.cpp b/src/android/camera3_hal.cpp\nindex 716e36c..47c1aa9 100644\n--- a/src/android/camera3_hal.cpp\n+++ b/src/android/camera3_hal.cpp\n@@ -34,7 +34,7 @@ static int hal_get_camera_info(int id, struct camera_info *info)\n \n static int hal_set_callbacks(const camera_module_callbacks_t *callbacks)\n {\n-\treturn 0;\n+\treturn cameraManager.setCallbacks(callbacks);\n }\n \n static int hal_open_legacy(const struct hw_module_t *module, const char *id,\ndiff --git a/src/android/camera_hal_manager.cpp b/src/android/camera_hal_manager.cpp\nindex 02b6418..3ddcab5 100644\n--- a/src/android/camera_hal_manager.cpp\n+++ b/src/android/camera_hal_manager.cpp\n@@ -120,3 +120,10 @@ int CameraHalManager::getCameraInfo(unsigned int id, struct camera_info *info)\n \n \treturn 0;\n }\n+\n+int CameraHalManager::setCallbacks(const camera_module_callbacks_t *callbacks)\n+{\n+\tcallbacks_ = callbacks;\n+\n+\treturn 0;\n+}\ndiff --git a/src/android/camera_hal_manager.h b/src/android/camera_hal_manager.h\nindex 0619037..4345b1e 100644\n--- a/src/android/camera_hal_manager.h\n+++ b/src/android/camera_hal_manager.h\n@@ -10,6 +10,7 @@\n #include \n #include \n \n+#include \n #include \n #include \n \n@@ -29,10 +30,12 @@ public:\n \n \tunsigned int numCameras() const;\n \tint getCameraInfo(unsigned int id, struct camera_info *info);\n+\tint setCallbacks(const camera_module_callbacks_t *callbacks);\n \n private:\n \tlibcamera::CameraManager *cameraManager_;\n \n+\tconst camera_module_callbacks_t *callbacks_;\n \tstd::vector> cameras_;\n };\n \n","prefixes":["libcamera-devel","1/2"]}