[{"id":11888,"web_url":"https://patchwork.libcamera.org/comment/11888/","msgid":"<20200805142933.GG6751@pendragon.ideasonboard.com>","date":"2020-08-05T14:29:33","subject":"Re: [libcamera-devel] [PATCH] libcamera: Add build time to version\n\tstring","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patch.\n\nOn Wed, Aug 05, 2020 at 02:57:00PM +0200, Niklas Söderlund wrote:\n> Having the build time in the version string is useful when building from\n> a dirty worktree and deploying to targets as a quick way to identify the\n> binary have been deployed successfully.\n> \n> Before this change the version string is reported as\n> \n> libcamera v0.0.0+1692-aaff196a-dirty\n> \n> While with this change the version string is reported as\n> \n> libcamera v0.0.0+1692-aaff196a-dirty 2020-08-05T12:55:11+00:00\n> \n> Signed-off-by: Niklas Söderlund \n\nThis will get in the way of reproducible builds, especially for tagged\nreleases. I would at least restrict this feature to dirty builds, and\neven then, I'll let Kieran comment on whether reproducible builds are\nimportant.\n\n> ---\n> utils/gen-version.sh | 4 +++-\n> 1 file changed, 3 insertions(+), 1 deletion(-)\n> \n> diff --git a/utils/gen-version.sh b/utils/gen-version.sh\n> index 7f7872ceba7b038a..93bc97d6d8a8a24a 100755\n> --- a/utils/gen-version.sh\n> +++ b/utils/gen-version.sh\n> @@ -32,4 +32,6 @@ git diff-index --quiet HEAD || version=\"$version-dirty\"\n> # of the git SHA1 and remove the initial 'v'.\n> version=$(echo \"$version\" | sed -e 's/-/+/' | sed -e 's/-g/-/' | cut -c 2-)\n> \n> -echo \"$version\"\n> +buildtime=$(date --iso-8601=seconds --utc)\n> +\n> +echo \"$version $buildtime\"","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EFFE0BD86F\n\tfor ;\n\tWed, 5 Aug 2020 14:29:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B5CDE605A8;\n\tWed, 5 Aug 2020 16:29:46 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 56E046039D\n\tfor ;\n\tWed, 5 Aug 2020 16:29:45 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D18F82C0;\n\tWed, 5 Aug 2020 16:29:44 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"HEDv5MJL\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1596637785;\n\tbh=hXapGspNifko44FXBASNjunZ+MsErvInTkp2ZcrBTPY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=HEDv5MJL75IjkwS6RID64Xa7l9Ue1YKuP4B0RcKi1x2uZOF/ullu8lWIgjJHqq5p9\n\tITzFtf4mMshwGtO6NBEootMayMysKprVEnzTu2Zb8YSzBvHyfcPiOc2fsOro297dW7\n\tPodCmiHyDco+XLWjaZwKIzq9nw6m6ppiEmL6hWVQ=","Date":"Wed, 5 Aug 2020 17:29:33 +0300","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Message-ID":"<20200805142933.GG6751@pendragon.ideasonboard.com>","References":"<20200805125700.2254511-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200805125700.2254511-1-niklas.soderlund@ragnatech.se>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: Add build time to version\n\tstring","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":11889,"web_url":"https://patchwork.libcamera.org/comment/11889/","msgid":"<1e5340ad-4431-3982-33f8-2f062da8638f@ideasonboard.com>","date":"2020-08-05T14:34:01","subject":"Re: [libcamera-devel] [PATCH] libcamera: Add build time to version\n\tstring","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi all,\n\nOn 05/08/2020 15:29, Laurent Pinchart wrote:\n> Hi Niklas,\n> \n> Thank you for the patch.\n> \n> On Wed, Aug 05, 2020 at 02:57:00PM +0200, Niklas Söderlund wrote:\n>> Having the build time in the version string is useful when building from\n>> a dirty worktree and deploying to targets as a quick way to identify the\n>> binary have been deployed successfully.\n>>\n>> Before this change the version string is reported as\n>>\n>> libcamera v0.0.0+1692-aaff196a-dirty\n>>\n>> While with this change the version string is reported as\n>>\n>> libcamera v0.0.0+1692-aaff196a-dirty 2020-08-05T12:55:11+00:00\n>>\n>> Signed-off-by: Niklas Söderlund \n> \n> This will get in the way of reproducible builds, especially for tagged\n> releases. I would at least restrict this feature to dirty builds, and\n> even then, I'll let Kieran comment on whether reproducible builds are\n> important.\n\nI think I recall determining that reproducible builds were already\nbroken due to the way meson handles RPATH/RUNPATH.\n\nI too frequently use the version string to make sure I am running the\nsame code I expect, and having a build-time stamp in there (for debug)\nbuilds would be quite nice.\n\nRestricting this to DEBUG builds might be quite nice, then release\nbuilds from packagers just get a clean version.\n\nAdding only for release builds also removes any worries of reproducible\nbuilds from the equation anyway ;-)\n\n--\nKieran\n\n\n>> ---\n>> utils/gen-version.sh | 4 +++-\n>> 1 file changed, 3 insertions(+), 1 deletion(-)\n>>\n>> diff --git a/utils/gen-version.sh b/utils/gen-version.sh\n>> index 7f7872ceba7b038a..93bc97d6d8a8a24a 100755\n>> --- a/utils/gen-version.sh\n>> +++ b/utils/gen-version.sh\n>> @@ -32,4 +32,6 @@ git diff-index --quiet HEAD || version=\"$version-dirty\"\n>> # of the git SHA1 and remove the initial 'v'.\n>> version=$(echo \"$version\" | sed -e 's/-/+/' | sed -e 's/-g/-/' | cut -c 2-)\n>> \n>> -echo \"$version\"\n>> +buildtime=$(date --iso-8601=seconds --utc)\n>> +\n>> +echo \"$version $buildtime\"\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0358FBD87A\n\tfor ;\n\tWed, 5 Aug 2020 14:34:08 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 87062605A8;\n\tWed, 5 Aug 2020 16:34:07 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9F7426039D\n\tfor ;\n\tWed, 5 Aug 2020 16:34:05 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EC1E72C0;\n\tWed, 5 Aug 2020 16:34:04 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Ijr3ABuc\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1596638045;\n\tbh=VL7GCgYrtmbEzxo8f7ieyUhX44qfw5wZiA0ut1ifw5s=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=Ijr3ABucs9NyJ+tn9yxQgw5bBKqGgZI3sV2B/VqoA0lm6KdCkbwJIi9foXtDhNp95\n\tRlG872OoFupR8hTeCUBlXS357qPcEgw1c42bt/P7SEt3pYFaGgouPgLQfJzFNK+MAq\n\txvr8IKuloNt5vo57CQWhlMSKnWytgub3NTvXSSt0=","To":"Laurent Pinchart , =?utf-8?q?Niklas?=\n\t=?utf-8?q?_S=C3=B6derlund?= ","References":"<20200805125700.2254511-1-niklas.soderlund@ragnatech.se>\n\t<20200805142933.GG6751@pendragon.ideasonboard.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<1e5340ad-4431-3982-33f8-2f062da8638f@ideasonboard.com>","Date":"Wed, 5 Aug 2020 15:34:01 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20200805142933.GG6751@pendragon.ideasonboard.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH] libcamera: Add build time to version\n\tstring","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":11891,"web_url":"https://patchwork.libcamera.org/comment/11891/","msgid":"<20200805144705.GI6751@pendragon.ideasonboard.com>","date":"2020-08-05T14:47:05","subject":"Re: [libcamera-devel] [PATCH] libcamera: Add build time to version\n\tstring","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Wed, Aug 05, 2020 at 03:34:01PM +0100, Kieran Bingham wrote:\n> On 05/08/2020 15:29, Laurent Pinchart wrote:\n> > On Wed, Aug 05, 2020 at 02:57:00PM +0200, Niklas Söderlund wrote:\n> >> Having the build time in the version string is useful when building from\n> >> a dirty worktree and deploying to targets as a quick way to identify the\n> >> binary have been deployed successfully.\n> >>\n> >> Before this change the version string is reported as\n> >>\n> >> libcamera v0.0.0+1692-aaff196a-dirty\n> >>\n> >> While with this change the version string is reported as\n> >>\n> >> libcamera v0.0.0+1692-aaff196a-dirty 2020-08-05T12:55:11+00:00\n> >>\n> >> Signed-off-by: Niklas Söderlund \n> > \n> > This will get in the way of reproducible builds, especially for tagged\n> > releases. I would at least restrict this feature to dirty builds, and\n> > even then, I'll let Kieran comment on whether reproducible builds are\n> > important.\n> \n> I think I recall determining that reproducible builds were already\n> broken due to the way meson handles RPATH/RUNPATH.\n> \n> I too frequently use the version string to make sure I am running the\n> same code I expect, and having a build-time stamp in there (for debug)\n> builds would be quite nice.\n> \n> Restricting this to DEBUG builds might be quite nice, then release\n> builds from packagers just get a clean version.\n> \n> Adding only for release builds also removes any worries of reproducible\n> builds from the equation anyway ;-)\n\nWould adding a timestamp for dirty builds be more generic ? Presumably\nif the working tree is clean you don't need to differentiate between\ndifferent builds with the same commti sha1, as they should all be the\nsame :-)\n\n> >> ---\n> >> utils/gen-version.sh | 4 +++-\n> >> 1 file changed, 3 insertions(+), 1 deletion(-)\n> >>\n> >> diff --git a/utils/gen-version.sh b/utils/gen-version.sh\n> >> index 7f7872ceba7b038a..93bc97d6d8a8a24a 100755\n> >> --- a/utils/gen-version.sh\n> >> +++ b/utils/gen-version.sh\n> >> @@ -32,4 +32,6 @@ git diff-index --quiet HEAD || version=\"$version-dirty\"\n> >> # of the git SHA1 and remove the initial 'v'.\n> >> version=$(echo \"$version\" | sed -e 's/-/+/' | sed -e 's/-g/-/' | cut -c 2-)\n> >> \n> >> -echo \"$version\"\n> >> +buildtime=$(date --iso-8601=seconds --utc)\n> >> +\n> >> +echo \"$version $buildtime\"","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 670F8BD86F\n\tfor ;\n\tWed, 5 Aug 2020 14:47:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 332EA605A8;\n\tWed, 5 Aug 2020 16:47:19 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CEBC76039D\n\tfor ;\n\tWed, 5 Aug 2020 16:47:17 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 509C32C0;\n\tWed, 5 Aug 2020 16:47:17 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"tDBiWrQs\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1596638837;\n\tbh=dDxx9HDnADOZ/KWLrN4AvQtmpHCR4eIjPeBaPFcBIlU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=tDBiWrQs8yZEb5Pwx78jFHDhSzroXGgz3AzASDGqCnSH3o+N1GAj57QmbhFxqPGNO\n\td23CbrMvOFUyOPXnHtLNwlh+y7Of+csHpv4Yi4kkS0MXKykPeEuAmuzo0FVHY3sTVJ\n\tw7HKDEWk6dVJ05teKgPSwjXQa84oWNnWorWr4lfs=","Date":"Wed, 5 Aug 2020 17:47:05 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"<20200805144705.GI6751@pendragon.ideasonboard.com>","References":"<20200805125700.2254511-1-niklas.soderlund@ragnatech.se>\n\t<20200805142933.GG6751@pendragon.ideasonboard.com>\n\t<1e5340ad-4431-3982-33f8-2f062da8638f@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<1e5340ad-4431-3982-33f8-2f062da8638f@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: Add build time to version\n\tstring","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":11896,"web_url":"https://patchwork.libcamera.org/comment/11896/","msgid":"<20200805184148.GE2712616@oden.dyn.berto.se>","date":"2020-08-05T18:41:48","subject":"Re: [libcamera-devel] [PATCH] libcamera: Add build time to version\n\tstring","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi,\n\nOn 2020-08-05 17:47:05 +0300, Laurent Pinchart wrote:\n> Hi Kieran,\n> \n> On Wed, Aug 05, 2020 at 03:34:01PM +0100, Kieran Bingham wrote:\n> > On 05/08/2020 15:29, Laurent Pinchart wrote:\n> > > On Wed, Aug 05, 2020 at 02:57:00PM +0200, Niklas Söderlund wrote:\n> > >> Having the build time in the version string is useful when building from\n> > >> a dirty worktree and deploying to targets as a quick way to identify the\n> > >> binary have been deployed successfully.\n> > >>\n> > >> Before this change the version string is reported as\n> > >>\n> > >> libcamera v0.0.0+1692-aaff196a-dirty\n> > >>\n> > >> While with this change the version string is reported as\n> > >>\n> > >> libcamera v0.0.0+1692-aaff196a-dirty 2020-08-05T12:55:11+00:00\n> > >>\n> > >> Signed-off-by: Niklas Söderlund \n> > > \n> > > This will get in the way of reproducible builds, especially for tagged\n> > > releases. I would at least restrict this feature to dirty builds, and\n> > > even then, I'll let Kieran comment on whether reproducible builds are\n> > > important.\n> > \n> > I think I recall determining that reproducible builds were already\n> > broken due to the way meson handles RPATH/RUNPATH.\n> > \n> > I too frequently use the version string to make sure I am running the\n> > same code I expect, and having a build-time stamp in there (for debug)\n> > builds would be quite nice.\n> > \n> > Restricting this to DEBUG builds might be quite nice, then release\n> > builds from packagers just get a clean version.\n> > \n> > Adding only for release builds also removes any worries of reproducible\n> > builds from the equation anyway ;-)\n> \n> Would adding a timestamp for dirty builds be more generic ? Presumably\n> if the working tree is clean you don't need to differentiate between\n> different builds with the same commti sha1, as they should all be the\n> same :-)\n\nI like his, the timestamp is only really useful for dirty builds, will \nsend a v2.\n\n> \n> > >> ---\n> > >> utils/gen-version.sh | 4 +++-\n> > >> 1 file changed, 3 insertions(+), 1 deletion(-)\n> > >>\n> > >> diff --git a/utils/gen-version.sh b/utils/gen-version.sh\n> > >> index 7f7872ceba7b038a..93bc97d6d8a8a24a 100755\n> > >> --- a/utils/gen-version.sh\n> > >> +++ b/utils/gen-version.sh\n> > >> @@ -32,4 +32,6 @@ git diff-index --quiet HEAD || version=\"$version-dirty\"\n> > >> # of the git SHA1 and remove the initial 'v'.\n> > >> version=$(echo \"$version\" | sed -e 's/-/+/' | sed -e 's/-g/-/' | cut -c 2-)\n> > >> \n> > >> -echo \"$version\"\n> > >> +buildtime=$(date --iso-8601=seconds --utc)\n> > >> +\n> > >> +echo \"$version $buildtime\"\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 632E8BD87A\n\tfor ;\n\tWed, 5 Aug 2020 18:41:54 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E67CF605C0;\n\tWed, 5 Aug 2020 20:41:53 +0200 (CEST)","from mail-lj1-x241.google.com (mail-lj1-x241.google.com\n\t[IPv6:2a00:1450:4864:20::241])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A3B2260599\n\tfor ;\n\tWed, 5 Aug 2020 20:41:52 +0200 (CEST)","by mail-lj1-x241.google.com with SMTP id x9so48894529ljc.5\n\tfor ;\n\tWed, 05 Aug 2020 11:41:52 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\tm27sm1473815lfq.19.2020.08.05.11.41.48\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 05 Aug 2020 11:41:50 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"BICA1tkn\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=ZmWUFdV6DxsceFYsClqy8oO3qlbhInXM+3OwBFh6jPo=;\n\tb=BICA1tkn31TyU8AX5muGXZye6ySmYR+kHacNWjryRWTE71UsL/urmBwUHj5hhB9L65\n\tvf1zeHhHbgNnH7NYWamBNT6I1aNjyWx5rCrhMnYtZLqOa3MCA3FqWNuv8Hpe1FZiBEAx\n\toa0rDyXBGk0HUKMrK0Qpeo5S1Glul0gvXJ9lwdDQ89pAHlWuVerl0Y/pVdm/Iaz2MeHC\n\trrvDTNUNH25ImvcCAhQwao48hz0ehySK5kqEvpFS1FT7c82FMMD3CYMd0QgJ0NrzlTjE\n\tSIQ8wRDzM2C0kaOqBNB2Mk4+prkcn12hl6GO7Ovk0rFV4hpkWq1C4OOTX9xGSCXVvlGE\n\tqTCA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=ZmWUFdV6DxsceFYsClqy8oO3qlbhInXM+3OwBFh6jPo=;\n\tb=VFMvBuDSeNkrNKaoTjk6ZzqXSaDaPuB4I0YwFXfY2doplPA1y9AlpmaDID746tO6Yp\n\tkLOqb1M0gZlMptnmhyTfqD70QhwE1jllY7/l/4p3GxhtfbwRHkrLR551ykTW25I1lhCS\n\ttl8DhVCqPQsyCaGlnJdWKPf2gg3LWhPBuOxpYiX3oBy9SUJWc1F58IX7AKEAQOBpa0sF\n\tZCqo5mqf9su9LCEwtWpn7ZEfDeO/nUDj9LAPNJAluCq6kyLpOSwjCBySHjyyCrHs0K+z\n\tL/brlePEfGwniub9GXRenS+ZIeESZWLYXnvkoFn7rrZUxEL0ZjfY7nkjLAixfVny8zKI\n\tataA==","X-Gm-Message-State":"AOAM530wB37rm1MipyK6trrXHpPre5wTHRTVxBrb/u6+nW4lEkRIyo7Y\n\tnWDQ5oaAHUL9d4pS8vSzuz6FWObFeHA=","X-Google-Smtp-Source":"ABdhPJzKpUc1FUoHxsDC+RY8KKVcfdl5z9UxLmPYhVCYDX86/HKo91IBhsJsDyQCqI2RxN0gKRYSvA==","X-Received":"by 2002:a2e:7e0d:: with SMTP id z13mr2119090ljc.12.1596652911743;\n\tWed, 05 Aug 2020 11:41:51 -0700 (PDT)","Date":"Wed, 5 Aug 2020 20:41:48 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Message-ID":"<20200805184148.GE2712616@oden.dyn.berto.se>","References":"<20200805125700.2254511-1-niklas.soderlund@ragnatech.se>\n\t<20200805142933.GG6751@pendragon.ideasonboard.com>\n\t<1e5340ad-4431-3982-33f8-2f062da8638f@ideasonboard.com>\n\t<20200805144705.GI6751@pendragon.ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200805144705.GI6751@pendragon.ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: Add build time to version\n\tstring","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]