{"id":9222,"url":"https://patchwork.libcamera.org/api/patches/9222/?format=json","web_url":"https://patchwork.libcamera.org/patch/9222/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200805125343.116183-1-email@uajain.com>","date":"2020-08-05T12:53:49","name":"[libcamera-devel] android: camera_device: Initialize 'id_' field in constructor","commit_ref":"035ee23910233eabbdaed1469f3d329d66e0ead4","pull_url":null,"state":"accepted","archived":false,"hash":"ed5f51ff706d1406c58ae8f961ae5c735a8503c7","submitter":{"id":1,"url":"https://patchwork.libcamera.org/api/people/1/?format=json","name":"Umang Jain","email":"email@uajain.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/9222/mbox/","series":[{"id":1195,"url":"https://patchwork.libcamera.org/api/series/1195/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1195","date":"2020-08-05T12:53:49","name":"[libcamera-devel] android: camera_device: Initialize 'id_' field in constructor","version":1,"mbox":"https://patchwork.libcamera.org/series/1195/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/9222/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/9222/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C1E65BD87A\n\tfor ;\n\tWed, 5 Aug 2020 12:53:53 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3500F605A8;\n\tWed, 5 Aug 2020 14:53:53 +0200 (CEST)","from o1.f.az.sendgrid.net (o1.f.az.sendgrid.net [208.117.55.132])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6BB386039D\n\tfor ;\n\tWed, 5 Aug 2020 14:53:51 +0200 (CEST)","by filterdrecv-p3las1-559bd7b968-jcwlk with SMTP id\n\tfilterdrecv-p3las1-559bd7b968-jcwlk-20-5F2AABDD-6\n\t2020-08-05 12:53:49.138719059 +0000 UTC m=+585464.947727224","from mail.uajain.com (unknown)\n\tby ismtpd0001p1hnd1.sendgrid.net (SG) with ESMTP id\n\tmYpIEEhJTMmR21XjS_hyjA for ;\n\tWed, 05 Aug 2020 12:53:48.742 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=uajain.com header.i=@uajain.com\n\theader.b=\"pUeFh41Q\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=uajain.com;\n\th=from:subject:mime-version:to:cc:content-transfer-encoding:\n\tcontent-type;\n\ts=s1; bh=kvobH4AiFqw5kfUny/Y7QgPTeMqGgqZeV3uapVQD6AQ=;\n\tb=pUeFh41QZdG/JxPw4/LFQA9Gv7k3eWoCYJw9lcr/CBzK6mrjdiAbq0aSOVy8S/0WHn6H\n\tRGatZalMdRMLUj1hR/X3su7VXTVLqvU6gHD7j7qFvqQ6B/MPNOj0kxrdu8/miJvnURbfbF\n\tzeVH/dsA39DVW1G3+tuNhn3TzvWsJSh8o=","From":"Umang Jain ","Date":"Wed, 05 Aug 2020 12:53:49 +0000 (UTC)","Message-Id":"<20200805125343.116183-1-email@uajain.com>","Mime-Version":"1.0","X-SG-EID":"1Q40EQ7YGir8a9gjSIAdTjhngY657NMk9ckeo4dbHZDiOpywc/L3L9rFqlwE4KPcu2AmDZxpR9j2S9uUCg9Ys7IhJGIFuKZoi7yRKl0UwuNdPXF3ZXaaD5mrHJVqoTM/fqIJW3Q28o/hK/NXMvlnVjBhdTUo8DOSqb2BcPj2HSdjMIpvRBuhnFOYKKKP0BhrBdnvvTHmw9CLstgm7KHvilkNin2bfMbphHj56RWX7UboMwIQoMhTazRXyAs5Rii/BF5a4AybodHrBnazKDhNTg==","To":"libcamera-devel@lists.libcamera.org","Subject":"[libcamera-devel] [PATCH] android: camera_device: Initialize 'id_'\n\tfield in constructor","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"A 'id' is passed when a new CameraDevice is constructed in order for\nunique identification. Failing to initialize it, will lead to the\nissue of garbage return value via CameraDevice::id().\n\nSigned-off-by: Umang Jain \n---\n src/android/camera_device.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex c1e5812..55057f9 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -163,7 +163,7 @@ CameraDevice::Camera3RequestDescriptor::~Camera3RequestDescriptor()\n */\n \n CameraDevice::CameraDevice(unsigned int id, const std::shared_ptr &camera)\n-\t: running_(false), camera_(camera), staticMetadata_(nullptr),\n+\t: id_(id), running_(false), camera_(camera), staticMetadata_(nullptr),\n \t facing_(CAMERA_FACING_FRONT), orientation_(0)\n {\n \tcamera_->requestCompleted.connect(this, &CameraDevice::requestComplete);\n","prefixes":["libcamera-devel"]}