[{"id":11868,"web_url":"https://patchwork.libcamera.org/comment/11868/","msgid":"<20200805075143.zhz2ee2hfxdgx2gq@uno.localdomain>","date":"2020-08-05T07:51:43","subject":"Re: [libcamera-devel] [PATCH v3 07/13] android: camera_device:\n\tReport an error in notifyError()","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Kieran,\n sorry missed this in v2 review\n\nOn Tue, Aug 04, 2020 at 10:47:05PM +0100, Kieran Bingham wrote:\n> If an error is generated, try to be verbose about it in the libcamera logs.\n>\n> Reviewed-by: Niklas Söderlund \n> Reviewed-by: Laurent Pinchart \n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n>\n> ---\n> v2:\n> - Add todo to note possible debug info expansion\n> - Fix typo\n> - Print .toString() formatted pixel format\n>\n> v3:\n> - Remove colon from todo:\n> ---\n> src/android/camera_device.cpp | 7 +++++++\n> 1 file changed, 7 insertions(+)\n>\n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index 84d8c32a90c2..e4dce680d46f 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -1258,6 +1258,13 @@ void CameraDevice::notifyError(uint32_t frameNumber, camera3_stream_t *stream)\n> {\n> \tcamera3_notify_msg_t notify = {};\n>\n> +\t/*\n> +\t * \\todo Report and identify the stream number or configuration to\n> +\t * clarify the stream that failed.\n> +\t */\n> +\tLOG(HAL, Error) << \"Error occurred on frame \" << frameNumber << \" (\"\n> +\t\t\t<< toPixelFormat(stream->format).toString() << \")\";\n> +\n> \tnotify.type = CAMERA3_MSG_ERROR;\n> \tnotify.message.error.error_stream = stream;\n> \tnotify.message.error.frame_number = frameNumber;\n> --\n> 2.25.1\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2774DBD86F\n\tfor ;\n\tWed, 5 Aug 2020 07:48:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BA1306055E;\n\tWed, 5 Aug 2020 09:48:03 +0200 (CEST)","from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net\n\t[217.70.183.196])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 190E360554\n\tfor ;\n\tWed, 5 Aug 2020 09:48:03 +0200 (CEST)","from uno.localdomain (93-34-118-233.ip49.fastwebnet.it\n\t[93.34.118.233]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 891F8E000A;\n\tWed, 5 Aug 2020 07:48:02 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","Date":"Wed, 5 Aug 2020 09:51:43 +0200","From":"Jacopo Mondi ","To":"Kieran Bingham ","Message-ID":"<20200805075143.zhz2ee2hfxdgx2gq@uno.localdomain>","References":"<20200804214711.177645-1-kieran.bingham@ideasonboard.com>\n\t<20200804214711.177645-8-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200804214711.177645-8-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v3 07/13] android: camera_device:\n\tReport an error in notifyError()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]