[{"id":11846,"web_url":"https://patchwork.libcamera.org/comment/11846/","msgid":"<20200804185640.GM6075@pendragon.ideasonboard.com>","date":"2020-08-04T18:56:40","subject":"Re: [libcamera-devel] [PATCH v7 9/9] libcamera: camera_manager:\n\tEnforce unique camera IDs","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patch.\n\nOn Tue, Aug 04, 2020 at 06:13:58PM +0200, Niklas Söderlund wrote:\n> The camera ID is documented that it should be unique but it's not\n> enforced. Change this by refusing to add cameras to the CameraManager\n> that would create two cameras with the exact same ID.\n> \n> Signed-off-by: Niklas Söderlund \n> Reviewed-by: Jacopo Mondi \n> Reviewed-by: Kieran Bingham \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> * Changes since v5\n> - Rename 'name' to 'id'.\n> - Make error Fatal.\n> \n> * Changes since v4\n> - Update string in error message.\n> \n> * Changes since v3\n> - Update commit message.\n> ---\n> src/libcamera/camera_manager.cpp | 6 +++---\n> 1 file changed, 3 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp\n> index 76543b6aac8df9c4..47d56256abd6d490 100644\n> --- a/src/libcamera/camera_manager.cpp\n> +++ b/src/libcamera/camera_manager.cpp\n> @@ -182,10 +182,10 @@ void CameraManager::Private::addCamera(std::shared_ptr camera,\n> \n> \tfor (std::shared_ptr c : cameras_) {\n> \t\tif (c->id() == camera->id()) {\n> -\t\t\tLOG(Camera, Warning)\n> -\t\t\t\t<< \"Registering camera with duplicate ID '\"\n> +\t\t\tLOG(Camera, Fatal)\n> +\t\t\t\t<< \"Trying to register a camera with a duplicated ID '\"\n> \t\t\t\t<< camera->id() << \"'\";\n> -\t\t\tbreak;\n> +\t\t\treturn;\n> \t\t}\n> \t}\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0F0DEBD86F\n\tfor ;\n\tTue, 4 Aug 2020 18:56:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9C24F6054A;\n\tTue, 4 Aug 2020 20:56:57 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 63E7D60545\n\tfor ;\n\tTue, 4 Aug 2020 20:56:56 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5B4D527B;\n\tTue, 4 Aug 2020 20:56:52 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"EgLJ8vn4\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1596567412;\n\tbh=A7Hoyzl6+iG7Q55mrkzUfoDSmTPuIRH73xI8dvcNtvk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=EgLJ8vn4wUL6FA77tQSrmhArDRX/uzzyQYK2g7RO4+HXssPpd4nr8RPCsts4ACdua\n\ttF3HPpBWqevcgUXSET9d4H4lHyNJJHFHNG9/uixW248+6hQAM7oiBMfnNwJhzLXV3D\n\tzJi/R2a50zT00C/TBeWLJGOt2tRrwffqK619t0O8=","Date":"Tue, 4 Aug 2020 21:56:40 +0300","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Message-ID":"<20200804185640.GM6075@pendragon.ideasonboard.com>","References":"<20200804161358.1628962-1-niklas.soderlund@ragnatech.se>\n\t<20200804161358.1628962-10-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200804161358.1628962-10-niklas.soderlund@ragnatech.se>","Subject":"Re: [libcamera-devel] [PATCH v7 9/9] libcamera: camera_manager:\n\tEnforce unique camera IDs","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]