[{"id":11844,"web_url":"https://patchwork.libcamera.org/comment/11844/","msgid":"<20200804183159.GJ6075@pendragon.ideasonboard.com>","date":"2020-08-04T18:31:59","subject":"Re: [libcamera-devel] [PATCH v7 6/9] libcamera: pipelines: Use\n\tsensor ID as camera name","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patch.\n\nOn Tue, Aug 04, 2020 at 06:13:55PM +0200, Niklas Söderlund wrote:\n> Use the CameraSensor ID as the camera name in pipelines that uses a\n> CameraSensors, this is done in preparation of turning the camera name\n> into an ID. The CameraSensor ID meets the requirements that will be put\n> on camera ID.\n> \n> Before this change example of camera names:\n> \n> * OF based systems\n> ov5695 7-0036\n> ov2685 7-003c\n> \n> * ACPI based systems\n> ov13858 8-0010\n> ov5670 10-0036\n> \n> * VIMC\n> VIMC Sensor B\n> \n> After this change the same cameras are:\n> \n> * OF based systems\n> base/i2c@ff160000/camera@36\n> base/i2c@ff160000/camera@3c\n> \n> * ACPI based systems\n> \\_SB_.PCI0.I2C2.CAM0\n> \\_SB_.PCI0.I2C4.CAM1\n> \n> * VIMC\n> platform:vimc Sensor B\n> \n> Signed-off-by: Niklas Söderlund \n> ---\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 7 +++----\n> src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 3 ++-\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 2 +-\n> src/libcamera/pipeline/simple/simple.cpp | 2 +-\n> src/libcamera/pipeline/vimc/vimc.cpp | 4 ++--\n> test/camera/buffer_import.cpp | 2 +-\n> test/camera/capture.cpp | 2 +-\n> test/camera/configuration_default.cpp | 2 +-\n> test/camera/configuration_set.cpp | 2 +-\n> test/camera/statemachine.cpp | 2 +-\n> test/controls/control_info_map.cpp | 2 +-\n> test/controls/control_list.cpp | 2 +-\n> test/serialization/serialization_test.h | 2 +-\n> 13 files changed, 17 insertions(+), 17 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index c1f9fdf1013c7ec0..c300f570d727e03e 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -805,10 +805,9 @@ int PipelineHandlerIPU3::registerCameras()\n> \t\t\t\t\t&IPU3CameraData::imguOutputBufferReady);\n> \n> \t\t/* Create and register the Camera instance. */\n> -\t\tstd::string cameraName = cio2->sensor()->entity()->name();\n> -\t\tstd::shared_ptr camera = Camera::create(this,\n> -\t\t\t\t\t\t\t\tcameraName,\n> -\t\t\t\t\t\t\t\tstreams);\n> +\t\tstd::string cameraName = cio2->sensor()->id();\n\nI'd name the variable cameraId already, or rename it in 8/9.\n\n> +\t\tstd::shared_ptr camera =\n> +\t\t\tCamera::create(this, cameraName, streams);\n\nOr just\n\n\t\tstd::shared_ptr camera =\n\t\t\tCamera::create(this, cio2->sensor()->id(), streams);\n\nReviewed-by: Laurent Pinchart \n\n> \n> \t\tregisterCamera(std::move(camera), std::move(data));\n> \n> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> index 82a0a4dfd6824fce..c55d7325cd44d6cb 100644\n> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> @@ -972,7 +972,8 @@ bool PipelineHandlerRPi::match(DeviceEnumerator *enumerator)\n> \tstreams.insert(&data->isp_[Isp::Stats]);\n> \n> \t/* Create and register the camera. */\n> -\tstd::shared_ptr camera = Camera::create(this, data->sensor_->model(), streams);\n> +\tstd::shared_ptr camera =\n> +\t\tCamera::create(this, data->sensor_->id(), streams);\n> \tregisterCamera(std::move(camera), std::move(data));\n> \n> \treturn true;\n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> index 52a0d862417cc4ec..94561062c2b9d4fc 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> @@ -971,7 +971,7 @@ int PipelineHandlerRkISP1::createCamera(MediaEntity *sensor)\n> \n> \tstd::set streams{ &data->stream_ };\n> \tstd::shared_ptr camera =\n> -\t\tCamera::create(this, sensor->name(), streams);\n> +\t\tCamera::create(this, data->sensor_->id(), streams);\n> \tregisterCamera(std::move(camera), std::move(data));\n> \n> \treturn 0;\n> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n> index 0bab5af86f05d63c..eb72e3b8a2996342 100644\n> --- a/src/libcamera/pipeline/simple/simple.cpp\n> +++ b/src/libcamera/pipeline/simple/simple.cpp\n> @@ -815,7 +815,7 @@ bool SimplePipelineHandler::match(DeviceEnumerator *enumerator)\n> \t\t\tcontinue;\n> \n> \t\tstd::shared_ptr camera =\n> -\t\t\tCamera::create(this, data->sensor_->entity()->name(),\n> +\t\t\tCamera::create(this, data->sensor_->id(),\n> \t\t\t\t data->streams());\n> \t\tregisterCamera(std::move(camera), std::move(data));\n> \t}\n> diff --git a/src/libcamera/pipeline/vimc/vimc.cpp b/src/libcamera/pipeline/vimc/vimc.cpp\n> index 4f461b928514022d..cf244f11f2423dea 100644\n> --- a/src/libcamera/pipeline/vimc/vimc.cpp\n> +++ b/src/libcamera/pipeline/vimc/vimc.cpp\n> @@ -432,9 +432,9 @@ bool PipelineHandlerVimc::match(DeviceEnumerator *enumerator)\n> \t\treturn false;\n> \n> \t/* Create and register the camera. */\n> -\tstd::string name{ \"VIMC \" + data->sensor_->model() };\n> \tstd::set streams{ &data->stream_ };\n> -\tstd::shared_ptr camera = Camera::create(this, name, streams);\n> +\tstd::shared_ptr camera =\n> +\t\tCamera::create(this, data->sensor_->id(), streams);\n> \tregisterCamera(std::move(camera), std::move(data));\n> \n> \treturn true;\n> diff --git a/test/camera/buffer_import.cpp b/test/camera/buffer_import.cpp\n> index ad680a83f9187213..e8a7d1df52d3782c 100644\n> --- a/test/camera/buffer_import.cpp\n> +++ b/test/camera/buffer_import.cpp\n> @@ -28,7 +28,7 @@ class BufferImportTest : public CameraTest, public Test\n> {\n> public:\n> \tBufferImportTest()\n> -\t\t: CameraTest(\"VIMC Sensor B\")\n> +\t\t: CameraTest(\"platform:vimc Sensor B\")\n> \t{\n> \t}\n> \n> diff --git a/test/camera/capture.cpp b/test/camera/capture.cpp\n> index f6b2f348bda52752..d5ed6e72626cf87d 100644\n> --- a/test/camera/capture.cpp\n> +++ b/test/camera/capture.cpp\n> @@ -18,7 +18,7 @@ class Capture : public CameraTest, public Test\n> {\n> public:\n> \tCapture()\n> -\t\t: CameraTest(\"VIMC Sensor B\")\n> +\t\t: CameraTest(\"platform:vimc Sensor B\")\n> \t{\n> \t}\n> \n> diff --git a/test/camera/configuration_default.cpp b/test/camera/configuration_default.cpp\n> index 31c908d2449eafe7..ea97493d915fd107 100644\n> --- a/test/camera/configuration_default.cpp\n> +++ b/test/camera/configuration_default.cpp\n> @@ -18,7 +18,7 @@ class ConfigurationDefault : public CameraTest, public Test\n> {\n> public:\n> \tConfigurationDefault()\n> -\t\t: CameraTest(\"VIMC Sensor B\")\n> +\t\t: CameraTest(\"platform:vimc Sensor B\")\n> \t{\n> \t}\n> \n> diff --git a/test/camera/configuration_set.cpp b/test/camera/configuration_set.cpp\n> index b4b5968115e81f59..b1fa8fea2edd7683 100644\n> --- a/test/camera/configuration_set.cpp\n> +++ b/test/camera/configuration_set.cpp\n> @@ -18,7 +18,7 @@ class ConfigurationSet : public CameraTest, public Test\n> {\n> public:\n> \tConfigurationSet()\n> -\t\t: CameraTest(\"VIMC Sensor B\")\n> +\t\t: CameraTest(\"platform:vimc Sensor B\")\n> \t{\n> \t}\n> \n> diff --git a/test/camera/statemachine.cpp b/test/camera/statemachine.cpp\n> index 325b4674bcc958d8..0e7c43dd84399a5a 100644\n> --- a/test/camera/statemachine.cpp\n> +++ b/test/camera/statemachine.cpp\n> @@ -18,7 +18,7 @@ class Statemachine : public CameraTest, public Test\n> {\n> public:\n> \tStatemachine()\n> -\t\t: CameraTest(\"VIMC Sensor B\")\n> +\t\t: CameraTest(\"platform:vimc Sensor B\")\n> \t{\n> \t}\n> \n> diff --git a/test/controls/control_info_map.cpp b/test/controls/control_info_map.cpp\n> index e4305f132db7952f..72987646a63dab6b 100644\n> --- a/test/controls/control_info_map.cpp\n> +++ b/test/controls/control_info_map.cpp\n> @@ -24,7 +24,7 @@ class ControlInfoMapTest : public CameraTest, public Test\n> {\n> public:\n> \tControlInfoMapTest()\n> -\t\t: CameraTest(\"VIMC Sensor B\")\n> +\t\t: CameraTest(\"platform:vimc Sensor B\")\n> \t{\n> \t}\n> \n> diff --git a/test/controls/control_list.cpp b/test/controls/control_list.cpp\n> index 5c8485b5dcc31499..9a0fe53c022246f1 100644\n> --- a/test/controls/control_list.cpp\n> +++ b/test/controls/control_list.cpp\n> @@ -24,7 +24,7 @@ class ControlListTest : public CameraTest, public Test\n> {\n> public:\n> \tControlListTest()\n> -\t\t: CameraTest(\"VIMC Sensor B\")\n> +\t\t: CameraTest(\"platform:vimc Sensor B\")\n> \t{\n> \t}\n> \n> diff --git a/test/serialization/serialization_test.h b/test/serialization/serialization_test.h\n> index fe77221ef5d07478..5d4a6cd80a6e2208 100644\n> --- a/test/serialization/serialization_test.h\n> +++ b/test/serialization/serialization_test.h\n> @@ -20,7 +20,7 @@ class SerializationTest : public CameraTest, public Test\n> {\n> public:\n> \tSerializationTest()\n> -\t\t: CameraTest(\"VIMC Sensor B\")\n> +\t\t: CameraTest(\"platform:vimc Sensor B\")\n> \t{\n> \t}\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 64B10BD86F\n\tfor ;\n\tTue, 4 Aug 2020 18:32:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D610C60548;\n\tTue, 4 Aug 2020 20:32:13 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 487AC60545\n\tfor ;\n\tTue, 4 Aug 2020 20:32:13 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EE84827B;\n\tTue, 4 Aug 2020 20:32:10 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"c4XgFjuK\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1596565931;\n\tbh=RATVRlyDUV98+3srnIpFtIuz+htzru3NfCrukJIee6A=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=c4XgFjuK82YSgL4LWs1nUFEMeCcaHO226qYIPoqlSeKSR085Kog5R3ieFZERmE/9G\n\t+vW6r2awrUcSH0r/1PJpwCT0SpX7CgKnSFwWge6StVdj1lBk5oETKLZ+U3DOZuA5ho\n\t6vACVy6WKJBK/Tccjqz9n46oohnqAVAPEOXphpBw=","Date":"Tue, 4 Aug 2020 21:31:59 +0300","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Message-ID":"<20200804183159.GJ6075@pendragon.ideasonboard.com>","References":"<20200804161358.1628962-1-niklas.soderlund@ragnatech.se>\n\t<20200804161358.1628962-7-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200804161358.1628962-7-niklas.soderlund@ragnatech.se>","Subject":"Re: [libcamera-devel] [PATCH v7 6/9] libcamera: pipelines: Use\n\tsensor ID as camera name","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":11867,"web_url":"https://patchwork.libcamera.org/comment/11867/","msgid":"<20200805073236.oiheq7ived5rrnpc@uno.localdomain>","date":"2020-08-05T07:32:36","subject":"Re: [libcamera-devel] [PATCH v7 6/9] libcamera: pipelines: Use\n\tsensor ID as camera name","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Niklas,\n\nOn Tue, Aug 04, 2020 at 06:13:55PM +0200, Niklas Söderlund wrote:\n> Use the CameraSensor ID as the camera name in pipelines that uses a\n> CameraSensors, this is done in preparation of turning the camera name\n> into an ID. The CameraSensor ID meets the requirements that will be put\n> on camera ID.\n>\n> Before this change example of camera names:\n>\n> * OF based systems\n> ov5695 7-0036\n> ov2685 7-003c\n>\n> * ACPI based systems\n> ov13858 8-0010\n> ov5670 10-0036\n>\n> * VIMC\n> VIMC Sensor B\n>\n> After this change the same cameras are:\n>\n> * OF based systems\n> base/i2c@ff160000/camera@36\n> base/i2c@ff160000/camera@3c\n>\n> * ACPI based systems\n> \\_SB_.PCI0.I2C2.CAM0\n> \\_SB_.PCI0.I2C4.CAM1\n>\n> * VIMC\n> platform:vimc Sensor B\n>\n> Signed-off-by: Niklas Söderlund \n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 7 +++----\n> src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 3 ++-\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 2 +-\n> src/libcamera/pipeline/simple/simple.cpp | 2 +-\n> src/libcamera/pipeline/vimc/vimc.cpp | 4 ++--\n> test/camera/buffer_import.cpp | 2 +-\n> test/camera/capture.cpp | 2 +-\n> test/camera/configuration_default.cpp | 2 +-\n> test/camera/configuration_set.cpp | 2 +-\n> test/camera/statemachine.cpp | 2 +-\n> test/controls/control_info_map.cpp | 2 +-\n> test/controls/control_list.cpp | 2 +-\n> test/serialization/serialization_test.h | 2 +-\n> 13 files changed, 17 insertions(+), 17 deletions(-)\n>\n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index c1f9fdf1013c7ec0..c300f570d727e03e 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -805,10 +805,9 @@ int PipelineHandlerIPU3::registerCameras()\n> \t\t\t\t\t&IPU3CameraData::imguOutputBufferReady);\n>\n> \t\t/* Create and register the Camera instance. */\n> -\t\tstd::string cameraName = cio2->sensor()->entity()->name();\n> -\t\tstd::shared_ptr camera = Camera::create(this,\n> -\t\t\t\t\t\t\t\tcameraName,\n> -\t\t\t\t\t\t\t\tstreams);\n> +\t\tstd::string cameraName = cio2->sensor()->id();\n> +\t\tstd::shared_ptr camera =\n> +\t\t\tCamera::create(this, cameraName, streams);\n>\n> \t\tregisterCamera(std::move(camera), std::move(data));\n>\n> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> index 82a0a4dfd6824fce..c55d7325cd44d6cb 100644\n> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> @@ -972,7 +972,8 @@ bool PipelineHandlerRPi::match(DeviceEnumerator *enumerator)\n> \tstreams.insert(&data->isp_[Isp::Stats]);\n>\n> \t/* Create and register the camera. */\n> -\tstd::shared_ptr camera = Camera::create(this, data->sensor_->model(), streams);\n> +\tstd::shared_ptr camera =\n> +\t\tCamera::create(this, data->sensor_->id(), streams);\n> \tregisterCamera(std::move(camera), std::move(data));\n>\n> \treturn true;\n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> index 52a0d862417cc4ec..94561062c2b9d4fc 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> @@ -971,7 +971,7 @@ int PipelineHandlerRkISP1::createCamera(MediaEntity *sensor)\n>\n> \tstd::set streams{ &data->stream_ };\n> \tstd::shared_ptr camera =\n> -\t\tCamera::create(this, sensor->name(), streams);\n> +\t\tCamera::create(this, data->sensor_->id(), streams);\n> \tregisterCamera(std::move(camera), std::move(data));\n>\n> \treturn 0;\n> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n> index 0bab5af86f05d63c..eb72e3b8a2996342 100644\n> --- a/src/libcamera/pipeline/simple/simple.cpp\n> +++ b/src/libcamera/pipeline/simple/simple.cpp\n> @@ -815,7 +815,7 @@ bool SimplePipelineHandler::match(DeviceEnumerator *enumerator)\n> \t\t\tcontinue;\n>\n> \t\tstd::shared_ptr camera =\n> -\t\t\tCamera::create(this, data->sensor_->entity()->name(),\n> +\t\t\tCamera::create(this, data->sensor_->id(),\n> \t\t\t\t data->streams());\n> \t\tregisterCamera(std::move(camera), std::move(data));\n> \t}\n> diff --git a/src/libcamera/pipeline/vimc/vimc.cpp b/src/libcamera/pipeline/vimc/vimc.cpp\n> index 4f461b928514022d..cf244f11f2423dea 100644\n> --- a/src/libcamera/pipeline/vimc/vimc.cpp\n> +++ b/src/libcamera/pipeline/vimc/vimc.cpp\n> @@ -432,9 +432,9 @@ bool PipelineHandlerVimc::match(DeviceEnumerator *enumerator)\n> \t\treturn false;\n>\n> \t/* Create and register the camera. */\n> -\tstd::string name{ \"VIMC \" + data->sensor_->model() };\n> \tstd::set streams{ &data->stream_ };\n> -\tstd::shared_ptr camera = Camera::create(this, name, streams);\n> +\tstd::shared_ptr camera =\n> +\t\tCamera::create(this, data->sensor_->id(), streams);\n> \tregisterCamera(std::move(camera), std::move(data));\n>\n> \treturn true;\n> diff --git a/test/camera/buffer_import.cpp b/test/camera/buffer_import.cpp\n> index ad680a83f9187213..e8a7d1df52d3782c 100644\n> --- a/test/camera/buffer_import.cpp\n> +++ b/test/camera/buffer_import.cpp\n> @@ -28,7 +28,7 @@ class BufferImportTest : public CameraTest, public Test\n> {\n> public:\n> \tBufferImportTest()\n> -\t\t: CameraTest(\"VIMC Sensor B\")\n> +\t\t: CameraTest(\"platform:vimc Sensor B\")\n> \t{\n> \t}\n>\n> diff --git a/test/camera/capture.cpp b/test/camera/capture.cpp\n> index f6b2f348bda52752..d5ed6e72626cf87d 100644\n> --- a/test/camera/capture.cpp\n> +++ b/test/camera/capture.cpp\n> @@ -18,7 +18,7 @@ class Capture : public CameraTest, public Test\n> {\n> public:\n> \tCapture()\n> -\t\t: CameraTest(\"VIMC Sensor B\")\n> +\t\t: CameraTest(\"platform:vimc Sensor B\")\n> \t{\n> \t}\n>\n> diff --git a/test/camera/configuration_default.cpp b/test/camera/configuration_default.cpp\n> index 31c908d2449eafe7..ea97493d915fd107 100644\n> --- a/test/camera/configuration_default.cpp\n> +++ b/test/camera/configuration_default.cpp\n> @@ -18,7 +18,7 @@ class ConfigurationDefault : public CameraTest, public Test\n> {\n> public:\n> \tConfigurationDefault()\n> -\t\t: CameraTest(\"VIMC Sensor B\")\n> +\t\t: CameraTest(\"platform:vimc Sensor B\")\n> \t{\n> \t}\n>\n> diff --git a/test/camera/configuration_set.cpp b/test/camera/configuration_set.cpp\n> index b4b5968115e81f59..b1fa8fea2edd7683 100644\n> --- a/test/camera/configuration_set.cpp\n> +++ b/test/camera/configuration_set.cpp\n> @@ -18,7 +18,7 @@ class ConfigurationSet : public CameraTest, public Test\n> {\n> public:\n> \tConfigurationSet()\n> -\t\t: CameraTest(\"VIMC Sensor B\")\n> +\t\t: CameraTest(\"platform:vimc Sensor B\")\n> \t{\n> \t}\n>\n> diff --git a/test/camera/statemachine.cpp b/test/camera/statemachine.cpp\n> index 325b4674bcc958d8..0e7c43dd84399a5a 100644\n> --- a/test/camera/statemachine.cpp\n> +++ b/test/camera/statemachine.cpp\n> @@ -18,7 +18,7 @@ class Statemachine : public CameraTest, public Test\n> {\n> public:\n> \tStatemachine()\n> -\t\t: CameraTest(\"VIMC Sensor B\")\n> +\t\t: CameraTest(\"platform:vimc Sensor B\")\n> \t{\n> \t}\n>\n> diff --git a/test/controls/control_info_map.cpp b/test/controls/control_info_map.cpp\n> index e4305f132db7952f..72987646a63dab6b 100644\n> --- a/test/controls/control_info_map.cpp\n> +++ b/test/controls/control_info_map.cpp\n> @@ -24,7 +24,7 @@ class ControlInfoMapTest : public CameraTest, public Test\n> {\n> public:\n> \tControlInfoMapTest()\n> -\t\t: CameraTest(\"VIMC Sensor B\")\n> +\t\t: CameraTest(\"platform:vimc Sensor B\")\n> \t{\n> \t}\n>\n> diff --git a/test/controls/control_list.cpp b/test/controls/control_list.cpp\n> index 5c8485b5dcc31499..9a0fe53c022246f1 100644\n> --- a/test/controls/control_list.cpp\n> +++ b/test/controls/control_list.cpp\n> @@ -24,7 +24,7 @@ class ControlListTest : public CameraTest, public Test\n> {\n> public:\n> \tControlListTest()\n> -\t\t: CameraTest(\"VIMC Sensor B\")\n> +\t\t: CameraTest(\"platform:vimc Sensor B\")\n> \t{\n> \t}\n>\n> diff --git a/test/serialization/serialization_test.h b/test/serialization/serialization_test.h\n> index fe77221ef5d07478..5d4a6cd80a6e2208 100644\n> --- a/test/serialization/serialization_test.h\n> +++ b/test/serialization/serialization_test.h\n> @@ -20,7 +20,7 @@ class SerializationTest : public CameraTest, public Test\n> {\n> public:\n> \tSerializationTest()\n> -\t\t: CameraTest(\"VIMC Sensor B\")\n> +\t\t: CameraTest(\"platform:vimc Sensor B\")\n> \t{\n> \t}\n>\n> --\n> 2.28.0\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8DFACBD87A\n\tfor ;\n\tWed, 5 Aug 2020 07:28:56 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2F5ED6055E;\n\tWed, 5 Aug 2020 09:28:56 +0200 (CEST)","from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net\n\t[217.70.183.198])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B074760554\n\tfor ;\n\tWed, 5 Aug 2020 09:28:55 +0200 (CEST)","from uno.localdomain (93-34-118-233.ip49.fastwebnet.it\n\t[93.34.118.233]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 25E4BC0009;\n\tWed, 5 Aug 2020 07:28:54 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","Date":"Wed, 5 Aug 2020 09:32:36 +0200","From":"Jacopo Mondi ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Message-ID":"<20200805073236.oiheq7ived5rrnpc@uno.localdomain>","References":"<20200804161358.1628962-1-niklas.soderlund@ragnatech.se>\n\t<20200804161358.1628962-7-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200804161358.1628962-7-niklas.soderlund@ragnatech.se>","Subject":"Re: [libcamera-devel] [PATCH v7 6/9] libcamera: pipelines: Use\n\tsensor ID as camera name","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]