[{"id":11843,"web_url":"https://patchwork.libcamera.org/comment/11843/","msgid":"<20200804182409.GI6075@pendragon.ideasonboard.com>","date":"2020-08-04T18:24:09","subject":"Re: [libcamera-devel] [PATCH v7 5/9] libcamera: camera_sensor: Add\n\taccessors for sensor ID","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patch.\n\nOn Tue, Aug 04, 2020 at 06:13:54PM +0200, Niklas Söderlund wrote:\n> Add an accessors so that the sensor ID can be used outside CameraSensor.\n> \n> Signed-off-by: Niklas Söderlund \n\nI think you could squash it with 4/9.\n\nReviewed-by: Laurent Pinchart \n\n> ---\n> include/libcamera/internal/camera_sensor.h | 1 +\n> src/libcamera/camera_sensor.cpp | 10 ++++++++++\n> 2 files changed, 11 insertions(+)\n> \n> diff --git a/include/libcamera/internal/camera_sensor.h b/include/libcamera/internal/camera_sensor.h\n> index 0f65fca46877e89a..b9eba89f00fba882 100644\n> --- a/include/libcamera/internal/camera_sensor.h\n> +++ b/include/libcamera/internal/camera_sensor.h\n> @@ -47,6 +47,7 @@ public:\n> \tint init();\n> \n> \tconst std::string &model() const { return model_; }\n> +\tconst std::string &id() const { return id_; }\n> \tconst MediaEntity *entity() const { return entity_; }\n> \tconst std::vector &mbusCodes() const { return mbusCodes_; }\n> \tconst std::vector &sizes() const { return sizes_; }\n> diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\n> index 3952d16b053ae20e..157e1d34a03a4a8e 100644\n> --- a/src/libcamera/camera_sensor.cpp\n> +++ b/src/libcamera/camera_sensor.cpp\n> @@ -291,6 +291,16 @@ int CameraSensor::init()\n> * \\return The sensor model name\n> */\n> \n> +/**\n> + * \\fn CameraSensor::id()\n> + * \\brief Retrieve the sensor ID\n> + *\n> + * The sensor ID is a free-form string that uniquely identifies the sensor in\n> + * the system. The ID satisfy the requirements to be used as a camera ID.\n> + *\n> + * \\return The sensor ID\n> + */\n> +\n> /**\n> * \\fn CameraSensor::entity()\n> * \\brief Retrieve the sensor media entity","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6A0F7BD87A\n\tfor ;\n\tTue, 4 Aug 2020 18:24:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0141660547;\n\tTue, 4 Aug 2020 20:24:23 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7183760545\n\tfor ;\n\tTue, 4 Aug 2020 20:24:21 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E041E27B;\n\tTue, 4 Aug 2020 20:24:20 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"KBMRL8Lq\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1596565461;\n\tbh=y0MkWdjYmInTu4Pw5SG/1UmqaUsaTdHKNlH8SanlsIY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=KBMRL8LqetBA60szgc24eRilEgZVukayA0FFiMtrTU0CCEoid/Bh8TzOSNB7lSGpm\n\tUqs0YFpboJUpgxNHVLZt4UumGJZg8GasjXHR5uhet38/Uw1iebwR1FGiSKLY9T2vqh\n\tlWXPk9g0fSkXrF+LKGWqoZwx0hWsGgumTP9KgOYA=","Date":"Tue, 4 Aug 2020 21:24:09 +0300","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Message-ID":"<20200804182409.GI6075@pendragon.ideasonboard.com>","References":"<20200804161358.1628962-1-niklas.soderlund@ragnatech.se>\n\t<20200804161358.1628962-6-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200804161358.1628962-6-niklas.soderlund@ragnatech.se>","Subject":"Re: [libcamera-devel] [PATCH v7 5/9] libcamera: camera_sensor: Add\n\taccessors for sensor ID","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":11866,"web_url":"https://patchwork.libcamera.org/comment/11866/","msgid":"<20200805072945.c2ucm7beq2p5ublj@uno.localdomain>","date":"2020-08-05T07:29:45","subject":"Re: [libcamera-devel] [PATCH v7 5/9] libcamera: camera_sensor: Add\n\taccessors for sensor ID","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Niklas, Laurent,\n\nOn Tue, Aug 04, 2020 at 09:24:09PM +0300, Laurent Pinchart wrote:\n> Hi Niklas,\n>\n> Thank you for the patch.\n>\n> On Tue, Aug 04, 2020 at 06:13:54PM +0200, Niklas Söderlund wrote:\n> > Add an accessors so that the sensor ID can be used outside CameraSensor.\n> >\n> > Signed-off-by: Niklas Söderlund \n>\n> I think you could squash it with 4/9.\n>\n\nI pointed out to Niklas in v6 review that those two were actually two\nchanges. I know Niklas likes smaller patches, I was trying to make him\nhappier :D\n\n> Reviewed-by: Laurent Pinchart \n>\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> > ---\n> > include/libcamera/internal/camera_sensor.h | 1 +\n> > src/libcamera/camera_sensor.cpp | 10 ++++++++++\n> > 2 files changed, 11 insertions(+)\n> >\n> > diff --git a/include/libcamera/internal/camera_sensor.h b/include/libcamera/internal/camera_sensor.h\n> > index 0f65fca46877e89a..b9eba89f00fba882 100644\n> > --- a/include/libcamera/internal/camera_sensor.h\n> > +++ b/include/libcamera/internal/camera_sensor.h\n> > @@ -47,6 +47,7 @@ public:\n> > \tint init();\n> >\n> > \tconst std::string &model() const { return model_; }\n> > +\tconst std::string &id() const { return id_; }\n> > \tconst MediaEntity *entity() const { return entity_; }\n> > \tconst std::vector &mbusCodes() const { return mbusCodes_; }\n> > \tconst std::vector &sizes() const { return sizes_; }\n> > diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\n> > index 3952d16b053ae20e..157e1d34a03a4a8e 100644\n> > --- a/src/libcamera/camera_sensor.cpp\n> > +++ b/src/libcamera/camera_sensor.cpp\n> > @@ -291,6 +291,16 @@ int CameraSensor::init()\n> > * \\return The sensor model name\n> > */\n> >\n> > +/**\n> > + * \\fn CameraSensor::id()\n> > + * \\brief Retrieve the sensor ID\n> > + *\n> > + * The sensor ID is a free-form string that uniquely identifies the sensor in\n> > + * the system. The ID satisfy the requirements to be used as a camera ID.\n> > + *\n> > + * \\return The sensor ID\n> > + */\n> > +\n> > /**\n> > * \\fn CameraSensor::entity()\n> > * \\brief Retrieve the sensor media entity\n>\n> --\n> Regards,\n>\n> Laurent Pinchart\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EE943BD87A\n\tfor ;\n\tWed, 5 Aug 2020 07:26:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C898560555;\n\tWed, 5 Aug 2020 09:26:06 +0200 (CEST)","from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net\n\t[217.70.183.196])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BDD9D60554\n\tfor ;\n\tWed, 5 Aug 2020 09:26:04 +0200 (CEST)","from uno.localdomain (93-34-118-233.ip49.fastwebnet.it\n\t[93.34.118.233]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 14B54E000A;\n\tWed, 5 Aug 2020 07:26:03 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","Date":"Wed, 5 Aug 2020 09:29:45 +0200","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Message-ID":"<20200805072945.c2ucm7beq2p5ublj@uno.localdomain>","References":"<20200804161358.1628962-1-niklas.soderlund@ragnatech.se>\n\t<20200804161358.1628962-6-niklas.soderlund@ragnatech.se>\n\t<20200804182409.GI6075@pendragon.ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200804182409.GI6075@pendragon.ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v7 5/9] libcamera: camera_sensor: Add\n\taccessors for sensor ID","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":11871,"web_url":"https://patchwork.libcamera.org/comment/11871/","msgid":"<20200805092512.GB2712616@oden.dyn.berto.se>","date":"2020-08-05T09:25:12","subject":"Re: [libcamera-devel] [PATCH v7 5/9] libcamera: camera_sensor: Add\n\taccessors for sensor ID","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"On 2020-08-05 09:29:45 +0200, Jacopo Mondi wrote:\n> Hi Niklas, Laurent,\n> \n> On Tue, Aug 04, 2020 at 09:24:09PM +0300, Laurent Pinchart wrote:\n> > Hi Niklas,\n> >\n> > Thank you for the patch.\n> >\n> > On Tue, Aug 04, 2020 at 06:13:54PM +0200, Niklas Söderlund wrote:\n> > > Add an accessors so that the sensor ID can be used outside CameraSensor.\n> > >\n> > > Signed-off-by: Niklas Söderlund \n> >\n> > I think you could squash it with 4/9.\n> >\n> \n> I pointed out to Niklas in v6 review that those two were actually two\n> changes. I know Niklas likes smaller patches, I was trying to make him\n> happier :D\n\nAnd I thank you for it :-)\n\n> \n> > Reviewed-by: Laurent Pinchart \n> >\n> \n> Reviewed-by: Jacopo Mondi \n> \n> Thanks\n> j\n> \n> > > ---\n> > > include/libcamera/internal/camera_sensor.h | 1 +\n> > > src/libcamera/camera_sensor.cpp | 10 ++++++++++\n> > > 2 files changed, 11 insertions(+)\n> > >\n> > > diff --git a/include/libcamera/internal/camera_sensor.h b/include/libcamera/internal/camera_sensor.h\n> > > index 0f65fca46877e89a..b9eba89f00fba882 100644\n> > > --- a/include/libcamera/internal/camera_sensor.h\n> > > +++ b/include/libcamera/internal/camera_sensor.h\n> > > @@ -47,6 +47,7 @@ public:\n> > > \tint init();\n> > >\n> > > \tconst std::string &model() const { return model_; }\n> > > +\tconst std::string &id() const { return id_; }\n> > > \tconst MediaEntity *entity() const { return entity_; }\n> > > \tconst std::vector &mbusCodes() const { return mbusCodes_; }\n> > > \tconst std::vector &sizes() const { return sizes_; }\n> > > diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\n> > > index 3952d16b053ae20e..157e1d34a03a4a8e 100644\n> > > --- a/src/libcamera/camera_sensor.cpp\n> > > +++ b/src/libcamera/camera_sensor.cpp\n> > > @@ -291,6 +291,16 @@ int CameraSensor::init()\n> > > * \\return The sensor model name\n> > > */\n> > >\n> > > +/**\n> > > + * \\fn CameraSensor::id()\n> > > + * \\brief Retrieve the sensor ID\n> > > + *\n> > > + * The sensor ID is a free-form string that uniquely identifies the sensor in\n> > > + * the system. The ID satisfy the requirements to be used as a camera ID.\n> > > + *\n> > > + * \\return The sensor ID\n> > > + */\n> > > +\n> > > /**\n> > > * \\fn CameraSensor::entity()\n> > > * \\brief Retrieve the sensor media entity\n> >\n> > --\n> > Regards,\n> >\n> > Laurent Pinchart\n> > _______________________________________________\n> > libcamera-devel mailing list\n> > libcamera-devel@lists.libcamera.org\n> > https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4712BBD87A\n\tfor ;\n\tWed, 5 Aug 2020 09:25:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B86AB6055E;\n\tWed, 5 Aug 2020 11:25:14 +0200 (CEST)","from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com\n\t[IPv6:2a00:1450:4864:20::22d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CD85C60554\n\tfor ;\n\tWed, 5 Aug 2020 11:25:13 +0200 (CEST)","by mail-lj1-x22d.google.com with SMTP id h19so46865863ljg.13\n\tfor ;\n\tWed, 05 Aug 2020 02:25:13 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\tm142sm845618lfa.47.2020.08.05.02.25.12\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 05 Aug 2020 02:25:12 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"lnDIc7Ru\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=fPERpfv24T/hcgWkmG0SxkYPEWd0Tvh5fEV0ejYn6g8=;\n\tb=lnDIc7RuoFp0Sp5iNwnihMTMnqST2OUOTlL4vAvtFZ1nLbuQOh2PCxVjcd8KBKja/v\n\tAYrHBwvkbVdaW+z2tqt062jeNnZuZYVKypi9fdzQ+PCtAOjGoafRSdIkB8zs3d2g/UeC\n\tOJGJTJHsdSrBTjQmGejhb/OHETJdydzciLcJ9MM9BVaiKLWV5/EcHo1/mrpTBqTsCveb\n\tMjmF32KmBnSc2rX9jQmhYv8do+aMw38fxtIvidQ4mkcJi7rkF1wlzPxF5Mo+e3jvvdD5\n\tNBY65PVwK4tc1wgfkM6IZGL+MdZBu+P9yVlmyLe7u1Kd7Alj67STP9ag0rimKrNSdwsy\n\tc45A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=fPERpfv24T/hcgWkmG0SxkYPEWd0Tvh5fEV0ejYn6g8=;\n\tb=oGnPn0u0naBUVgvcU/cJCySZ5FAmssAQnfsF18q8wx6OPLa5/5J8l+8pIn5gBAeQsL\n\tCH+KUxtjoDPpmj5HMmb01X+kURCZDjJNyP/cRAr019/92jbbYrf/OnV6YR69ZhKW7+j7\n\tuuT6sKG9e5/4VeSjDk11Qm4ledYhTwe8Fx+9GEiRlULvljTb0edUuDA8J9aBSV0lGzTb\n\tP9r+Zr3SB0QO+6xOyZql+ZeovSmhC2m5AzQnioux4cfjb/E8YvA++BLHt6qxgwIAWVTO\n\tRGpiYIucKUAyVr0lR6N5PXmi8HsuQeIXrJzh81AvK5+Qqf6xmd0qFeeDOnp5fLfyF1Bq\n\tefmQ==","X-Gm-Message-State":"AOAM530+C3LrCN6PeMwawGPbZ1SHRMDi1wxGdnKiF3I7lBh5foKkMPdP\n\tqJ/8Vdg/yuh805fePKHvuSLhKSvFJZI=","X-Google-Smtp-Source":"ABdhPJzQaAPs4u2jCQVCalmVuqcP3bxjl/tq6C9I05h0ZoQ63MTHln/2O3YtNq7OVLZmKkcNjksmUQ==","X-Received":"by 2002:a2e:1417:: with SMTP id u23mr1090750ljd.44.1596619513091;\n\tWed, 05 Aug 2020 02:25:13 -0700 (PDT)","Date":"Wed, 5 Aug 2020 11:25:12 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Jacopo Mondi ","Message-ID":"<20200805092512.GB2712616@oden.dyn.berto.se>","References":"<20200804161358.1628962-1-niklas.soderlund@ragnatech.se>\n\t<20200804161358.1628962-6-niklas.soderlund@ragnatech.se>\n\t<20200804182409.GI6075@pendragon.ideasonboard.com>\n\t<20200805072945.c2ucm7beq2p5ublj@uno.localdomain>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200805072945.c2ucm7beq2p5ublj@uno.localdomain>","Subject":"Re: [libcamera-devel] [PATCH v7 5/9] libcamera: camera_sensor: Add\n\taccessors for sensor ID","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]