[{"id":11842,"web_url":"https://patchwork.libcamera.org/comment/11842/","msgid":"<20200804182212.GH6075@pendragon.ideasonboard.com>","date":"2020-08-04T18:22:12","subject":"Re: [libcamera-devel] [PATCH v7 4/9] libcamera: camera_sensor:\n\tGenerate a sensor ID","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patch.\n\nOn Tue, Aug 04, 2020 at 06:13:53PM +0200, Niklas Söderlund wrote:\n> The ID is generated from information in the firmware description of the\n> sensor if available or from module and model information if the sensor\n> is virtual (for example VIMC).\n> \n> Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n> ---\n> * Changes sinve v6\n> - Do not allow for subclassing\n> - Add support for virtual sensors\n> - Use new sysfs:: helper.\n> \n> * Changes since v5\n> - Use new utils:: helper.\n> - Allow for subclassing\n> \n> * Changes since v4\n> - Fix spelling.\n> \n> * Changes since v3\n> - Update commit message.\n> - Add description of how ID are generated to comment.\n> ---\n>  include/libcamera/internal/camera_sensor.h |  3 ++\n>  src/libcamera/camera_sensor.cpp            | 38 ++++++++++++++++++++++\n>  2 files changed, 41 insertions(+)\n> \n> diff --git a/include/libcamera/internal/camera_sensor.h b/include/libcamera/internal/camera_sensor.h\n> index 06c8292ca30129de..0f65fca46877e89a 100644\n> --- a/include/libcamera/internal/camera_sensor.h\n> +++ b/include/libcamera/internal/camera_sensor.h\n> @@ -67,11 +67,14 @@ protected:\n>  \tstd::string logPrefix() const override;\n>  \n>  private:\n> +\tint generateId();\n> +\n>  \tconst MediaEntity *entity_;\n>  \tstd::unique_ptr<V4L2Subdevice> subdev_;\n>  \tunsigned int pad_;\n>  \n>  \tstd::string model_;\n> +\tstd::string id_;\n>  \n>  \tV4L2Subdevice::Formats formats_;\n>  \tSize resolution_;\n> diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\n> index 350f49accad99c7b..3952d16b053ae20e 100644\n> --- a/src/libcamera/camera_sensor.cpp\n> +++ b/src/libcamera/camera_sensor.cpp\n> @@ -9,6 +9,7 @@\n>  \n>  #include <algorithm>\n>  #include <float.h>\n> +#include <fstream>\n>  #include <iomanip>\n>  #include <limits.h>\n>  #include <math.h>\n> @@ -16,7 +17,9 @@\n>  \n>  #include <libcamera/property_ids.h>\n>  \n> +#include \"libcamera/internal/file.h\"\n>  #include \"libcamera/internal/formats.h\"\n> +#include \"libcamera/internal/sysfs.h\"\n>  #include \"libcamera/internal/utils.h\"\n>  \n>  /**\n> @@ -204,6 +207,11 @@ int CameraSensor::init()\n>  \tif (ret < 0)\n>  \t\treturn ret;\n>  \n> +\t/* Generate a unique ID for the sensor. */\n> +\tret = generateId();\n> +\tif (ret)\n> +\t\treturn ret;\n> +\n>  \t/* Retrieve and store the camera sensor properties. */\n>  \tconst ControlInfoMap &controls = subdev_->controls();\n>  \tint32_t propertyValue;\n> @@ -541,4 +549,34 @@ std::string CameraSensor::logPrefix() const\n>  \treturn \"'\" + entity_->name() + \"'\";\n>  }\n>  \n> +int CameraSensor::generateId()\n> +{\n> +\tconst std::string devPath = subdev_->devicePath();\n> +\n> +\t/* Try to get ID from firmware description. */\n> +\tif (!sysfs::firmwareId(devPath, &id_))\n> +\t\treturn 0;\n> +\n> +\t/* Virtual sensors not described in firmware, use modalias and model. */\n> +\tstd::string path = devPath + \"/modalias\";\n> +\tif (File::exists(path)) {\n> +\t\tstd::ifstream file(path.c_str());\n> +\n> +\t\tif (!file.is_open()) {\n> +\t\t\tLOG(CameraSensor, Error) << \"Failed to read modalias\";\n> +\t\t\treturn -EINVAL;\n> +\t\t}\n> +\n> +\t\tstd::string modalias;\n> +\t\tstd::getline(file, modalias);\n> +\t\tfile.close();\n> +\n> +\t\tid_ = modalias + \" \" + model();\n> +\t\treturn 0;\n> +\t}\n> +\n> +\tLOG(CameraSensor, Error) << \"Can't generate sensor ID\";\n> +\treturn -EINVAL;\n> +}\n> +\n>  } /* namespace libcamera */","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E6EABBD87A\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue,  4 Aug 2020 18:22:26 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8004960547;\n\tTue,  4 Aug 2020 20:22:26 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1403D60545\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue,  4 Aug 2020 20:22:25 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 82EA427B;\n\tTue,  4 Aug 2020 20:22:24 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"cyglgSsj\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1596565344;\n\tbh=UnC5QsEu+Es+592x5TygPShccK4aDlIa0RXm5b8ngOs=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=cyglgSsj/62OVAyyP6J63mbDLnhQTFooYXz2xPztbr6RIMTzsgAriesEq7CCN+4PE\n\tbqNM1w9j4RYlJQKaidBloM5d4eHD7hLBKgkiTRWyq9K4xwIcGRBK/mPrvPRFEKPByo\n\tnLRW8dZ1QnliLmmVFNVH7o91u2S91alsbwbWP03g=","Date":"Tue, 4 Aug 2020 21:22:12 +0300","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Niklas =?utf-8?q?S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>","Message-ID":"<20200804182212.GH6075@pendragon.ideasonboard.com>","References":"<20200804161358.1628962-1-niklas.soderlund@ragnatech.se>\n\t<20200804161358.1628962-5-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200804161358.1628962-5-niklas.soderlund@ragnatech.se>","Subject":"Re: [libcamera-devel] [PATCH v7 4/9] libcamera: camera_sensor:\n\tGenerate a sensor ID","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":11849,"web_url":"https://patchwork.libcamera.org/comment/11849/","msgid":"<20200804195118.GP6075@pendragon.ideasonboard.com>","date":"2020-08-04T19:51:18","subject":"Re: [libcamera-devel] [PATCH v7 4/9] libcamera: camera_sensor:\n\tGenerate a sensor ID","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nAnother comment I'm afraid.\n\nOn Tue, Aug 04, 2020 at 09:22:12PM +0300, Laurent Pinchart wrote:\n> Hi Niklas,\n> \n> Thank you for the patch.\n> \n> On Tue, Aug 04, 2020 at 06:13:53PM +0200, Niklas Söderlund wrote:\n> > The ID is generated from information in the firmware description of the\n> > sensor if available or from module and model information if the sensor\n> > is virtual (for example VIMC).\n> > \n> > Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n> \n> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> \n> > ---\n> > * Changes sinve v6\n> > - Do not allow for subclassing\n> > - Add support for virtual sensors\n> > - Use new sysfs:: helper.\n> > \n> > * Changes since v5\n> > - Use new utils:: helper.\n> > - Allow for subclassing\n> > \n> > * Changes since v4\n> > - Fix spelling.\n> > \n> > * Changes since v3\n> > - Update commit message.\n> > - Add description of how ID are generated to comment.\n> > ---\n> >  include/libcamera/internal/camera_sensor.h |  3 ++\n> >  src/libcamera/camera_sensor.cpp            | 38 ++++++++++++++++++++++\n> >  2 files changed, 41 insertions(+)\n> > \n> > diff --git a/include/libcamera/internal/camera_sensor.h b/include/libcamera/internal/camera_sensor.h\n> > index 06c8292ca30129de..0f65fca46877e89a 100644\n> > --- a/include/libcamera/internal/camera_sensor.h\n> > +++ b/include/libcamera/internal/camera_sensor.h\n> > @@ -67,11 +67,14 @@ protected:\n> >  \tstd::string logPrefix() const override;\n> >  \n> >  private:\n> > +\tint generateId();\n> > +\n> >  \tconst MediaEntity *entity_;\n> >  \tstd::unique_ptr<V4L2Subdevice> subdev_;\n> >  \tunsigned int pad_;\n> >  \n> >  \tstd::string model_;\n> > +\tstd::string id_;\n> >  \n> >  \tV4L2Subdevice::Formats formats_;\n> >  \tSize resolution_;\n> > diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\n> > index 350f49accad99c7b..3952d16b053ae20e 100644\n> > --- a/src/libcamera/camera_sensor.cpp\n> > +++ b/src/libcamera/camera_sensor.cpp\n> > @@ -9,6 +9,7 @@\n> >  \n> >  #include <algorithm>\n> >  #include <float.h>\n> > +#include <fstream>\n> >  #include <iomanip>\n> >  #include <limits.h>\n> >  #include <math.h>\n> > @@ -16,7 +17,9 @@\n> >  \n> >  #include <libcamera/property_ids.h>\n> >  \n> > +#include \"libcamera/internal/file.h\"\n> >  #include \"libcamera/internal/formats.h\"\n> > +#include \"libcamera/internal/sysfs.h\"\n> >  #include \"libcamera/internal/utils.h\"\n> >  \n> >  /**\n> > @@ -204,6 +207,11 @@ int CameraSensor::init()\n> >  \tif (ret < 0)\n> >  \t\treturn ret;\n> >  \n> > +\t/* Generate a unique ID for the sensor. */\n> > +\tret = generateId();\n> > +\tif (ret)\n> > +\t\treturn ret;\n> > +\n> >  \t/* Retrieve and store the camera sensor properties. */\n> >  \tconst ControlInfoMap &controls = subdev_->controls();\n> >  \tint32_t propertyValue;\n> > @@ -541,4 +549,34 @@ std::string CameraSensor::logPrefix() const\n> >  \treturn \"'\" + entity_->name() + \"'\";\n> >  }\n> >  \n> > +int CameraSensor::generateId()\n> > +{\n> > +\tconst std::string devPath = subdev_->devicePath();\n> > +\n> > +\t/* Try to get ID from firmware description. */\n> > +\tif (!sysfs::firmwareId(devPath, &id_))\n> > +\t\treturn 0;\n> > +\n> > +\t/* Virtual sensors not described in firmware, use modalias and model. */\n> > +\tstd::string path = devPath + \"/modalias\";\n> > +\tif (File::exists(path)) {\n> > +\t\tstd::ifstream file(path.c_str());\n> > +\n> > +\t\tif (!file.is_open()) {\n> > +\t\t\tLOG(CameraSensor, Error) << \"Failed to read modalias\";\n> > +\t\t\treturn -EINVAL;\n> > +\t\t}\n> > +\n> > +\t\tstd::string modalias;\n> > +\t\tstd::getline(file, modalias);\n> > +\t\tfile.close();\n> > +\n> > +\t\tid_ = modalias + \" \" + model();\n> > +\t\treturn 0;\n> > +\t}\n\nThis won't generate a unique name if the same driver handles multiple\ndevices. Would it make sense to instead use devPath stripped of the\n/sys/devices/ prefix ? That would return platform/vimc.0 for vimc for\ninstance. If you want to restrict this to platform devices, you could\nfurther check that the ID starts with platform/.\n\n> > +\n> > +\tLOG(CameraSensor, Error) << \"Can't generate sensor ID\";\n> > +\treturn -EINVAL;\n> > +}\n> > +\n> >  } /* namespace libcamera */","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 94AADBD87A\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue,  4 Aug 2020 19:51:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2FF0260547;\n\tTue,  4 Aug 2020 21:51:32 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F33A260545\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue,  4 Aug 2020 21:51:30 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 67AEB27B;\n\tTue,  4 Aug 2020 21:51:30 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"MKBjFp2h\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1596570690;\n\tbh=vF+ko/lhxztRgZHswKWlJwLhhqEpRsptNfV5siJ2cQ0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=MKBjFp2hLslwXgocV9C1BwNG16I7AY8YDXwwtWnGX46XQyvaio2iorxXZDF9hMJ/L\n\tLqwD/0T4751lqg8V4MaiJVkNmnWjwwkC7gNhS6WZuTo0xfTh5YdV/1X9f6I66yHl3g\n\terzanzPSXt1ROtguAQ0wlhlZaC5hGkAvD9pm0u7g=","Date":"Tue, 4 Aug 2020 22:51:18 +0300","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Niklas =?utf-8?q?S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>","Message-ID":"<20200804195118.GP6075@pendragon.ideasonboard.com>","References":"<20200804161358.1628962-1-niklas.soderlund@ragnatech.se>\n\t<20200804161358.1628962-5-niklas.soderlund@ragnatech.se>\n\t<20200804182212.GH6075@pendragon.ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200804182212.GH6075@pendragon.ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v7 4/9] libcamera: camera_sensor:\n\tGenerate a sensor ID","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":11865,"web_url":"https://patchwork.libcamera.org/comment/11865/","msgid":"<20200805072815.euddlusmuixspf2s@uno.localdomain>","date":"2020-08-05T07:28:15","subject":"Re: [libcamera-devel] [PATCH v7 4/9] libcamera: camera_sensor:\n\tGenerate a sensor ID","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Niklas,\n\nOn Tue, Aug 04, 2020 at 06:13:53PM +0200, Niklas Söderlund wrote:\n> The ID is generated from information in the firmware description of the\n> sensor if available or from module and model information if the sensor\n> is virtual (for example VIMC).\n>\n> Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n\nReviewed-by: Jacopo Mondi <jacopo@jmondi.org>\n\nThanks\n  j\n\n> ---\n> * Changes sinve v6\n> - Do not allow for subclassing\n> - Add support for virtual sensors\n> - Use new sysfs:: helper.\n>\n> * Changes since v5\n> - Use new utils:: helper.\n> - Allow for subclassing\n>\n> * Changes since v4\n> - Fix spelling.\n>\n> * Changes since v3\n> - Update commit message.\n> - Add description of how ID are generated to comment.\n> ---\n>  include/libcamera/internal/camera_sensor.h |  3 ++\n>  src/libcamera/camera_sensor.cpp            | 38 ++++++++++++++++++++++\n>  2 files changed, 41 insertions(+)\n>\n> diff --git a/include/libcamera/internal/camera_sensor.h b/include/libcamera/internal/camera_sensor.h\n> index 06c8292ca30129de..0f65fca46877e89a 100644\n> --- a/include/libcamera/internal/camera_sensor.h\n> +++ b/include/libcamera/internal/camera_sensor.h\n> @@ -67,11 +67,14 @@ protected:\n>  \tstd::string logPrefix() const override;\n>\n>  private:\n> +\tint generateId();\n> +\n>  \tconst MediaEntity *entity_;\n>  \tstd::unique_ptr<V4L2Subdevice> subdev_;\n>  \tunsigned int pad_;\n>\n>  \tstd::string model_;\n> +\tstd::string id_;\n>\n>  \tV4L2Subdevice::Formats formats_;\n>  \tSize resolution_;\n> diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\n> index 350f49accad99c7b..3952d16b053ae20e 100644\n> --- a/src/libcamera/camera_sensor.cpp\n> +++ b/src/libcamera/camera_sensor.cpp\n> @@ -9,6 +9,7 @@\n>\n>  #include <algorithm>\n>  #include <float.h>\n> +#include <fstream>\n>  #include <iomanip>\n>  #include <limits.h>\n>  #include <math.h>\n> @@ -16,7 +17,9 @@\n>\n>  #include <libcamera/property_ids.h>\n>\n> +#include \"libcamera/internal/file.h\"\n>  #include \"libcamera/internal/formats.h\"\n> +#include \"libcamera/internal/sysfs.h\"\n>  #include \"libcamera/internal/utils.h\"\n>\n>  /**\n> @@ -204,6 +207,11 @@ int CameraSensor::init()\n>  \tif (ret < 0)\n>  \t\treturn ret;\n>\n> +\t/* Generate a unique ID for the sensor. */\n> +\tret = generateId();\n> +\tif (ret)\n> +\t\treturn ret;\n> +\n>  \t/* Retrieve and store the camera sensor properties. */\n>  \tconst ControlInfoMap &controls = subdev_->controls();\n>  \tint32_t propertyValue;\n> @@ -541,4 +549,34 @@ std::string CameraSensor::logPrefix() const\n>  \treturn \"'\" + entity_->name() + \"'\";\n>  }\n>\n> +int CameraSensor::generateId()\n> +{\n> +\tconst std::string devPath = subdev_->devicePath();\n> +\n> +\t/* Try to get ID from firmware description. */\n> +\tif (!sysfs::firmwareId(devPath, &id_))\n> +\t\treturn 0;\n> +\n> +\t/* Virtual sensors not described in firmware, use modalias and model. */\n> +\tstd::string path = devPath + \"/modalias\";\n> +\tif (File::exists(path)) {\n> +\t\tstd::ifstream file(path.c_str());\n> +\n> +\t\tif (!file.is_open()) {\n> +\t\t\tLOG(CameraSensor, Error) << \"Failed to read modalias\";\n> +\t\t\treturn -EINVAL;\n> +\t\t}\n> +\n> +\t\tstd::string modalias;\n> +\t\tstd::getline(file, modalias);\n> +\t\tfile.close();\n> +\n> +\t\tid_ = modalias + \" \" + model();\n> +\t\treturn 0;\n> +\t}\n> +\n> +\tLOG(CameraSensor, Error) << \"Can't generate sensor ID\";\n> +\treturn -EINVAL;\n> +}\n> +\n>  } /* namespace libcamera */\n> --\n> 2.28.0\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BA245BD86F\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed,  5 Aug 2020 07:24:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 59E2560579;\n\tWed,  5 Aug 2020 09:24:36 +0200 (CEST)","from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net\n\t[217.70.183.194])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A2FBF60554\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed,  5 Aug 2020 09:24:34 +0200 (CEST)","from uno.localdomain (93-34-118-233.ip49.fastwebnet.it\n\t[93.34.118.233]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 2941C4000E;\n\tWed,  5 Aug 2020 07:24:33 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","Date":"Wed, 5 Aug 2020 09:28:15 +0200","From":"Jacopo Mondi <jacopo@jmondi.org>","To":"Niklas =?utf-8?q?S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>","Message-ID":"<20200805072815.euddlusmuixspf2s@uno.localdomain>","References":"<20200804161358.1628962-1-niklas.soderlund@ragnatech.se>\n\t<20200804161358.1628962-5-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200804161358.1628962-5-niklas.soderlund@ragnatech.se>","Subject":"Re: [libcamera-devel] [PATCH v7 4/9] libcamera: camera_sensor:\n\tGenerate a sensor ID","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]