{"id":9182,"url":"https://patchwork.libcamera.org/api/patches/9182/?format=json","web_url":"https://patchwork.libcamera.org/patch/9182/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200804122755.30743-1-email@uajain.com>","date":"2020-08-04T12:28:01","name":"[libcamera-devel,1/2] android: camera_hal_manager: Remove unused getStaticMetadata() method","commit_ref":"aea5ace7c3f40450094fdc9ec66cadc9465eea4c","pull_url":null,"state":"accepted","archived":false,"hash":"d1ce4a58ef740508043f575c068847b69a52002b","submitter":{"id":1,"url":"https://patchwork.libcamera.org/api/people/1/?format=json","name":"Umang Jain","email":"email@uajain.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/9182/mbox/","series":[{"id":1189,"url":"https://patchwork.libcamera.org/api/series/1189/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1189","date":"2020-08-04T12:28:01","name":"[libcamera-devel,1/2] android: camera_hal_manager: Remove unused getStaticMetadata() method","version":1,"mbox":"https://patchwork.libcamera.org/series/1189/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/9182/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/9182/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6CB31BD87A\n\tfor ;\n\tTue, 4 Aug 2020 12:28:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C2CB16054B;\n\tTue, 4 Aug 2020 14:28:06 +0200 (CEST)","from o1.f.az.sendgrid.net (o1.f.az.sendgrid.net [208.117.55.132])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DB85C6048E\n\tfor ;\n\tTue, 4 Aug 2020 14:28:03 +0200 (CEST)","by filterdrecv-p3iad2-canary-6b67849fb4-tmzt8 with SMTP id\n\tfilterdrecv-p3iad2-canary-6b67849fb4-tmzt8-19-5F295451-3A\n\t2020-08-04 12:28:01.652502455 +0000 UTC m=+501624.283563418","from mail.uajain.com (unknown)\n\tby ismtpd0006p1hnd1.sendgrid.net (SG) with ESMTP id\n\tFe8DgdyXSxyTBcd5vFLkbw for ;\n\tTue, 04 Aug 2020 12:28:01.183 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=uajain.com header.i=@uajain.com\n\theader.b=\"oxJGFaDA\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=uajain.com;\n\th=from:subject:mime-version:to:cc:content-transfer-encoding:\n\tcontent-type;\n\ts=s1; bh=B1OfbPaQqfLIH6IYQqGl5BhGqmREUJTqU4uG59EYp28=;\n\tb=oxJGFaDAyXzSWCj3C65ptyFeRq2VG+3CTXht9NtGDVH0wTsslEWMO2i1dRFGiAZ7kqBB\n\thoel94aK06lSdsKSJvg4DhD6lDjtS7EMqjgcsBSKpPFISTgTwCq5geYiN1ODZoErvoSt5E\n\txcHpZnV2W/88jywznRjdZZMQSRRuTFOKM=","From":"Umang Jain ","Date":"Tue, 04 Aug 2020 12:28:01 +0000 (UTC)","Message-Id":"<20200804122755.30743-1-email@uajain.com>","Mime-Version":"1.0","X-SG-EID":"1Q40EQ7YGir8a9gjSIAdTjhngY657NMk9ckeo4dbHZDiOpywc/L3L9rFqlwE4KPcQmPzxg2d8HRoKJI5HeDXchhGDjLfhUuVkmkf8jM22WoLu8Qkq0URLwJDCkJtWzV/9yqGRE6pbc8ol9FFT6hEn17Ms3xgcERq96K1SfEYU3Ak0D+kqLrue9AgigW6J5McGAcxmlXC+yIyEhvb6LTDHkskAocjf0i4P6DmFiKdssiLwwrA6d6oqiiQifY1vh+NFlkay/tPzt98MrpGDbIK8D7AFPQtMcaSiZgejK9Y89I=","To":"libcamera-devel@lists.libcamera.org","Subject":"[libcamera-devel] [PATCH 1/2] android: camera_hal_manager: Remove\n\tunused getStaticMetadata() method","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The CameraHalManager::getStaticMethod() method isn't used, remove it.\n\nSigned-off-by: Umang Jain \n---\n src/android/camera_hal_manager.h | 2 --\n 1 file changed, 2 deletions(-)","diff":"diff --git a/src/android/camera_hal_manager.h b/src/android/camera_hal_manager.h\nindex 94d8f00..0619037 100644\n--- a/src/android/camera_hal_manager.h\n+++ b/src/android/camera_hal_manager.h\n@@ -31,8 +31,6 @@ public:\n \tint getCameraInfo(unsigned int id, struct camera_info *info);\n \n private:\n-\tcamera_metadata_t *getStaticMetadata(unsigned int id);\n-\n \tlibcamera::CameraManager *cameraManager_;\n \n \tstd::vector> cameras_;\n","prefixes":["libcamera-devel","1/2"]}