[{"id":1266,"web_url":"https://patchwork.libcamera.org/comment/1266/","msgid":"<30d197df-49e0-0429-253d-40b14c37c3d9@ideasonboard.com>","date":"2019-04-05T04:28:21","subject":"Re: [libcamera-devel] [PATCH v2 4/8] libcamera: Make geometry.h a\n\tpublic header","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patch,\n\nOn 05/04/2019 09:02, Niklas Söderlund wrote:\n> Make the geometry header public so it can be used by the API facing\n> applications.\n\nThis sounds like a reasonable move, and looks clean.\n\nReviewed-by: Kieran Bingham \n\n> Signed-off-by: Niklas Söderlund \n> ---\n> {src/libcamera/include => include/libcamera}/geometry.h | 0\n> src/libcamera/geometry.cpp | 2 +-\n> src/libcamera/include/formats.h | 2 +-\n> src/libcamera/include/v4l2_subdevice.h | 3 ++-\n> src/libcamera/v4l2_subdevice.cpp | 3 ++-\n> test/v4l2_subdevice/list_formats.cpp | 3 ++-\n> 6 files changed, 8 insertions(+), 5 deletions(-)\n> rename {src/libcamera/include => include/libcamera}/geometry.h (100%)\n> \n> diff --git a/src/libcamera/include/geometry.h b/include/libcamera/geometry.h\n> similarity index 100%\n> rename from src/libcamera/include/geometry.h\n> rename to include/libcamera/geometry.h\n> diff --git a/src/libcamera/geometry.cpp b/src/libcamera/geometry.cpp\n> index d0c63c353ab3fc0b..d63eceaf827b99a4 100644\n> --- a/src/libcamera/geometry.cpp\n> +++ b/src/libcamera/geometry.cpp\n> @@ -7,7 +7,7 @@\n> \n> #include \n> \n> -#include \"geometry.h\"\n> +#include \n> \n> /**\n> * \\file geometry.h\n> diff --git a/src/libcamera/include/formats.h b/src/libcamera/include/formats.h\n> index 5fcfb11318e749d1..a73772b1eda068b4 100644\n> --- a/src/libcamera/include/formats.h\n> +++ b/src/libcamera/include/formats.h\n> @@ -11,7 +11,7 @@\n> #include \n> #include \n> \n> -#include \"geometry.h\"\n> +#include \n> \n> namespace libcamera {\n> \n> diff --git a/src/libcamera/include/v4l2_subdevice.h b/src/libcamera/include/v4l2_subdevice.h\n> index ee7c72468d21b83b..c71dce7d864494e5 100644\n> --- a/src/libcamera/include/v4l2_subdevice.h\n> +++ b/src/libcamera/include/v4l2_subdevice.h\n> @@ -11,8 +11,9 @@\n> #include \n> #include \n> \n> +#include \n> +\n> #include \"formats.h\"\n> -#include \"geometry.h\"\n> #include \"log.h\"\n> #include \"media_object.h\"\n> \n> diff --git a/src/libcamera/v4l2_subdevice.cpp b/src/libcamera/v4l2_subdevice.cpp\n> index 0abeaa204eda465b..e34cc1693b46b374 100644\n> --- a/src/libcamera/v4l2_subdevice.cpp\n> +++ b/src/libcamera/v4l2_subdevice.cpp\n> @@ -14,7 +14,8 @@\n> \n> #include \n> \n> -#include \"geometry.h\"\n> +#include \n> +\n> #include \"log.h\"\n> #include \"media_device.h\"\n> #include \"media_object.h\"\n> diff --git a/test/v4l2_subdevice/list_formats.cpp b/test/v4l2_subdevice/list_formats.cpp\n> index db486554b7b5c6a9..47ae3a1c1a28c350 100644\n> --- a/test/v4l2_subdevice/list_formats.cpp\n> +++ b/test/v4l2_subdevice/list_formats.cpp\n> @@ -9,7 +9,8 @@\n> #include \n> #include \n> \n> -#include \"geometry.h\"\n> +#include \n> +\n> #include \"v4l2_subdevice.h\"\n> #include \"v4l2_subdevice_test.h\"\n> \n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CF227610BF\n\tfor ;\n\tFri, 5 Apr 2019 06:28:29 +0200 (CEST)","from [10.71.13.128] (unknown [147.50.13.10])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 38C5A255;\n\tFri, 5 Apr 2019 06:28:27 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1554438509;\n\tbh=etGVw9yAYZtFI1qRDRObm/4MyVoZ76eeiczBb8xE8P8=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=WtnYdC+D221jCPfDg2zow3uGPkx6Nlf/CsDjZCxhk0wKPo1vV+vtIPrXb9re2HwrE\n\tlDKUQmKEr8TP50Qt4ox4C7uoNGVdYLkQXMwpNv2mvJRRrIodS3KBbDPwlFi/LTmWJS\n\tTXq3ViBQbZjN+Qq5UhmsJusG7WQ1uI1eT6U7rVzs=","Reply-To":"kieran.bingham@ideasonboard.com","To":"=?utf-8?q?Niklas_S=C3=B6derlund?= ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20190405020256.22520-1-niklas.soderlund@ragnatech.se>\n\t<20190405020256.22520-5-niklas.soderlund@ragnatech.se>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAkAEEwEKACoCGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEFAlnDk/gFCQeA/YsACgkQoR5GchCkYf3X5w/9EaZ7\n\tcnUcT6dxjxrcmmMnfFPoQA1iQXr/MXQJBjFWfxRUWYzjvUJb2D/FpA8FY7y+vksoJP7pWDL7\n\tQTbksdwzagUEk7CU45iLWL/CZ/knYhj1I/+5LSLFmvZ/5Gf5xn2ZCsmg7C0MdW/GbJ8IjWA8\n\t/LKJSEYH8tefoiG6+9xSNp1p0Gesu3vhje/GdGX4wDsfAxx1rIYDYVoX4bDM+uBUQh7sQox/\n\tR1bS0AaVJzPNcjeC14MS226mQRUaUPc9250aj44WmDfcg44/kMsoLFEmQo2II9aOlxUDJ+x1\n\txohGbh9mgBoVawMO3RMBihcEjo/8ytW6v7xSF+xP4Oc+HOn7qebAkxhSWcRxQVaQYw3S9iZz\n\t2iA09AXAkbvPKuMSXi4uau5daXStfBnmOfalG0j+9Y6hOFjz5j0XzaoF6Pln0jisDtWltYhP\n\tX9LjFVhhLkTzPZB/xOeWGmsG4gv2V2ExbU3uAmb7t1VSD9+IO3Km4FtnYOKBWlxwEd8qOFpS\n\tjEqMXURKOiJvnw3OXe9MqG19XdeENA1KyhK5rqjpwdvPGfSn2V+SlsdJA0DFsobUScD9qXQw\n\tOvhapHe3XboK2+Rd7L+g/9Ud7ZKLQHAsMBXOVJbufA1AT+IaOt0ugMcFkAR5UbBg5+dZUYJj\n\t1QbPQcGmM3wfvuaWV5+SlJ+WeKIb8ta5Ag0EVgT9ZgEQAM4o5G/kmruIQJ3K9SYzmPishRHV\n\tDcUcvoakyXSX2mIoccmo9BHtD9MxIt+QmxOpYFNFM7YofX4lG0ld8H7FqoNVLd/+a0yru5Cx\n\tadeZBe3qr1eLns10Q90LuMo7/6zJhCW2w+HE7xgmCHejAwuNe3+7yt4QmwlSGUqdxl8cgtS1\n\tPlEK93xXDsgsJj/bw1EfSVdAUqhx8UQ3aVFxNug5OpoX9FdWJLKROUrfNeBE16RLrNrq2ROc\n\tiSFETpVjyC/oZtzRFnwD9Or7EFMi76/xrWzk+/b15RJ9WrpXGMrttHUUcYZEOoiC2lEXMSAF\n\tSSSj4vHbKDJ0vKQdEFtdgB1roqzxdIOg4rlHz5qwOTynueiBpaZI3PHDudZSMR5Fk6QjFooE\n\tXTw3sSl/km/lvUFiv9CYyHOLdygWohvDuMkV/Jpdkfq8XwFSjOle+vT/4VqERnYFDIGBxaRx\n\tkoBLfNDiiuR3lD8tnJ4A1F88K6ojOUs+jndKsOaQpDZV6iNFv8IaNIklTPvPkZsmNDhJMRHH\n\tIu60S7BpzNeQeT4yyY4dX9lC2JL/LOEpw8DGf5BNOP1KgjCvyp1/KcFxDAo89IeqljaRsCdP\n\t7WCIECWYem6pLwaw6IAL7oX+tEqIMPph/G/jwZcdS6Hkyt/esHPuHNwX4guqTbVEuRqbDzDI\n\t2DJO5FbxABEBAAGJAiUEGAEKAA8CGwwFAlnDlGsFCQeA/gIACgkQoR5GchCkYf1yYRAAq+Yo\n\tnbf9DGdK1kTAm2RTFg+w9oOp2Xjqfhds2PAhFFvrHQg1XfQR/UF/SjeUmaOmLSczM0s6XMeO\n\tVcE77UFtJ/+hLo4PRFKm5X1Pcar6g5m4xGqa+Xfzi9tRkwC29KMCoQOag1BhHChgqYaUH3yo\n\tUzaPwT/fY75iVI+yD0ih/e6j8qYvP8pvGwMQfrmN9YB0zB39YzCSdaUaNrWGD3iCBxg6lwSO\n\tLKeRhxxfiXCIYEf3vwOsP3YMx2JkD5doseXmWBGW1U0T/oJF+DVfKB6mv5UfsTzpVhJRgee7\n\t4jkjqFq4qsUGxcvF2xtRkfHFpZDbRgRlVmiWkqDkT4qMA+4q1y/dWwshSKi/uwVZNycuLsz+\n\t+OD8xPNCsMTqeUkAKfbD8xW4LCay3r/dD2ckoxRxtMD9eOAyu5wYzo/ydIPTh1QEj9SYyvp8\n\tO0g6CpxEwyHUQtF5oh15O018z3ZLztFJKR3RD42VKVsrnNDKnoY0f4U0z7eJv2NeF8xHMuiU\n\tRCIzqxX1GVYaNkKTnb/Qja8hnYnkUzY1Lc+OtwiGmXTwYsPZjjAaDX35J/RSKAoy5wGo/YFA\n\tJxB1gWThL4kOTbsqqXj9GLcyOImkW0lJGGR3o/fV91Zh63S5TKnf2YGGGzxki+ADdxVQAm+Q\n\tsbsRB8KNNvVXBOVNwko86rQqF9drZuw=","Organization":"Ideas on Board","Message-ID":"<30d197df-49e0-0429-253d-40b14c37c3d9@ideasonboard.com>","Date":"Fri, 5 Apr 2019 11:28:21 +0700","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.5.1","MIME-Version":"1.0","In-Reply-To":"<20190405020256.22520-5-niklas.soderlund@ragnatech.se>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH v2 4/8] libcamera: Make geometry.h a\n\tpublic header","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 05 Apr 2019 04:28:30 -0000"}},{"id":1267,"web_url":"https://patchwork.libcamera.org/comment/1267/","msgid":"<20190405081704.tdfhlhla2h7wbtor@uno.localdomain>","date":"2019-04-05T08:17:04","subject":"Re: [libcamera-devel] [PATCH v2 4/8] libcamera: Make geometry.h a\n\tpublic header","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Niklas,\n\nOn Fri, Apr 05, 2019 at 04:02:52AM +0200, Niklas Söderlund wrote:\n> Make the geometry header public so it can be used by the API facing\n> applications.\n\nI welcome this change and the order of inclusion directives seems sane\nto me.\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n>\n> Signed-off-by: Niklas Söderlund \n> ---\n> {src/libcamera/include => include/libcamera}/geometry.h | 0\n> src/libcamera/geometry.cpp | 2 +-\n> src/libcamera/include/formats.h | 2 +-\n> src/libcamera/include/v4l2_subdevice.h | 3 ++-\n> src/libcamera/v4l2_subdevice.cpp | 3 ++-\n> test/v4l2_subdevice/list_formats.cpp | 3 ++-\n> 6 files changed, 8 insertions(+), 5 deletions(-)\n> rename {src/libcamera/include => include/libcamera}/geometry.h (100%)\n>\n> diff --git a/src/libcamera/include/geometry.h b/include/libcamera/geometry.h\n> similarity index 100%\n> rename from src/libcamera/include/geometry.h\n> rename to include/libcamera/geometry.h\n> diff --git a/src/libcamera/geometry.cpp b/src/libcamera/geometry.cpp\n> index d0c63c353ab3fc0b..d63eceaf827b99a4 100644\n> --- a/src/libcamera/geometry.cpp\n> +++ b/src/libcamera/geometry.cpp\n> @@ -7,7 +7,7 @@\n>\n> #include \n>\n> -#include \"geometry.h\"\n> +#include \n>\n> /**\n> * \\file geometry.h\n> diff --git a/src/libcamera/include/formats.h b/src/libcamera/include/formats.h\n> index 5fcfb11318e749d1..a73772b1eda068b4 100644\n> --- a/src/libcamera/include/formats.h\n> +++ b/src/libcamera/include/formats.h\n> @@ -11,7 +11,7 @@\n> #include \n> #include \n>\n> -#include \"geometry.h\"\n> +#include \n>\n> namespace libcamera {\n>\n> diff --git a/src/libcamera/include/v4l2_subdevice.h b/src/libcamera/include/v4l2_subdevice.h\n> index ee7c72468d21b83b..c71dce7d864494e5 100644\n> --- a/src/libcamera/include/v4l2_subdevice.h\n> +++ b/src/libcamera/include/v4l2_subdevice.h\n> @@ -11,8 +11,9 @@\n> #include \n> #include \n>\n> +#include \n> +\n> #include \"formats.h\"\n> -#include \"geometry.h\"\n> #include \"log.h\"\n> #include \"media_object.h\"\n>\n> diff --git a/src/libcamera/v4l2_subdevice.cpp b/src/libcamera/v4l2_subdevice.cpp\n> index 0abeaa204eda465b..e34cc1693b46b374 100644\n> --- a/src/libcamera/v4l2_subdevice.cpp\n> +++ b/src/libcamera/v4l2_subdevice.cpp\n> @@ -14,7 +14,8 @@\n>\n> #include \n>\n> -#include \"geometry.h\"\n> +#include \n> +\n> #include \"log.h\"\n> #include \"media_device.h\"\n> #include \"media_object.h\"\n> diff --git a/test/v4l2_subdevice/list_formats.cpp b/test/v4l2_subdevice/list_formats.cpp\n> index db486554b7b5c6a9..47ae3a1c1a28c350 100644\n> --- a/test/v4l2_subdevice/list_formats.cpp\n> +++ b/test/v4l2_subdevice/list_formats.cpp\n> @@ -9,7 +9,8 @@\n> #include \n> #include \n>\n> -#include \"geometry.h\"\n> +#include \n> +\n> #include \"v4l2_subdevice.h\"\n> #include \"v4l2_subdevice_test.h\"\n>\n> --\n> 2.21.0\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net\n\t[217.70.183.193])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8A95760DB2\n\tfor ;\n\tFri, 5 Apr 2019 10:16:24 +0200 (CEST)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 08B16240034;\n\tFri, 5 Apr 2019 08:16:22 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","Date":"Fri, 5 Apr 2019 10:17:04 +0200","From":"Jacopo Mondi ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190405081704.tdfhlhla2h7wbtor@uno.localdomain>","References":"<20190405020256.22520-1-niklas.soderlund@ragnatech.se>\n\t<20190405020256.22520-5-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"3qnwug7qqubf22la\"","Content-Disposition":"inline","In-Reply-To":"<20190405020256.22520-5-niklas.soderlund@ragnatech.se>","User-Agent":"NeoMutt/20180716","Subject":"Re: [libcamera-devel] [PATCH v2 4/8] libcamera: Make geometry.h a\n\tpublic header","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 05 Apr 2019 08:16:24 -0000"}},{"id":1290,"web_url":"https://patchwork.libcamera.org/comment/1290/","msgid":"<20190405154530.GC5184@pendragon.ideasonboard.com>","date":"2019-04-05T15:45:30","subject":"Re: [libcamera-devel] [PATCH v2 4/8] libcamera: Make geometry.h a\n\tpublic header","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patch.\n\nOn Fri, Apr 05, 2019 at 04:02:52AM +0200, Niklas Söderlund wrote:\n> Make the geometry header public so it can be used by the API facing\n> applications.\n> \n> Signed-off-by: Niklas Söderlund \n> ---\n> {src/libcamera/include => include/libcamera}/geometry.h | 0\n> src/libcamera/geometry.cpp | 2 +-\n> src/libcamera/include/formats.h | 2 +-\n> src/libcamera/include/v4l2_subdevice.h | 3 ++-\n> src/libcamera/v4l2_subdevice.cpp | 3 ++-\n> test/v4l2_subdevice/list_formats.cpp | 3 ++-\n\nPlease add the header to the libcamera_api list in\ninclude/libcamera/meson.build. With this fixed,\n\nReviewed-by: Laurent Pinchart \n\nFeel free to also submit a patch to add missing headers to\nsrc/libcamera/meson.build :-)\n\n> 6 files changed, 8 insertions(+), 5 deletions(-)\n> rename {src/libcamera/include => include/libcamera}/geometry.h (100%)\n> \n> diff --git a/src/libcamera/include/geometry.h b/include/libcamera/geometry.h\n> similarity index 100%\n> rename from src/libcamera/include/geometry.h\n> rename to include/libcamera/geometry.h\n> diff --git a/src/libcamera/geometry.cpp b/src/libcamera/geometry.cpp\n> index d0c63c353ab3fc0b..d63eceaf827b99a4 100644\n> --- a/src/libcamera/geometry.cpp\n> +++ b/src/libcamera/geometry.cpp\n> @@ -7,7 +7,7 @@\n> \n> #include \n> \n> -#include \"geometry.h\"\n> +#include \n> \n> /**\n> * \\file geometry.h\n> diff --git a/src/libcamera/include/formats.h b/src/libcamera/include/formats.h\n> index 5fcfb11318e749d1..a73772b1eda068b4 100644\n> --- a/src/libcamera/include/formats.h\n> +++ b/src/libcamera/include/formats.h\n> @@ -11,7 +11,7 @@\n> #include \n> #include \n> \n> -#include \"geometry.h\"\n> +#include \n> \n> namespace libcamera {\n> \n> diff --git a/src/libcamera/include/v4l2_subdevice.h b/src/libcamera/include/v4l2_subdevice.h\n> index ee7c72468d21b83b..c71dce7d864494e5 100644\n> --- a/src/libcamera/include/v4l2_subdevice.h\n> +++ b/src/libcamera/include/v4l2_subdevice.h\n> @@ -11,8 +11,9 @@\n> #include \n> #include \n> \n> +#include \n> +\n> #include \"formats.h\"\n> -#include \"geometry.h\"\n> #include \"log.h\"\n> #include \"media_object.h\"\n> \n> diff --git a/src/libcamera/v4l2_subdevice.cpp b/src/libcamera/v4l2_subdevice.cpp\n> index 0abeaa204eda465b..e34cc1693b46b374 100644\n> --- a/src/libcamera/v4l2_subdevice.cpp\n> +++ b/src/libcamera/v4l2_subdevice.cpp\n> @@ -14,7 +14,8 @@\n> \n> #include \n> \n> -#include \"geometry.h\"\n> +#include \n> +\n> #include \"log.h\"\n> #include \"media_device.h\"\n> #include \"media_object.h\"\n> diff --git a/test/v4l2_subdevice/list_formats.cpp b/test/v4l2_subdevice/list_formats.cpp\n> index db486554b7b5c6a9..47ae3a1c1a28c350 100644\n> --- a/test/v4l2_subdevice/list_formats.cpp\n> +++ b/test/v4l2_subdevice/list_formats.cpp\n> @@ -9,7 +9,8 @@\n> #include \n> #include \n> \n> -#include \"geometry.h\"\n> +#include \n> +\n> #include \"v4l2_subdevice.h\"\n> #include \"v4l2_subdevice_test.h\"\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DCB3960DB3\n\tfor ;\n\tFri, 5 Apr 2019 17:45:41 +0200 (CEST)","from pendragon.ideasonboard.com (unknown [109.140.214.47])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 70EC4E2;\n\tFri, 5 Apr 2019 17:45:41 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1554479141;\n\tbh=a8CFOrk3N+jBbM16EQpIUBzcsjxCMvieKFHif0g3yqk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=OiIAwn3515TG62s+Ubhic2t9MJoyKQ996tnIEbPMChaInZwEO/gdHEJOi+nBWTejC\n\tqIg71P116jEJnzKtFdhTdTC06MTs7TyCZXx/QkmPM7Q7FpyNd1LTrcryHYQ/SwU67n\n\tIYQIHl3g/zKchwB8ShKjDjd39wfREz1nMbfaIkJQ=","Date":"Fri, 5 Apr 2019 18:45:30 +0300","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190405154530.GC5184@pendragon.ideasonboard.com>","References":"<20190405020256.22520-1-niklas.soderlund@ragnatech.se>\n\t<20190405020256.22520-5-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190405020256.22520-5-niklas.soderlund@ragnatech.se>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v2 4/8] libcamera: Make geometry.h a\n\tpublic header","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 05 Apr 2019 15:45:42 -0000"}}]