{"id":9170,"url":"https://patchwork.libcamera.org/api/patches/9170/?format=json","web_url":"https://patchwork.libcamera.org/patch/9170/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200804095850.275499-6-naush@raspberrypi.com>","date":"2020-08-04T09:58:43","name":"[libcamera-devel,v6,05/12] libcamera: pipeline: raspberrypi: Remove const qualifier from RPiStream","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"d3a8251a2f5e74688c84cc50425133bda0b6e516","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/9170/mbox/","series":[{"id":1187,"url":"https://patchwork.libcamera.org/api/series/1187/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1187","date":"2020-08-04T09:58:38","name":"Zero-copy RAW stream work","version":6,"mbox":"https://patchwork.libcamera.org/series/1187/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/9170/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/9170/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 23CC0BD87B\n\tfor ;\n\tTue, 4 Aug 2020 09:59:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DDEB86054A;\n\tTue, 4 Aug 2020 11:59:02 +0200 (CEST)","from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com\n\t[IPv6:2a00:1450:4864:20::42a])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8E3B260499\n\tfor ;\n\tTue, 4 Aug 2020 11:59:01 +0200 (CEST)","by mail-wr1-x42a.google.com with SMTP id f1so36250240wro.2\n\tfor ;\n\tTue, 04 Aug 2020 02:59:01 -0700 (PDT)","from naushir-VirtualBox.patuck.local ([88.97.76.4])\n\tby smtp.gmail.com with ESMTPSA id\n\t32sm34047234wrh.18.2020.08.04.02.59.00\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 04 Aug 2020 02:59:00 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"l+ykXuL1\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=i6xPt6jLjmnkByxhoVw+shMv1UBgVkah1UXeWaWM0rU=;\n\tb=l+ykXuL1/iyJwk3vhd0SfXyTnWr+M9t6hgA4j+/e+XRIfhpErSJMkZ4MlhXuwqWwi6\n\tKEtZiHUKblKa0KAtXU9lSpgCihDLVv7IJjD/locvVA9wq4iV6MZgq+dU5A3rnskXrbHG\n\tf0Q7gPLr2ENRA+IqMEj4m+yW4Zql/PWlop6Jw6XWUu5I0rbtOCneVWf5eSbzylrNyugF\n\tv5qlYYVW4PyfpQApk3zVXKkyyUOFJm6keEYVSHPRN65bnCbB1CZnLoTG61mXNL8iPiBE\n\t3jAr0Xzsy6VEzQhadvkIpYDPL/uXzvND2yi0b7h5du7C0CmeLemU8p+PXjRz+ERhAMQE\n\thU1A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=i6xPt6jLjmnkByxhoVw+shMv1UBgVkah1UXeWaWM0rU=;\n\tb=lUWxkHklHJF3frjiRrWj3QP9ExxIMUd6BL5SmIHb0WOyJ0+qY25/jlJObRDGGf9Xww\n\tZOu837zYMvoL0mkFaGGJxoOa03UhlVrXOIuJ24+INWCrv/8nOmkoUk6hem0ppIozJvIQ\n\tDxw/2hIWLi4RtjOfXEOvgOjaPh3O15tZL9QFq8ifsOE8hqT2F2gQHhWPTRc8FqOEu5Lg\n\tOhiD34ZyHqINl3dZCrDakz7arlgGiDZbtmV2DkcHTuuTuyz3aGsMgz42zFv0o2apZZpg\n\tNKLvT5ZLViaaV4x6qmXtaWDBrHJggOhhDk06f7Nwc2ocGdNiWM1u3co5EuVs0FNznOrH\n\t+OXQ==","X-Gm-Message-State":"AOAM532MpuIdMFnn17YfAFAyg+L9TvgO7F6bWQWJZCC/otoJ6O5HtmGe\n\tQbCAV5sZPLK7KxFGjUxNfN6HB6SyCO0Lnw==","X-Google-Smtp-Source":"ABdhPJz5+92fD7Bs6o95H446wE0i2dvJdWBonNUcHMBe35yh69oFfK+kGktNX+oGGChAJnfUfZy/EQ==","X-Received":"by 2002:adf:ea0c:: with SMTP id\n\tq12mr18183383wrm.382.1596535141090; \n\tTue, 04 Aug 2020 02:59:01 -0700 (PDT)","From":"Naushir Patuck ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 4 Aug 2020 10:58:43 +0100","Message-Id":"<20200804095850.275499-6-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20200804095850.275499-1-naush@raspberrypi.com>","References":"<20200804095850.275499-1-naush@raspberrypi.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v6 05/12] libcamera: pipeline:\n\traspberrypi: Remove const qualifier from RPiStream","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"For the zero-copy RAW capture feature, the RPiStream will have to be\nmodified. Remove the const qualifier in anticipation of the future\ncommits for this feature.\n\nSigned-off-by: Naushir Patuck \nReviewed-by: Niklas Söderlund \nReviewed-by: Kieran Bingham \nReviewed-by: Laurent Pinchart \nTested-by: David Plowman \n---\n src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 12 ++++++------\n 1 file changed, 6 insertions(+), 6 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\nindex a6b87df1..53a07361 100644\n--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n@@ -149,7 +149,7 @@ public:\n \tvoid ispOutputDequeue(FrameBuffer *buffer);\n \n \tvoid clearIncompleteRequests();\n-\tvoid handleStreamBuffer(FrameBuffer *buffer, const RPi::RPiStream *stream);\n+\tvoid handleStreamBuffer(FrameBuffer *buffer, RPi::RPiStream *stream);\n \tvoid handleState();\n \n \tCameraSensor *sensor_;\n@@ -1104,12 +1104,12 @@ done:\n \n void RPiCameraData::unicamBufferDequeue(FrameBuffer *buffer)\n {\n-\tconst RPi::RPiStream *stream = nullptr;\n+\tRPi::RPiStream *stream = nullptr;\n \n \tif (state_ == State::Stopped)\n \t\treturn;\n \n-\tfor (RPi::RPiStream const &s : unicam_) {\n+\tfor (RPi::RPiStream &s : unicam_) {\n \t\tif (s.findFrameBuffer(buffer)) {\n \t\t\tstream = &s;\n \t\t\tbreak;\n@@ -1170,12 +1170,12 @@ void RPiCameraData::ispInputDequeue(FrameBuffer *buffer)\n \n void RPiCameraData::ispOutputDequeue(FrameBuffer *buffer)\n {\n-\tconst RPi::RPiStream *stream = nullptr;\n+\tRPi::RPiStream *stream = nullptr;\n \n \tif (state_ == State::Stopped)\n \t\treturn;\n \n-\tfor (RPi::RPiStream const &s : isp_) {\n+\tfor (RPi::RPiStream &s : isp_) {\n \t\tif (s.findFrameBuffer(buffer)) {\n \t\t\tstream = &s;\n \t\t\tbreak;\n@@ -1256,7 +1256,7 @@ void RPiCameraData::clearIncompleteRequests()\n \t}\n }\n \n-void RPiCameraData::handleStreamBuffer(FrameBuffer *buffer, const RPi::RPiStream *stream)\n+void RPiCameraData::handleStreamBuffer(FrameBuffer *buffer, RPi::RPiStream *stream)\n {\n \tif (stream->isExternal()) {\n \t\tif (!dropFrameCount_) {\n","prefixes":["libcamera-devel","v6","05/12"]}