{"id":9168,"url":"https://patchwork.libcamera.org/api/patches/9168/?format=json","web_url":"https://patchwork.libcamera.org/patch/9168/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200804095850.275499-4-naush@raspberrypi.com>","date":"2020-08-04T09:58:41","name":"[libcamera-devel,v6,03/12] libcamera: pipeline: raspberrypi: Add some debug logging","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"de544592e7fa6a43a39eef27a7b629daa441a268","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/9168/mbox/","series":[{"id":1187,"url":"https://patchwork.libcamera.org/api/series/1187/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1187","date":"2020-08-04T09:58:38","name":"Zero-copy RAW stream work","version":6,"mbox":"https://patchwork.libcamera.org/series/1187/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/9168/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/9168/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5ED7DBD86F\n\tfor ;\n\tTue, 4 Aug 2020 09:59:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2A6F16053B;\n\tTue, 4 Aug 2020 11:59:01 +0200 (CEST)","from mail-wr1-x441.google.com (mail-wr1-x441.google.com\n\t[IPv6:2a00:1450:4864:20::441])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5BB286053B\n\tfor ;\n\tTue, 4 Aug 2020 11:58:59 +0200 (CEST)","by mail-wr1-x441.google.com with SMTP id f7so36827040wrw.1\n\tfor ;\n\tTue, 04 Aug 2020 02:58:59 -0700 (PDT)","from naushir-VirtualBox.patuck.local ([88.97.76.4])\n\tby smtp.gmail.com with ESMTPSA id\n\t32sm34047234wrh.18.2020.08.04.02.58.57\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 04 Aug 2020 02:58:58 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"KCNgohgf\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=RplsxPmRs6AHgDVous0OsVaIaGRrWTjjB/MXfVuAQ/A=;\n\tb=KCNgohgfiFXajlQatn2OnWepTG+5Ng7BRKa0fXsPi41FehzLFu7lL9La0lVYrFO8B4\n\tPlDdaaoBfcvkpD9uvit4/EDdwCUkoq4Zo8QuDrV//pZectOus67afuZjqX+xXqWmoLaQ\n\tAvCEpFjPKu6mrgeUbAmUsQOs+/Lj2VmZC4M4QsLqgzHCZjYDr8VgvsWYM/J6cxzZSZOD\n\thvaW260KtVgVkdQ9aEIyivajALJzwslNCkNob3euVIm5d/PEc3HfZc3biQz6drCVYwJ+\n\tiS/bReHF6u+H0YdmKfdIXoBUP3C0n4c3Qcv1/mHRkh31WAQUu7ibMLGubosgfArUC8uc\n\tGLag==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=RplsxPmRs6AHgDVous0OsVaIaGRrWTjjB/MXfVuAQ/A=;\n\tb=ExOAFb0lpt9Mi6ZPEdxBoIqNsRZKIqkwcSADECm6f7eaox9VZzkjRh520+UNbXkgXU\n\tbO1d6KjN8/55OzzfxG9EOCmyokJj9uYKoNitMTwGsB2MElcRxu6oP6W09K5Qs1VdC8RX\n\t0zVDOaW2SSYQLJEOwgia0tWp4zl7x6C3LtGcSDjrYFHnrr1iOOGiYGeHs+zT/Cag8gcY\n\tfE7vzOmdV3sksmnlGBEYTnjvKsSV2N0Css82IoOm+xSGo6aHf8KopsFwJPpDLrJBR+/G\n\t0iFCJxKKsZUD/llS5n63XzTrOebejMfZ05xUu/bYgwiGYoGqWXm2Rvn0liVw0oRM4RsC\n\ttkUg==","X-Gm-Message-State":"AOAM5331ww+XLBQePa3cA+DVqZWlcHhX1wCu8wdLRhiHmMf4cLXnfDrL\n\tALEFIL2FHnCBpIJv7FKyflpXD3mVMW4M2Q==","X-Google-Smtp-Source":"ABdhPJx6ezbjHnMhVOtHeGkJCws3VNp5BkrYDgabAvb1XURWc5ucXVgJxPix1tywMt5c9Bcs94O69Q==","X-Received":"by 2002:a5d:4ecf:: with SMTP id\n\ts15mr18883892wrv.202.1596535138773; \n\tTue, 04 Aug 2020 02:58:58 -0700 (PDT)","From":"Naushir Patuck ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 4 Aug 2020 10:58:41 +0100","Message-Id":"<20200804095850.275499-4-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20200804095850.275499-1-naush@raspberrypi.com>","References":"<20200804095850.275499-1-naush@raspberrypi.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v6 03/12] libcamera: pipeline:\n\traspberrypi: Add some debug logging","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"No functional changes, only added some more trace points.\n\nSigned-off-by: Naushir Patuck \nReviewed-by: Niklas Söderlund \nReviewed-by: Kieran Bingham \nTested-by: David Plowman \n---\n src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 7 ++++++-\n 1 file changed, 6 insertions(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\nindex 8fb9df72..61925033 100644\n--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n@@ -1159,6 +1159,11 @@ void RPiCameraData::ispInputDequeue(FrameBuffer *buffer)\n \tif (state_ == State::Stopped)\n \t\treturn;\n \n+\tLOG(RPI, Debug) << \"Stream ISP Input buffer complete\"\n+\t\t\t<< \", buffer id \" << buffer->cookie()\n+\t\t\t<< \", timestamp: \" << buffer->metadata().timestamp;\n+\n+\t/* The ISP input buffer gets re-queued into Unicam. */\n \thandleStreamBuffer(buffer, &unicam_[Unicam::Image]);\n \thandleState();\n }\n@@ -1461,7 +1466,7 @@ FrameBuffer *RPiCameraData::updateQueue(std::queue &q, uint64_t t\n \t\tif (b->metadata().timestamp < timestamp) {\n \t\t\tq.pop();\n \t\t\tdev->queueBuffer(b);\n-\t\t\tLOG(RPI, Error) << \"Dropping input frame!\";\n+\t\t\tLOG(RPI, Warning) << \"Dropping input frame!\";\n \t\t} else if (b->metadata().timestamp == timestamp) {\n \t\t\t/* The calling function will pop the item from the queue. */\n \t\t\treturn b;\n","prefixes":["libcamera-devel","v6","03/12"]}