[{"id":11818,"web_url":"https://patchwork.libcamera.org/comment/11818/","msgid":"<20200804110428.lwk5evttmuqr2nl2@uno.localdomain>","date":"2020-08-04T11:04:28","subject":"Re: [libcamera-devel] [PATCH v2 09/12] android: camera_device:\n\tReport configuration changes from validate()","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Kieran,\n I think this is useful debug\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\nOn Mon, Aug 03, 2020 at 05:18:13PM +0100, Kieran Bingham wrote:\n> When we call validate on a configuration, if there are any adjustments\n> on the configuration, we fail without showing why.\n>\n> Display the stream configuration after the validate stage to aid\n> debugging stream startup failures.\n>\n> Signed-off-by: Kieran Bingham \n> ---\n> src/android/camera_device.cpp | 6 +++++-\n> 1 file changed, 5 insertions(+), 1 deletion(-)\n>\n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index 9f3f3315aed4..ae52a5ca8b86 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -987,7 +987,11 @@ int CameraDevice::configureStreams(camera3_stream_configuration_t *stream_list)\n> \tcase CameraConfiguration::Valid:\n> \t\tbreak;\n> \tcase CameraConfiguration::Adjusted:\n> -\t\tLOG(HAL, Info) << \"Camera configuration adjusted\";\n> +\t\tLOG(HAL, Info) << \"Camera configuration adjusted:\";\n> +\n> +\t\tfor (const StreamConfiguration &cfg : *config_)\n> +\t\t\tLOG(HAL, Info) << \" : \" << cfg.toString();\n> +\n> \t\tconfig_.reset();\n> \t\treturn -EINVAL;\n> \tcase CameraConfiguration::Invalid:\n> --\n> 2.25.1\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 72CAABD87A\n\tfor ;\n\tTue, 4 Aug 2020 11:00:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0B35B6043C;\n\tTue, 4 Aug 2020 13:00:49 +0200 (CEST)","from relay10.mail.gandi.net (relay10.mail.gandi.net\n\t[217.70.178.230])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 558B4603C9\n\tfor ;\n\tTue, 4 Aug 2020 13:00:48 +0200 (CEST)","from uno.localdomain (93-34-118-233.ip49.fastwebnet.it\n\t[93.34.118.233]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay10.mail.gandi.net (Postfix) with ESMTPSA id 76902240003;\n\tTue, 4 Aug 2020 11:00:47 +0000 (UTC)"],"Date":"Tue, 4 Aug 2020 13:04:28 +0200","From":"Jacopo Mondi ","To":"Kieran Bingham ","Message-ID":"<20200804110428.lwk5evttmuqr2nl2@uno.localdomain>","References":"<20200803161816.107113-1-kieran.bingham@ideasonboard.com>\n\t<20200803161816.107113-10-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200803161816.107113-10-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 09/12] android: camera_device:\n\tReport configuration changes from validate()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]