[{"id":11800,"web_url":"https://patchwork.libcamera.org/comment/11800/","msgid":"<20200803162019.GI5926@pendragon.ideasonboard.com>","date":"2020-08-03T16:20:19","subject":"Re: [libcamera-devel] [PATCH v2 02/12] libcamera: formats: add\n\tplaneCount helper","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Mon, Aug 03, 2020 at 05:18:06PM +0100, Kieran Bingham wrote:\n> Determine the number of planes used by a format by counting the number\n> of PxielFormatPlaneInfo entries with a valid entry.\n\ns/PxielFormatPlaneInfo/PixelFormatPlaneInfo/\n\n> Signed-off-by: Kieran Bingham \n> Reviewed-by: Niklas Söderlund \n> Reviewed-by: Laurent Pinchart \n> \n> ---\n> v2:\n> - Rename to numPlanes\n\nEven in the subject line ? :-)\n\n> - Simplify fucntion doc.\n> ---\n> include/libcamera/internal/formats.h | 2 ++\n> src/libcamera/formats.cpp | 18 ++++++++++++++++++\n> 2 files changed, 20 insertions(+)\n> \n> diff --git a/include/libcamera/internal/formats.h b/include/libcamera/internal/formats.h\n> index b8e474916378..51a8a6b8b0ae 100644\n> --- a/include/libcamera/internal/formats.h\n> +++ b/include/libcamera/internal/formats.h\n> @@ -46,6 +46,8 @@ public:\n> \tunsigned int frameSize(const Size &size,\n> \t\t\t const std::array &strides) const;\n> \n> +\tunsigned int numPlanes() const;\n> +\n> \t/* \\todo Add support for non-contiguous memory planes */\n> \tconst char *name;\n> \tPixelFormat format;\n> diff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\n> index a51e96810aed..ebaae9be3d75 100644\n> --- a/src/libcamera/formats.cpp\n> +++ b/src/libcamera/formats.cpp\n> @@ -821,4 +821,22 @@ PixelFormatInfo::frameSize(const Size &size,\n> \treturn sum;\n> }\n> \n> +/**\n> + * \\brief Retrieve the number of planes represented by the format\n> + * \\return The number of planes used by the format\n> + */\n> +unsigned int PixelFormatInfo::numPlanes() const\n> +{\n> +\tunsigned int count = 0;\n> +\n> +\tfor (const PixelFormatPlaneInfo &p : planes) {\n> +\t\tif (p.bytesPerGroup == 0)\n> +\t\t\tbreak;\n> +\n> +\t\tcount++;\n> +\t}\n> +\n> +\treturn count;\n> +}\n> +\n> } /* namespace libcamera */","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BBBC7BD87A\n\tfor ;\n\tMon, 3 Aug 2020 16:20:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6539561813;\n\tMon, 3 Aug 2020 18:20:32 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DC311605A9\n\tfor ;\n\tMon, 3 Aug 2020 18:20:30 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id F3549543;\n\tMon, 3 Aug 2020 18:20:29 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"sCBHVnxt\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1596471630;\n\tbh=8zJjWdEhiTiU11gN2KCoHY7ZUM+8B1T6RjuIkvSfiHY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=sCBHVnxtV+WvPy6UgONiRHZAEk4hIaKx6FeD0AemQ4KkLCM5jflsPueCC3LH0y6s+\n\tOiltXLcGgMX9JxtMP8aAggrbnBVy0GjO6hhCPT62WuA2EDFqDL301PX3VVC71jc8mn\n\te642LctA+1oOJaQxInT+caVk3LLPj5l/x68Ra3sg=","Date":"Mon, 3 Aug 2020 19:20:19 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"<20200803162019.GI5926@pendragon.ideasonboard.com>","References":"<20200803161816.107113-1-kieran.bingham@ideasonboard.com>\n\t<20200803161816.107113-3-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200803161816.107113-3-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 02/12] libcamera: formats: add\n\tplaneCount helper","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]