[{"id":11780,"web_url":"https://patchwork.libcamera.org/comment/11780/","msgid":"<20200802225316.GI23801@pendragon.ideasonboard.com>","date":"2020-08-02T22:53:16","subject":"Re: [libcamera-devel] [PATCH] libcamera: device_enumerator_udev:\n\tAlign class final declaration with sysfs subclass","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patch.\n\nOn Mon, Aug 03, 2020 at 12:50:23AM +0200, Niklas Söderlund wrote:\n> Instead of marking each individual overloaded function with final mark\n> the whole class as final. This aligns the sysfs and udev based\n> DeviceEnumerator implementations.\n> \n> Signed-off-by: Niklas Söderlund \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> include/libcamera/internal/device_enumerator_udev.h | 6 +++---\n> 1 file changed, 3 insertions(+), 3 deletions(-)\n> \n> diff --git a/include/libcamera/internal/device_enumerator_udev.h b/include/libcamera/internal/device_enumerator_udev.h\n> index 2e7916a0b280f60d..6f45be0c1c423d02 100644\n> --- a/include/libcamera/internal/device_enumerator_udev.h\n> +++ b/include/libcamera/internal/device_enumerator_udev.h\n> @@ -26,14 +26,14 @@ class EventNotifier;\n> class MediaDevice;\n> class MediaEntity;\n> \n> -class DeviceEnumeratorUdev : public DeviceEnumerator\n> +class DeviceEnumeratorUdev final : public DeviceEnumerator\n> {\n> public:\n> \tDeviceEnumeratorUdev();\n> \t~DeviceEnumeratorUdev();\n> \n> -\tint init() final;\n> -\tint enumerate() final;\n> +\tint init();\n> +\tint enumerate();\n> \n> private:\n> \tusing DependencyMap = std::map>;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0C8EABD87A\n\tfor ;\n\tSun, 2 Aug 2020 22:53:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 983C0603F7;\n\tMon, 3 Aug 2020 00:53:28 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C379160398\n\tfor ;\n\tMon, 3 Aug 2020 00:53:27 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 41345296;\n\tMon, 3 Aug 2020 00:53:27 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"fkw07Xkk\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1596408807;\n\tbh=iEfdF5TYqqSCyPwy/M8IIxAif4x73zmfj+mCKd1z6uc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=fkw07XkkndLwQxCvjI1IbFMZC6I280HZjLiPCZHvy9yEf1DxJBGRjXrJfZmsclsI0\n\tAT+6/t1GM9Mj80GSeut+XidkvPwX4a8z84JSP/DuMpeSKNkyl2quXq9EW3UuHrCyhP\n\tx8RJcXkJD07ygctKYcudnGAUashPs0+3rkRmXrJc=","Date":"Mon, 3 Aug 2020 01:53:16 +0300","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Message-ID":"<20200802225316.GI23801@pendragon.ideasonboard.com>","References":"<20200802225023.346784-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200802225023.346784-1-niklas.soderlund@ragnatech.se>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: device_enumerator_udev:\n\tAlign class final declaration with sysfs subclass","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":11785,"web_url":"https://patchwork.libcamera.org/comment/11785/","msgid":"","date":"2020-08-03T04:23:29","subject":"Re: [libcamera-devel] [PATCH] libcamera: device_enumerator_udev:\n\tAlign class final declaration with sysfs subclass","submitter":{"id":1,"url":"https://patchwork.libcamera.org/api/people/1/","name":"Umang Jain","email":"email@uajain.com"},"content":"Hi Niklas,\n\nOn 8/3/20 4:20 AM, Niklas Söderlund wrote:\n> Instead of marking each individual overloaded function with final mark\n> the whole class as final. This aligns the sysfs and udev based\n> DeviceEnumerator implementations.\n>\n> Signed-off-by: Niklas Söderlund \nReviewed-by: Umang Jain \n\nThanks.\n\n> ---\n> include/libcamera/internal/device_enumerator_udev.h | 6 +++---\n> 1 file changed, 3 insertions(+), 3 deletions(-)\n>\n> diff --git a/include/libcamera/internal/device_enumerator_udev.h b/include/libcamera/internal/device_enumerator_udev.h\n> index 2e7916a0b280f60d..6f45be0c1c423d02 100644\n> --- a/include/libcamera/internal/device_enumerator_udev.h\n> +++ b/include/libcamera/internal/device_enumerator_udev.h\n> @@ -26,14 +26,14 @@ class EventNotifier;\n> class MediaDevice;\n> class MediaEntity;\n> \n> -class DeviceEnumeratorUdev : public DeviceEnumerator\n> +class DeviceEnumeratorUdev final : public DeviceEnumerator\n> {\n> public:\n> \tDeviceEnumeratorUdev();\n> \t~DeviceEnumeratorUdev();\n> \n> -\tint init() final;\n> -\tint enumerate() final;\n> +\tint init();\n> +\tint enumerate();\n> \n> private:\n> \tusing DependencyMap = std::map>;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 74E10BD86F\n\tfor ;\n\tMon, 3 Aug 2020 04:23:34 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 070B4609B9;\n\tMon, 3 Aug 2020 06:23:34 +0200 (CEST)","from o1.f.az.sendgrid.net (o1.f.az.sendgrid.net [208.117.55.132])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3F59260390\n\tfor ;\n\tMon, 3 Aug 2020 06:23:31 +0200 (CEST)","by filterdrecv-p3mdw1-7ff865655c-vtsg9 with SMTP id\n\tfilterdrecv-p3mdw1-7ff865655c-vtsg9-19-5F279141-10\n\t2020-08-03 04:23:29.513914048 +0000 UTC m=+382030.034103129","from mail.uajain.com (unknown)\n\tby ismtpd0004p1maa1.sendgrid.net (SG) with ESMTP\n\tid dJOsblSZT_alKKqx4zgr4A Mon, 03 Aug 2020 04:23:28.889 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=uajain.com header.i=@uajain.com\n\theader.b=\"dcj6Uwud\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=uajain.com;\n\th=subject:references:from:mime-version:in-reply-to:to:content-type;\n\ts=s1; bh=jMVcomqlHU/x7QRlAeYfDlzklIKjSkZjKfH2rnWybjg=;\n\tb=dcj6UwudvjZltqMfcGonGvFjGhCksUqeFgtdbABLICopyu/faqHtdjomGx1BDOtAu7hm\n\tUdlFvraC6S80C64Uv+zHDBLOoajq9Txl/4UPsQzMU9aeaUlscnVErmsWON89uzbdlFff3X\n\tx5Hi10HQNGq29FozGwRvOv31C12Deubmw=","References":"<20200802225023.346784-1-niklas.soderlund@ragnatech.se>","From":"Umang Jain ","Message-ID":"","Date":"Mon, 03 Aug 2020 04:23:29 +0000 (UTC)","Mime-Version":"1.0","In-Reply-To":"<20200802225023.346784-1-niklas.soderlund@ragnatech.se>","X-SG-EID":"1Q40EQ7YGir8a9gjSIAdTjhngY657NMk9ckeo4dbHZDiOpywc/L3L9rFqlwE4KPcO0wIVNwfic3Culi7Uik3lxXwsf7lh7KNpBRChnN7EjuDYG3t+Et/sewbBTg6qbrdSWWWlh7k/RlfJVOHL4VC/q8CrDylA8GncsOwDZTbtPdLopcrfzkj8BPS8XEQJl/akijXGydUBETLYeYjNufaqsw4QkijZQleF3LOene6QEVVXfxlSiA2ZW5GbmfIz2w/uXh1KaN4Uj3KRMmrT4XRmg==","To":"Niklas =?iso-8859-1?q?S=F6derlund?= ,\n\tlibcamera-devel@lists.libcamera.org","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH] libcamera: device_enumerator_udev:\n\tAlign class final declaration with sysfs subclass","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"multipart/mixed;\n\tboundary=\"===============5538983022078471302==\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]