[{"id":11768,"web_url":"https://patchwork.libcamera.org/comment/11768/","msgid":"<20200801125131.GB11820@pendragon.ideasonboard.com>","date":"2020-08-01T12:51:31","subject":"Re: [libcamera-devel] [PATCH v3 1/3] android: camera_device:\n\tPrepare for none-mandatory formats","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patch.\n\ns/none/non/ in the subject line.\n\nOn Sat, Aug 01, 2020 at 12:14:25PM +0200, Niklas Söderlund wrote:\n> When probing what formats a libcamera Camera supports we want to allow\n> to probe for not mandatory formats. Add a new flag to indicate if a\n\ns/not mandatory/non-mandatory/\n\n> format in camera3FormatsMap is mandatory or not.\n> \n> All current defined formats are mandatory.\n> \n> Signed-off-by: Niklas Söderlund \n> Reviewed-by: Jacopo Mondi \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/android/camera_device.cpp | 6 +++++-\n> 1 file changed, 5 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index b49d6681e5a52d32..8028d3e12bda1316 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -46,6 +46,7 @@ const std::vector camera3Resolutions = {\n> */\n> struct Camera3Format {\n> \tstd::vector libcameraFormats;\n> +\tbool mandatory;\n> \tconst char *name;\n> };\n> \n> @@ -57,11 +58,13 @@ const std::map camera3FormatsMap = {\n> \t{\n> \t\tHAL_PIXEL_FORMAT_BLOB, {\n> \t\t\t{ formats::MJPEG },\n> +\t\t\ttrue,\n> \t\t\t\"BLOB\"\n> \t\t}\n> \t}, {\n> \t\tHAL_PIXEL_FORMAT_YCbCr_420_888, {\n> \t\t\t{ formats::NV12, formats::NV21 },\n> +\t\t\ttrue,\n> \t\t\t\"YCbCr_420_888\"\n> \t\t}\n> \t}, {\n> @@ -71,6 +74,7 @@ const std::map camera3FormatsMap = {\n> \t\t */\n> \t\tHAL_PIXEL_FORMAT_IMPLEMENTATION_DEFINED, {\n> \t\t\t{ formats::NV12, formats::NV21 },\n> +\t\t\ttrue,\n> \t\t\t\"IMPLEMENTATION_DEFINED\"\n> \t\t}\n> \t},\n> @@ -281,7 +285,7 @@ int CameraDevice::initializeStreamConfigurations()\n> \t\t\t\tbreak;\n> \t\t\t}\n> \t\t}\n> -\t\tif (!mappedFormat.isValid()) {\n> +\t\tif (camera3Format.mandatory && !mappedFormat.isValid()) {\n> \t\t\tLOG(HAL, Error) << \"Failed to map Android format \"\n> \t\t\t\t\t<< camera3Format.name << \" (\"\n> \t\t\t\t\t<< utils::hex(androidFormat) << \")\";","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 60A19BD86F\n\tfor ;\n\tSat, 1 Aug 2020 12:51:43 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E822061F7D;\n\tSat, 1 Aug 2020 14:51:42 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B471561F24\n\tfor ;\n\tSat, 1 Aug 2020 14:51:41 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2E0CE55E;\n\tSat, 1 Aug 2020 14:51:41 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"e4Jj4kOj\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1596286301;\n\tbh=103TZrtGby8a1nvwyv9gGcJaf0qyoCxf4RCCdwS+Bng=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=e4Jj4kOjZK77awLbPss9Tm0ygjjCiudMrgTTmeADbG2h9bexLlwH62Y0HPFA6OBTN\n\tWLRZ3BwmP59mZThF+X6vM0elP25TE8mc3999jHhccXlanjiYHat2Auc+9W4ErFQ/Co\n\t1eGuNgmnDkraozk+KxdiOq4ams26UBHdGxCG26QY=","Date":"Sat, 1 Aug 2020 15:51:31 +0300","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Message-ID":"<20200801125131.GB11820@pendragon.ideasonboard.com>","References":"<20200801101427.1540331-1-niklas.soderlund@ragnatech.se>\n\t<20200801101427.1540331-2-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200801101427.1540331-2-niklas.soderlund@ragnatech.se>","Subject":"Re: [libcamera-devel] [PATCH v3 1/3] android: camera_device:\n\tPrepare for none-mandatory formats","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]