[{"id":11812,"web_url":"https://patchwork.libcamera.org/comment/11812/","msgid":"","date":"2020-08-04T08:49:13","subject":"Re: [libcamera-devel] [PATCH v3 2/4] libcamera: ipa: raspberrypi:\n\tALSC: Improve locking in a few places","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi David,\n\nThank you for the patch.\n\nOn Sat, 1 Aug 2020 at 09:02, David Plowman\n wrote:\n>\n> Fix up a few locations where we call notify_one() with the lock\n> held. In particular, restartAsync does not need to be called with the\n> lock held for its entire duration.\n>\n> Signed-off-by: David Plowman \n> Reviewed-by: Laurent Pinchart \n\nReviewed-by: Naushir Patuck \n\n\n> ---\n> src/ipa/raspberrypi/controller/rpi/alsc.cpp | 10 ++++++----\n> 1 file changed, 6 insertions(+), 4 deletions(-)\n>\n> diff --git a/src/ipa/raspberrypi/controller/rpi/alsc.cpp b/src/ipa/raspberrypi/controller/rpi/alsc.cpp\n> index 76e2f04..12359dc 100644\n> --- a/src/ipa/raspberrypi/controller/rpi/alsc.cpp\n> +++ b/src/ipa/raspberrypi/controller/rpi/alsc.cpp\n> @@ -32,8 +32,8 @@ Alsc::~Alsc()\n> {\n> std::lock_guard lock(mutex_);\n> async_abort_ = true;\n> - async_signal_.notify_one();\n> }\n> + async_signal_.notify_one();\n> async_thread_.join();\n> }\n>\n> @@ -268,8 +268,11 @@ void Alsc::restartAsync(StatisticsPtr &stats, Metadata *image_metadata)\n> frame_phase_ = 0;\n> // copy the camera mode so it won't change during the calculations\n> async_camera_mode_ = camera_mode_;\n> - async_start_ = true;\n> async_started_ = true;\n> + {\n> + std::lock_guard lock(mutex_);\n> + async_start_ = true;\n> + }\n> async_signal_.notify_one();\n> }\n>\n> @@ -315,7 +318,6 @@ void Alsc::Process(StatisticsPtr &stats, Metadata *image_metadata)\n> RPI_LOG(\"Alsc: frame_phase \" << frame_phase_);\n> if (frame_phase_ >= (int)config_.frame_period ||\n> frame_count2_ < (int)config_.startup_frames) {\n> - std::unique_lock lock(mutex_);\n> if (async_started_ == false) {\n> RPI_LOG(\"ALSC thread starting\");\n> restartAsync(stats, image_metadata);\n> @@ -339,8 +341,8 @@ void Alsc::asyncFunc()\n> {\n> std::lock_guard lock(mutex_);\n> async_finished_ = true;\n> - sync_signal_.notify_one();\n> }\n> + sync_signal_.notify_one();\n> }\n> }\n>\n> --\n> 2.20.1\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AF40FBD86F\n\tfor ;\n\tTue, 4 Aug 2020 08:49:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7AB48619AC;\n\tTue, 4 Aug 2020 10:49:32 +0200 (CEST)","from mail-lj1-x243.google.com (mail-lj1-x243.google.com\n\t[IPv6:2a00:1450:4864:20::243])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4D5466038F\n\tfor ;\n\tTue, 4 Aug 2020 10:49:30 +0200 (CEST)","by mail-lj1-x243.google.com with SMTP id v12so12345976ljc.10\n\tfor ;\n\tTue, 04 Aug 2020 01:49:30 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"pCLw1XE9\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=fD0YkbRPveZgKPMB7n03cmGSYexJGdynLViKM8WPDh4=;\n\tb=pCLw1XE991O2vVPr7LssRR16KTZ0HC0okW1afy//bwNfKe89P498Kzgbf7lzaktf1x\n\trnfY/ysF5VxHGh8VHiadc7ni6eZB9u/+O2rBds5fUr6pb3snmriLu3zv3LCYVFOKi0nG\n\tdeXV+isAKTJTEhNvD4kXX9bsLfam/58F0In6m+AxUQ6EiY7IT5VrMR6M2BnIpfhaLRab\n\t5D0xhcRFl4fyC6YMAGhJzUWuzViy+M9uQlQoHofArzVoNEGtPcuK81xqIgKSc9cWaCM3\n\tWQpYp5tEl8EJ/TuWTqKpIiq70BTpBze/wp+c5fTGsplrwkJ0HJZjPzkqcHzjRLJTGvAB\n\t+A9g==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=fD0YkbRPveZgKPMB7n03cmGSYexJGdynLViKM8WPDh4=;\n\tb=UEn3WMWGF0ikGrY2VAwOQ1nxeow2exdqT9LqofiZNI0Sm6APOuv4fUhfTWQRXU4Yqo\n\tKu+S5oLCdcL3vjrFQ8BuOVhmw6Nv0ovcUS9gCNFQ1Fh1YMSvcPm6S6ApDuQO8CJrF2uS\n\tF3HZiV6l+EV6KEUjBla7TmL4+cZ//DcQzpW49xe+p/V8wdo5Y1xruq8WF3ZM59JsRb8t\n\t8eS4Fvlumk0X9uqslgxD/wrzGIGPFtTsGeDk9yg1+554Wuq8bx9o7ROY5v9ZKLFQWpZQ\n\tbWlLP5sUUKlxwiXElFH+F+DKF+uANbVKH/sGq6+EiE+z4l8VmVk2c5BbSB8WXnfdkaT7\n\tQGGw==","X-Gm-Message-State":"AOAM53096aDodWj5OHMc9s5qRqLcl2N3nO2bZ7vfnhjoWGYtUnk/HEFE\n\tnO3Ocu073UoLoR9huP5aDbhS8JYdpkcm2FXmgOSlMg==","X-Google-Smtp-Source":"ABdhPJxOv9fXQP/S0q7ydFFm5aMV/8o4Gz2X7GGIdjVzprKZnw244c0oupOGvm2oGt4Yl4H0cPAb+j6IPDiO45wXUpQ=","X-Received":"by 2002:a05:651c:1343:: with SMTP id\n\tj3mr8714282ljb.112.1596530969711; \n\tTue, 04 Aug 2020 01:49:29 -0700 (PDT)","MIME-Version":"1.0","References":"<20200801080151.4282-1-david.plowman@raspberrypi.com>\n\t<20200801080151.4282-3-david.plowman@raspberrypi.com>","In-Reply-To":"<20200801080151.4282-3-david.plowman@raspberrypi.com>","From":"Naushir Patuck ","Date":"Tue, 4 Aug 2020 09:49:13 +0100","Message-ID":"","To":"David Plowman ","Subject":"Re: [libcamera-devel] [PATCH v3 2/4] libcamera: ipa: raspberrypi:\n\tALSC: Improve locking in a few places","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":11912,"web_url":"https://patchwork.libcamera.org/comment/11912/","msgid":"<08542e5d-624f-d82a-8d84-e8c68ad0e92e@ideasonboard.com>","date":"2020-08-06T10:06:28","subject":"Re: [libcamera-devel] [PATCH v3 2/4] libcamera: ipa: raspberrypi:\n\tALSC: Improve locking in a few places","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi David,\n\nI believe this patch has introduced the following coverity warning. If\nyou supply a patch to fix this issue, please add the following tag:\n\nReported-by: Coverity CID=298183\n\nAlternatively, if you believe it's a false positive, let me know and\nI'll close it.\n\n** CID 298183: Concurrent data access violations (MISSING_LOCK)\n/home/linuxembedded/iob/libcamera/libcamera-daily/src/ipa/raspberrypi/controller/rpi/alsc.cpp:\n369 in RPi::Alsc::asyncFunc()()","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EA8E7BD86F\n\tfor ;\n\tThu, 6 Aug 2020 10:06:34 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 814796055A;\n\tThu, 6 Aug 2020 12:06:34 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4D1B060554\n\tfor ;\n\tThu, 6 Aug 2020 12:06:32 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id F0E6350E;\n\tThu, 6 Aug 2020 12:06:30 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"tduw4Hcz\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1596708391;\n\tbh=tadoIgCKSPdoTaUpAjgwKd9nQrbCwaSA5wGwstnlKUw=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=tduw4HczvXHA6sWT+BCMhi741TZJ+LU08tz6m2ANRiW8dYmjjBIP1DZD4GGi8vc7y\n\t0+bqy52zuslUPb8Z1a+y6eh8zF+2Mj0Vqv+y6sjXdtB+JCVnE6LxUEW2aniviR/XHQ\n\t5e7OPfpnPWexPw2/JsjxLwzZyte97NaUvFqn4A/w=","To":"David Plowman ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20200801080151.4282-1-david.plowman@raspberrypi.com>\n\t<20200801080151.4282-3-david.plowman@raspberrypi.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<08542e5d-624f-d82a-8d84-e8c68ad0e92e@ideasonboard.com>","Date":"Thu, 6 Aug 2020 11:06:28 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20200801080151.4282-3-david.plowman@raspberrypi.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH v3 2/4] libcamera: ipa: raspberrypi:\n\tALSC: Improve locking in a few places","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":11914,"web_url":"https://patchwork.libcamera.org/comment/11914/","msgid":"","date":"2020-08-06T10:18:26","subject":"Re: [libcamera-devel] [PATCH v3 2/4] libcamera: ipa: raspberrypi:\n\tALSC: Improve locking in a few places","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"content":"Hi Kieran\n\nYes, I agree, it looks like a false positive to me. According to my\n(limited!) understanding of C++, the lock is taken straight back as we\ncome out of the wait, so async_start_ is written to with the mutex\nheld.\n\nThanks!\nDavid\n\nOn Thu, 6 Aug 2020 at 11:06, Kieran Bingham\n wrote:\n>\n> Hi David,\n>\n> I believe this patch has introduced the following coverity warning. If\n> you supply a patch to fix this issue, please add the following tag:\n>\n> Reported-by: Coverity CID=298183\n>\n> Alternatively, if you believe it's a false positive, let me know and\n> I'll close it.\n>\n> ** CID 298183: Concurrent data access violations (MISSING_LOCK)\n> /home/linuxembedded/iob/libcamera/libcamera-daily/src/ipa/raspberrypi/controller/rpi/alsc.cpp:\n> 369 in RPi::Alsc::asyncFunc()()\n>\n>\n> ________________________________________________________________________________________________________\n> *** CID 298183: Concurrent data access violations (MISSING_LOCK)\n> /home/linuxembedded/iob/libcamera/libcamera-daily/src/ipa/raspberrypi/controller/rpi/alsc.cpp:\n> 369 in RPi::Alsc::asyncFunc()()\n> 363 while (true) {\n> 364 {\n> 365 std::unique_lock lock(mutex_);\n> 366 async_signal_.wait(lock, [&] {\n> 367 return async_start_ || async_abort_;\n> 368 });\n> >>> CID 298183: Concurrent data access violations (MISSING_LOCK)\n> >>> Accessing \"this->async_start_\" without holding lock\n> \"RPi::Alsc.mutex_\". Elsewhere, \"_ZN3RPi4AlscE.async_start_\" is accessed\n> with \"RPi::Alsc.mutex_\" held 1 out of 2 times (1 of these accesses\n> strongly imply that it is necessary).\n> 369 async_start_ = false;\n> 370 if (async_abort_)\n> 371 break;\n> 372 }\n> 373 doAlsc();\n> 374 {\n>\n>\n>\n> Briefly looking, I think that the call to async_signal_.wait(lock...)\n> means that the lock is held for the remainder of the scope, so in fact\n> this is likely a false positive. Is that interpretation accurate?\n>\n>\n> --\n> Regards\n>\n> Kieran\n>\n>\n> On 01/08/2020 09:01, David Plowman wrote:\n> > Fix up a few locations where we call notify_one() with the lock\n> > held. In particular, restartAsync does not need to be called with the\n> > lock held for its entire duration.\n> >\n> > Signed-off-by: David Plowman \n> > Reviewed-by: Laurent Pinchart \n> > ---\n> > src/ipa/raspberrypi/controller/rpi/alsc.cpp | 10 ++++++----\n> > 1 file changed, 6 insertions(+), 4 deletions(-)\n> >\n> > diff --git a/src/ipa/raspberrypi/controller/rpi/alsc.cpp b/src/ipa/raspberrypi/controller/rpi/alsc.cpp\n> > index 76e2f04..12359dc 100644\n> > --- a/src/ipa/raspberrypi/controller/rpi/alsc.cpp\n> > +++ b/src/ipa/raspberrypi/controller/rpi/alsc.cpp\n> > @@ -32,8 +32,8 @@ Alsc::~Alsc()\n> > {\n> > std::lock_guard lock(mutex_);\n> > async_abort_ = true;\n> > - async_signal_.notify_one();\n> > }\n> > + async_signal_.notify_one();\n> > async_thread_.join();\n> > }\n> >\n> > @@ -268,8 +268,11 @@ void Alsc::restartAsync(StatisticsPtr &stats, Metadata *image_metadata)\n> > frame_phase_ = 0;\n> > // copy the camera mode so it won't change during the calculations\n> > async_camera_mode_ = camera_mode_;\n> > - async_start_ = true;\n> > async_started_ = true;\n> > + {\n> > + std::lock_guard lock(mutex_);\n> > + async_start_ = true;\n> > + }\n> > async_signal_.notify_one();\n> > }\n> >\n> > @@ -315,7 +318,6 @@ void Alsc::Process(StatisticsPtr &stats, Metadata *image_metadata)\n> > RPI_LOG(\"Alsc: frame_phase \" << frame_phase_);\n> > if (frame_phase_ >= (int)config_.frame_period ||\n> > frame_count2_ < (int)config_.startup_frames) {\n> > - std::unique_lock lock(mutex_);\n> > if (async_started_ == false) {\n> > RPI_LOG(\"ALSC thread starting\");\n> > restartAsync(stats, image_metadata);\n> > @@ -339,8 +341,8 @@ void Alsc::asyncFunc()\n> > {\n> > std::lock_guard lock(mutex_);\n> > async_finished_ = true;\n> > - sync_signal_.notify_one();\n> > }\n> > + sync_signal_.notify_one();\n> > }\n> > }\n> >\n> >\n>\n> --\n> Regards\n> --\n> Kieran","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A8695BD87A\n\tfor ;\n\tThu, 6 Aug 2020 10:18:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 309216073B;\n\tThu, 6 Aug 2020 12:18:39 +0200 (CEST)","from mail-ot1-x343.google.com (mail-ot1-x343.google.com\n\t[IPv6:2607:f8b0:4864:20::343])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9D63D60554\n\tfor ;\n\tThu, 6 Aug 2020 12:18:37 +0200 (CEST)","by mail-ot1-x343.google.com with SMTP id x24so11620422otp.3\n\tfor ;\n\tThu, 06 Aug 2020 03:18:37 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"dlRkQKWK\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=RO4/9IzcgLxx90LgP47Pd7EC2gV7w8vOFkoRWQbsBvU=;\n\tb=dlRkQKWKYdYJ3+2ilHI3pO81olCxFgmjmXqoa7l5PKYyKOVjFUYsM9n3XdHx8zb5BR\n\tifZYPX9EZy+CY1FSa5lWOx2S6Jz/ordXzb4g3kNAkOulLZUDWjT6FPQaMnW/E4S6zfII\n\tEKI22LgkYiChSuUj/qdf7yEOnSP3aTEL1bTwA9UJV5TJ1dfiTsRW408visCM/xue5dT2\n\t1lIqXE9V0EXfmFESFGmD73qH9r7z3HU5HNrSNSY2Ov30CHMAY80oLsI2A5N+Gm/RIgv3\n\tm+XRFDEa0Vg13aGUUfBtpkQDh7WevqPnCgnYoV3gmG0Dab7Qa5BfmCEGdSgGoj+8G5HF\n\tP92Q==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=RO4/9IzcgLxx90LgP47Pd7EC2gV7w8vOFkoRWQbsBvU=;\n\tb=g3F+tPzNtxqTZuoczwL5XrHdVDXRu17ZRHkVOmRJ3o/lIJjccHxvhQLxChuK2f9Xr7\n\taSuoe2J/ikIZqBqFAtWPG98v5FkEggOJn3FkWd4WMDw/GaF/i1XA4lu1zjkdcEV6lPss\n\tX8f9Vy17dQ0VsyM1WbN78l5uDxTqbFTYoYrjuqOUuoZ5KYCyiIIrWkT1hQKPqgK33tOC\n\taN5RO2joT3sdzazjqefeLfHAC98KMRJQjvlw8/7CuZ3RfZKIyrgqn/eiSMHeI24fQYM9\n\tDW8Y3yVxOlXI8f4YVd6gPxuzgtXPEiOP/cLZyBoKdgVUbK3AFRXjzr2KXrYiFsZ7t+Nr\n\tYOYQ==","X-Gm-Message-State":"AOAM530XB85t7cEY124gnw89MsEr0A/zFKB6FvzqQw/mbyeV+JOFmGcn\n\tW2+DeLIaNUxtcrlrb9t5yZjFFuscdQEqybTWFwkP2NMBE8o=","X-Google-Smtp-Source":"ABdhPJzsd3oMlOszixIxHeILLu1yLNqQ54lSvcfxhGKCDQJrBlvs9j3/p9h9qAPnqyrULP5bNkh2x4XBN3o95cvIQ0k=","X-Received":"by 2002:a9d:7994:: with SMTP id\n\th20mr6779134otm.317.1596709116433; \n\tThu, 06 Aug 2020 03:18:36 -0700 (PDT)","MIME-Version":"1.0","References":"<20200801080151.4282-1-david.plowman@raspberrypi.com>\n\t<20200801080151.4282-3-david.plowman@raspberrypi.com>\n\t<08542e5d-624f-d82a-8d84-e8c68ad0e92e@ideasonboard.com>","In-Reply-To":"<08542e5d-624f-d82a-8d84-e8c68ad0e92e@ideasonboard.com>","From":"David Plowman ","Date":"Thu, 6 Aug 2020 11:18:26 +0100","Message-ID":"","To":"Kieran Bingham ","Subject":"Re: [libcamera-devel] [PATCH v3 2/4] libcamera: ipa: raspberrypi:\n\tALSC: Improve locking in a few places","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]