[{"id":11811,"web_url":"https://patchwork.libcamera.org/comment/11811/","msgid":"","date":"2020-08-04T08:49:09","subject":"Re: [libcamera-devel] [PATCH v3 1/4] libcamera: ipa: raspberrypi:\n\tALSC: Camera mode does not need to be atomic","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi David,\n\nThank you for the patch.\n\nOn Sat, 1 Aug 2020 at 09:02, David Plowman\n wrote:\n>\n> In the libcamera framework, SwitchMode (which overwrites the\n> camera_mode) cannot run concurrently with Prepare (which uses it).\n>\n> Signed-off-by: David Plowman \n> Reviewed-by: Laurent Pinchart \n\nReviewed-by: Naushir Patuck \n\n\n> ---\n> src/ipa/raspberrypi/controller/rpi/alsc.hpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/ipa/raspberrypi/controller/rpi/alsc.hpp b/src/ipa/raspberrypi/controller/rpi/alsc.hpp\n> index 3806257..e895913 100644\n> --- a/src/ipa/raspberrypi/controller/rpi/alsc.hpp\n> +++ b/src/ipa/raspberrypi/controller/rpi/alsc.hpp\n> @@ -59,7 +59,7 @@ private:\n> // configuration is read-only, and available to both threads\n> AlscConfig config_;\n> bool first_time_;\n> - std::atomic camera_mode_;\n> + CameraMode camera_mode_;\n> std::thread async_thread_;\n> void asyncFunc(); // asynchronous thread function\n> std::mutex mutex_;\n> --\n> 2.20.1\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 595FFBD86F\n\tfor ;\n\tTue, 4 Aug 2020 08:49:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 267D8619AC;\n\tTue, 4 Aug 2020 10:49:27 +0200 (CEST)","from mail-lj1-x244.google.com (mail-lj1-x244.google.com\n\t[IPv6:2a00:1450:4864:20::244])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0B6646038F\n\tfor ;\n\tTue, 4 Aug 2020 10:49:26 +0200 (CEST)","by mail-lj1-x244.google.com with SMTP id w25so7217255ljo.12\n\tfor ;\n\tTue, 04 Aug 2020 01:49:26 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"bEBQORKC\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=E55DYrkDY4aX5PcxgKAzsT/yVhYYViCNXngSvYzHeUM=;\n\tb=bEBQORKCaOs/jNn4QMS9h1d/8Gw0pYCPjcEI68JHUk9NXGxgS04CIA/1Ar0SL6O2Yt\n\tQSRnYHhyfHtaD1SUxhRzbPehIok+f63S3784la/xu9YvsEA6CLrDwL1fdfMx4oqvlwlB\n\te+FoT2pJ8UeJ+feWbdDaRSjXQB5JZfcYVUf44fdYmsF3xKYaAZOK8YeY//14abI2+3sl\n\tjsz+RNnGofTcOdvO3tLhyW/WtjfjL7N6hPth3YlL2ILxoRI/jYsXaOxOPVtjuazSLh1d\n\tsxLBFbm9TS6Kf0L3mU19F5stgDW+JzbYiJ7FUBTiXBcli/VeWlLLNY9zXQIBxKAFec3v\n\tFtKw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=E55DYrkDY4aX5PcxgKAzsT/yVhYYViCNXngSvYzHeUM=;\n\tb=YnX10gib+9bsG2PrBaOdoeogPJApaemA+NDwmuU4DTImVeJ4mYIxCcSz5ThyicqqGt\n\tfrDnpZ9X6nN111/6OrLwxmwn4YPF+KD9psj/kXDoYCj2vIYST4DR5Uw3PynIXwmRGROP\n\tth+aZOrlSJ2UBACGLPnheeO8Drn9BlHmQfgF+fwJHOVKo9KWlpiL1M+49U09CJAbwiLS\n\tXjvVz+ozM0xVekwJEt4qq8MeJsEOye2pkfXpMBGMIpYeqD2BIpbUXZkpzWtJfMFl2Ipn\n\tTV7Ueb9Lzi+hTT57H+w9mdHbMM7+tENprS39yvfgWRH4r91TDub+geM4XKFKKqqnmZlj\n\tO4bQ==","X-Gm-Message-State":"AOAM531dqItsXZa75/iYA8DoSiZPFeXliia7cl6fD1WU8l8hEJZMjYEZ\n\t0XAKZRaidKu73xtqJRQi2CaNKA6c7cgruBHlOAMCpQ==","X-Google-Smtp-Source":"ABdhPJyKz+UH4D+Ml+Q3pFfPQXC1vLXyf9zGkqzHFG+hMaFaSceSKn8t+O7k3Q96xXKaCCbVmDhrT7pDKMzvWm5TVSU=","X-Received":"by 2002:a2e:b5d6:: with SMTP id\n\tg22mr9919799ljn.252.1596530965479; \n\tTue, 04 Aug 2020 01:49:25 -0700 (PDT)","MIME-Version":"1.0","References":"<20200801080151.4282-1-david.plowman@raspberrypi.com>\n\t<20200801080151.4282-2-david.plowman@raspberrypi.com>","In-Reply-To":"<20200801080151.4282-2-david.plowman@raspberrypi.com>","From":"Naushir Patuck ","Date":"Tue, 4 Aug 2020 09:49:09 +0100","Message-ID":"","To":"David Plowman ","Subject":"Re: [libcamera-devel] [PATCH v3 1/4] libcamera: ipa: raspberrypi:\n\tALSC: Camera mode does not need to be atomic","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]