{"id":9123,"url":"https://patchwork.libcamera.org/api/patches/9123/?format=json","web_url":"https://patchwork.libcamera.org/patch/9123/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200731194649.110184-1-email@uajain.com>","date":"2020-07-31T19:46:54","name":"[libcamera-devel,v2] cam: Add --monitor option","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"20edb34e03813e77c1639f3ca654ee7495c619f2","submitter":{"id":1,"url":"https://patchwork.libcamera.org/api/people/1/?format=json","name":"Umang Jain","email":"email@uajain.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/9123/mbox/","series":[{"id":1173,"url":"https://patchwork.libcamera.org/api/series/1173/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1173","date":"2020-07-31T19:46:54","name":"[libcamera-devel,v2] cam: Add --monitor option","version":2,"mbox":"https://patchwork.libcamera.org/series/1173/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/9123/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/9123/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 142F4BD878\n\tfor ;\n\tFri, 31 Jul 2020 19:46:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 766A961E8B;\n\tFri, 31 Jul 2020 21:46:57 +0200 (CEST)","from o1.f.az.sendgrid.net (o1.f.az.sendgrid.net [208.117.55.132])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AC029611A2\n\tfor ;\n\tFri, 31 Jul 2020 21:46:55 +0200 (CEST)","by filterdrecv-p3iad2-d8cc6d457-6kjsg with SMTP id\n\tfilterdrecv-p3iad2-d8cc6d457-6kjsg-18-5F24752D-76\n\t2020-07-31 19:46:54.015259055 +0000 UTC m=+178710.827017285","from mail.uajain.com (unknown)\n\tby ismtpd0001p1hnd1.sendgrid.net (SG) with ESMTP\n\tid EEz3QcFnSDew5BiOZLGEFg Fri, 31 Jul 2020 19:46:53.367 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=uajain.com header.i=@uajain.com\n\theader.b=\"NsoQ9EiG\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=uajain.com;\n\th=from:subject:mime-version:to:cc:content-type:\n\tcontent-transfer-encoding;\n\ts=s1; bh=yvokil5JMWjhCDA/UoZOaIQ2nDAUU3vwbkumgkxVc8A=;\n\tb=NsoQ9EiGbcOOzs0IZuV2NHz6st1oZIdI/nTJZPRK6tIkV6fdhAjLlEdIHBMsFWQjqYFP\n\tOIoWnhUnp6qKfmtb9nMSWCTQ+ms4pOdzFSNgYom8D7KDpICBsGt5TcOiqIGXKWvJfIUcnl\n\t44kUxAyNLHrzENgt0dIrwwlq/Mb46oGtg=","From":"Umang Jain ","Date":"Fri, 31 Jul 2020 19:46:54 +0000 (UTC)","Message-Id":"<20200731194649.110184-1-email@uajain.com>","Mime-Version":"1.0","X-SG-EID":"1Q40EQ7YGir8a9gjSIAdTjhngY657NMk9ckeo4dbHZDiOpywc/L3L9rFqlwE4KPcsqq2IL5HKct149ShwfIDnryxvi6TwoaNxnnGGh0Ir4dFzyc925uQU1fUnW8T0XHpD3STBjTz1p7Xw15mUg5P9kyV+/ogvYsGfq1k2kZ//t90BaxMEbAKSKTibkiTiPI0Czdk5lHej1PwgE/c1kmA9H7sYDbqJx+eqX+6uIqEGUsuEk6Iq5Lfd/WZiOYYFKAqkDOCwgikfbu2cEx4ONptmg==","To":"libcamera-devel@lists.libcamera.org","Subject":"[libcamera-devel] [PATCH v2] cam: Add --monitor option","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add --monitor to monitor new hotplug and unplug camera events from\nthe CameraManager.\n\nSigned-off-by: Umang Jain \nReviewed-by: Niklas Söderlund \nReviewed-by: Kieran Bingham \n---\n src/cam/main.cpp | 26 ++++++++++++++++++++++++++\n src/cam/main.h | 1 +\n 2 files changed, 27 insertions(+)","diff":"diff --git a/src/cam/main.cpp b/src/cam/main.cpp\nindex f5aba04..b03437e 100644\n--- a/src/cam/main.cpp\n+++ b/src/cam/main.cpp\n@@ -36,6 +36,8 @@ public:\n \tvoid quit();\n \n private:\n+\tvoid cameraAdded(std::shared_ptr cam);\n+\tvoid cameraRemoved(std::shared_ptr cam);\n \tint parseOptions(int argc, char *argv[]);\n \tint prepareConfig();\n \tint listControls();\n@@ -121,6 +123,10 @@ int CamApp::init(int argc, char **argv)\n \t\tret = prepareConfig();\n \t\tif (ret)\n \t\t\treturn ret;\n+\t} else if (options_.isSet(OptMonitor)) {\n+\t\tcm_->cameraAdded.connect(this, &CamApp::cameraAdded);\n+\t\tcm_->cameraRemoved.connect(this, &CamApp::cameraRemoved);\n+\t\tstd::cout << \"Monitoring new hotplug or unplug camera events…\" << std::endl;\n \t}\n \n \tloop_ = new EventLoop(cm_->eventDispatcher());\n@@ -189,6 +195,8 @@ int CamApp::parseOptions(int argc, char *argv[])\n \tparser.addOption(OptStrictFormats, OptionNone,\n \t\t\t \"Do not allow requested stream format(s) to be adjusted\",\n \t\t\t \"strict-formats\");\n+\tparser.addOption(OptMonitor, OptionNone, \"Monitor for hotplug and unplug camera events\",\n+\t\t\t \"monitor\");\n \n \toptions_ = parser.parse(argc, argv);\n \tif (!options_.valid())\n@@ -309,6 +317,16 @@ int CamApp::infoConfiguration()\n \treturn 0;\n }\n \n+void CamApp::cameraAdded(std::shared_ptr cam)\n+{\n+\tstd::cout << \"Camera Added: \" << cam->name() << std::endl;\n+}\n+\n+void CamApp::cameraRemoved(std::shared_ptr cam)\n+{\n+\tstd::cout << \"Camera Removed: \" << cam->name() << std::endl;\n+}\n+\n int CamApp::run()\n {\n \tint ret;\n@@ -342,10 +360,18 @@ int CamApp::run()\n \t}\n \n \tif (options_.isSet(OptCapture)) {\n+\t\tcm_->cameraAdded.connect(this, &CamApp::cameraAdded);\n+\t\tcm_->cameraRemoved.connect(this, &CamApp::cameraRemoved);\n \t\tCapture capture(camera_, config_.get(), loop_);\n \t\treturn capture.run(options_);\n \t}\n \n+\tif (options_.isSet(OptMonitor)) {\n+\t\tret = loop_->exec();\n+\t\tif (ret)\n+\t\t\tstd::cout << \"Failed to run monitor loop\" << std::endl;\n+\t}\n+\n \treturn 0;\n }\n \ndiff --git a/src/cam/main.h b/src/cam/main.h\nindex 6f95add..ea8dfd3 100644\n--- a/src/cam/main.h\n+++ b/src/cam/main.h\n@@ -15,6 +15,7 @@ enum {\n \tOptInfo = 'I',\n \tOptList = 'l',\n \tOptListProperties = 'p',\n+\tOptMonitor = 'm',\n \tOptStream = 's',\n \tOptListControls = 256,\n \tOptStrictFormats = 257,\n","prefixes":["libcamera-devel","v2"]}