[{"id":11761,"web_url":"https://patchwork.libcamera.org/comment/11761/","msgid":"<20200801084427.GA1191475@oden.dyn.berto.se>","date":"2020-08-01T08:44:27","subject":"Re: [libcamera-devel] [PATCH v5 12/19] libcamera: ipu3: cio2: Add a\n\tconst sensor() method","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nThanks for your work.\n\nOn 2020-07-31 17:33:13 +0200, Jacopo Mondi wrote:\n> Add a const version of the CIO2Device::sensor() method, that retrieves\n> a const pointer to the sensor_ class member, to be called by users\n> which only own a const reference to a CIO2Device class instance.\n> \n> Reviewed-by: Laurent Pinchart \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/pipeline/ipu3/cio2.h | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/cio2.h b/src/libcamera/pipeline/ipu3/cio2.h\n> index 221cf817eee9..fa813a989fd2 100644\n> --- a/src/libcamera/pipeline/ipu3/cio2.h\n> +++ b/src/libcamera/pipeline/ipu3/cio2.h\n> @@ -50,6 +50,7 @@ public:\n> \tint stop();\n> \n> \tCameraSensor *sensor() { return sensor_; }\n> +\tconst CameraSensor *sensor() const { return sensor_; }\n> \n> \tint queueBuffer(Request *request, FrameBuffer *rawBuffer);\n> \tvoid tryReturnBuffer(FrameBuffer *buffer);\n> -- \n> 2.27.0\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2522DBD86F\n\tfor ;\n\tSat, 1 Aug 2020 08:44:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A3F9661F34;\n\tSat, 1 Aug 2020 10:44:31 +0200 (CEST)","from mail-lj1-x244.google.com (mail-lj1-x244.google.com\n\t[IPv6:2a00:1450:4864:20::244])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B09D160394\n\tfor ;\n\tSat, 1 Aug 2020 10:44:30 +0200 (CEST)","by mail-lj1-x244.google.com with SMTP id s16so19508251ljc.8\n\tfor ;\n\tSat, 01 Aug 2020 01:44:30 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\ts4sm2537199lfc.56.2020.08.01.01.44.28\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSat, 01 Aug 2020 01:44:28 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"QtjegUyP\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=YmshLOlrmDl8/eJQAKnVwmivuJzVdoNa1/3Y9tudKwY=;\n\tb=QtjegUyP2l1XCc0imkodDSBZfMxCvVbMSlp6S8HRVMnB7y7mqGRUGqWCn5sBYl08yp\n\txKhIByXSQaAOK+O7bcrxGN+NE0IUw9ainLOKDYtkh1mlJZYj+0zASMnEaPHZyFksUuhJ\n\tubNl8HinwgxrNve7GM0SqD5EdemH4yh6XJcRByYAhrQQDmcvgUUnOh3f/D3zG01Hi1uf\n\t7blIg4qEr/kGmHq5co0UOMKhfpeHYDuyQ43sANC2Z6AEShx523721y69P75EZXF/IRIc\n\tmod6QmybWtFRy1ygcLRi7Yrzx3Q+4oI45fSi+vw6qSrpgTJKu3Itbcalv9o4y8+bRfS2\n\tFHXA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=YmshLOlrmDl8/eJQAKnVwmivuJzVdoNa1/3Y9tudKwY=;\n\tb=RLOOX7obGrV3fpgX9ZsQKMBzPmMb3lnAGAxwz2Ij6+v5oSQyrudoJ24g4CliNvzJ09\n\tCIQ3Fg09ZrtaPskfbh0EQFqpKr1ul7h5VB9rqquMfAkAA0iZe/loENX0R2NcELLnXUAd\n\tzCUPj/bUJE9byoqe8NSLVhbZneQT3sNIlyHOeFPK7fML92HtVjeI8Xniht0+BORzDe3N\n\ttkh9pn/V4vulcCv1lsD4H82sPiyRjAJwXyszU0oABDuMb18IGcMOuvbvHSNUjWEWMAeI\n\tb3MMOuZ15HBovbLa1NNMxr6+mouBmmvSN+zilgGRzhs9WMGbmS18cF9VS8+gTzISVx36\n\tCf+g==","X-Gm-Message-State":"AOAM5322qJCM75KDGkf5bHsqBtp1yKAKoEkZAUe1MDrX5+QIZLsy2Cw/\n\tn7Hyip4IYFsR0GmGXm+DOYF8eMRZmRg=","X-Google-Smtp-Source":"ABdhPJyfUSdRB1fRGyDuMIqZUDgV6cHiBxlmxlhoB7wtOAkh8TE2ufa2SWGWgHD1imGcYprxW1S48A==","X-Received":"by 2002:a2e:581c:: with SMTP id m28mr34200ljb.413.1596271469778; \n\tSat, 01 Aug 2020 01:44:29 -0700 (PDT)","Date":"Sat, 1 Aug 2020 10:44:27 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Jacopo Mondi ","Message-ID":"<20200801084427.GA1191475@oden.dyn.berto.se>","References":"<20200731153320.58107-1-jacopo@jmondi.org>\n\t<20200731153320.58107-13-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200731153320.58107-13-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH v5 12/19] libcamera: ipu3: cio2: Add a\n\tconst sensor() method","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]