[{"id":11736,"web_url":"https://patchwork.libcamera.org/comment/11736/","msgid":"<20200730224528.GG6107@pendragon.ideasonboard.com>","date":"2020-07-30T22:45:28","subject":"Re: [libcamera-devel] [PATCH 1/3] libcamera: ipa: raspberrypi:\n\tALSC: Camera mode does not need to be atomic","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi David,\n\nThank you for the patch.\n\nOn Thu, Jul 30, 2020 at 12:11:32PM +0100, David Plowman wrote:\n> In the libcamera framework, SwitchMode (which overwrites the\n> camera_mode) cannot run concurrently with Prepare (which uses it).\n> \n> Signed-off-by: David Plowman \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/ipa/raspberrypi/controller/rpi/alsc.hpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/ipa/raspberrypi/controller/rpi/alsc.hpp b/src/ipa/raspberrypi/controller/rpi/alsc.hpp\n> index 3806257..e895913 100644\n> --- a/src/ipa/raspberrypi/controller/rpi/alsc.hpp\n> +++ b/src/ipa/raspberrypi/controller/rpi/alsc.hpp\n> @@ -59,7 +59,7 @@ private:\n> \t// configuration is read-only, and available to both threads\n> \tAlscConfig config_;\n> \tbool first_time_;\n> -\tstd::atomic camera_mode_;\n> +\tCameraMode camera_mode_;\n> \tstd::thread async_thread_;\n> \tvoid asyncFunc(); // asynchronous thread function\n> \tstd::mutex mutex_;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0BA1ABD86F\n\tfor ;\n\tThu, 30 Jul 2020 22:45:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5FF0761988;\n\tFri, 31 Jul 2020 00:45:44 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 452F560540\n\tfor ;\n\tFri, 31 Jul 2020 00:45:42 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0444A9B1;\n\tFri, 31 Jul 2020 00:45:37 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"JDMHWUkl\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1596149138;\n\tbh=hT60VoTlaSfwXRMx6WZMhMbw83ko8HaJC9GVxDw4UF4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=JDMHWUklmbBvnng3/VkswchZsFTuKsxP1a63P41Ti9/PtYusw/Kxtz9nWIFAd4+R3\n\taMCPNRvtFlSxe2ESQYmJCTgHv+VgxgoT8bqH7tpyma4Veem6forphKXvg+Q+sg7tHX\n\tFgWQIMaceeQGHPS6ZW9KBN7YpcI+bBtDHHB+7Beo=","Date":"Fri, 31 Jul 2020 01:45:28 +0300","From":"Laurent Pinchart ","To":"David Plowman ","Message-ID":"<20200730224528.GG6107@pendragon.ideasonboard.com>","References":"<20200730111134.641-1-david.plowman@raspberrypi.com>\n\t<20200730111134.641-2-david.plowman@raspberrypi.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200730111134.641-2-david.plowman@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH 1/3] libcamera: ipa: raspberrypi:\n\tALSC: Camera mode does not need to be atomic","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]