[{"id":11707,"web_url":"https://patchwork.libcamera.org/comment/11707/","msgid":"<20200729121213.GF322953@oden.dyn.berto.se>","date":"2020-07-29T12:12:13","subject":"Re: [libcamera-devel] [PATCH] libcamera: FrameBuffer: Correct\n\tBuffer references","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Kieran,\n\nThanks for your work.\n\nOn 2020-07-29 13:02:12 +0100, Kieran Bingham wrote:\n> Update the remaining (capitalised) Buffer references to the new FrameBuffer\n> object that they refer to.\n> \n> Lower-case 'buffer' terms are kept, as a generic reference to a buffer\n> rather than the specific type 'FrameBuffer'.\n> \n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/buffer.cpp | 6 +++---\n> 1 file changed, 3 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/libcamera/buffer.cpp b/src/libcamera/buffer.cpp\n> index 0fe12ab93b58..500d1cf791e7 100644\n> --- a/src/libcamera/buffer.cpp\n> +++ b/src/libcamera/buffer.cpp\n> @@ -174,11 +174,11 @@ FrameBuffer::FrameBuffer(const std::vector &planes, unsigned int cookie)\n> * The intended callers of this method are buffer completion handlers that\n> * need to associate a buffer to the request it belongs to.\n> *\n> - * A Buffer is associated to a request by Request::addBuffer() and the\n> + * A FrameBuffer is associated to a request by Request::addBuffer() and the\n> * association is valid until the buffer completes. The returned request\n> * pointer is valid only during that interval.\n> *\n> - * \\return The Request the Buffer belongs to, or nullptr if the buffer is\n> + * \\return The Request the FrameBuffer belongs to, or nullptr if the buffer is\n> * not associated with a request\n> */\n> \n> @@ -224,7 +224,7 @@ FrameBuffer::FrameBuffer(const std::vector &planes, unsigned int cookie)\n> \n> /**\n> * \\brief Copy the contents from another buffer\n> - * \\param[in] src Buffer to copy\n> + * \\param[in] src FrameBuffer to copy\n> *\n> * Copy the buffer contents and metadata from \\a src to this buffer. The\n> * destination FrameBuffer shall have the same number of planes as the source\n> -- \n> 2.25.1\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DDCDABD86F\n\tfor ;\n\tWed, 29 Jul 2020 12:12:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 630C1613C6;\n\tWed, 29 Jul 2020 14:12:17 +0200 (CEST)","from mail-lf1-x144.google.com (mail-lf1-x144.google.com\n\t[IPv6:2a00:1450:4864:20::144])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 067926039D\n\tfor ;\n\tWed, 29 Jul 2020 14:12:16 +0200 (CEST)","by mail-lf1-x144.google.com with SMTP id k13so12911850lfo.0\n\tfor ;\n\tWed, 29 Jul 2020 05:12:15 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\te20sm356631lja.137.2020.07.29.05.12.13\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 29 Jul 2020 05:12:13 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"GSnjypJQ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=62uluBEyD5WsXZsU29fHrnkiGCA3qhjEsu1C6yv1blE=;\n\tb=GSnjypJQ0AEzZWbYPMhSn8W47JiOFwLvi/tIRHMubQ+u8askiW81zThZBydphMtpUq\n\t5RUHSiH89NuNx2/YHE5iik5kyCqaJccW+EmUu/cufh4l56v9XembvQeItSHM5HVAbYlD\n\tISAXd41ULgWDXCOk2MrcF99nzmzoLThSOatyHXfOfolhRtH0RrrfZa/8QiVAIeNjcDpU\n\tRGBL04Rbrq/23Qr8A1sLMkYpajJo+vMtfYyIlZDMW8XAF7lcR3Z6Kx9+fVH7cqeV26bi\n\t68HWDoQTOm1lY/YeGykzwCRMQSACdtD0MfPHLdrxObPSR8JpNS5Q8ZvWIyjr8kGCDCZt\n\tWBkA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=62uluBEyD5WsXZsU29fHrnkiGCA3qhjEsu1C6yv1blE=;\n\tb=mFfdDoS4UmzDQWG63elLFMnInDGfl2YlytwxjVDwz4fQwYx0uhK+CtxcI8eoZa1ZiF\n\tuQ99xab5EBTsweIx8IFv/OyXSzVR6y5bgnikFGb1ighV5PyO7Zjae8qSHYFQl8xnTqxb\n\tSDiGDtCACaimXxpJnGjRQ6fOHZLvpgvW9/O9MCkm2kfEJRhyvBYafN+EdoS/gTFCeUcj\n\tDeM08eMDLTOXcXsFazo6W9KohnOUY1/KBdJZOhtl+VkQctbGcwCAvDShQrgJN1aucWc9\n\tTJgQpTdveOZPrrWA8fRFQL1QaIDp7XS/KiPznB0uKe8H9o8fH0I58xWq25pWJ0J04aZ/\n\tkdow==","X-Gm-Message-State":"AOAM532Gq/AHxavOiPEryLYL7KwCwIEjM0wM4A20DYZuxg30/TXbmiZS\n\tViWblrf9zbrUGxvkCoOgh1Hk59Htilk=","X-Google-Smtp-Source":"ABdhPJzJIO6eUXB28tDb67t/geNiTUTaAW+yqIM5Nw137xW1npyomtUFdYU1Kshyj//LNM9uTNqJ0g==","X-Received":"by 2002:a19:c501:: with SMTP id\n\tw1mr16108170lfe.172.1596024735133; \n\tWed, 29 Jul 2020 05:12:15 -0700 (PDT)","Date":"Wed, 29 Jul 2020 14:12:13 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Kieran Bingham ","Message-ID":"<20200729121213.GF322953@oden.dyn.berto.se>","References":"<20200729120212.499788-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200729120212.499788-1-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: FrameBuffer: Correct\n\tBuffer references","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]