[{"id":11726,"web_url":"https://patchwork.libcamera.org/comment/11726/","msgid":"<20200729162451.cngsiiqpbp26oz3e@uno.localdomain>","date":"2020-07-29T16:24:51","subject":"Re: [libcamera-devel] [PATCH v2 3/3] android: camera_device: Report\n\tRAW capability if supported","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Niklas,\n\nOn Wed, Jul 29, 2020 at 01:12:02PM +0200, Niklas Söderlund wrote:\n> Probe the libcamera Camera for RAW support and if supported report RAW\n> capability in the static metadata reported to Android.\n>\n> Signed-off-by: Niklas Söderlund \n> ---\n> src/android/camera_device.cpp | 10 ++++++++++\n> 1 file changed, 10 insertions(+)\n>\n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index c31950db78a588ed..7764c6aee9b8e587 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -15,6 +15,7 @@\n> #include \n> #include \n>\n> +#include \"libcamera/internal/formats.h\"\n> #include \"libcamera/internal/log.h\"\n> #include \"libcamera/internal/utils.h\"\n>\n> @@ -735,6 +736,15 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n> \tstd::vector availableCapabilities = {\n> \t\tANDROID_REQUEST_AVAILABLE_CAPABILITIES_BACKWARD_COMPATIBLE,\n> \t};\n> +\n> +\t/* Report if camera supports RAW. */\n> +\tstd::unique_ptr cameraConfig =\n> +\t\tcamera_->generateConfiguration({ StillCaptureRaw });\n\nIf the camera does not support RAW, then generateConfiguration returns\na nullptr. You should check if cameraConfig is valid before accessing\nit.\n\nThe idea is good and questions on v1 clarified.\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> +\tconst PixelFormatInfo &info =\n> +\t\tPixelFormatInfo::info(cameraConfig->at(0).pixelFormat);\n> +\tif (info.colourEncoding == PixelFormatInfo::ColourEncodingRAW)\n> +\t\tavailableCapabilities.push_back(ANDROID_REQUEST_AVAILABLE_CAPABILITIES_RAW);\n> +\n> \tstaticMetadata_->addEntry(ANDROID_REQUEST_AVAILABLE_CAPABILITIES,\n> \t\t\t\t availableCapabilities.data(),\n> \t\t\t\t availableCapabilities.size());\n> --\n> 2.27.0\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1F4D9BD86F\n\tfor ;\n\tWed, 29 Jul 2020 16:21:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 988CB613C6;\n\tWed, 29 Jul 2020 18:21:14 +0200 (CEST)","from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net\n\t[217.70.183.197])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3CA886039D\n\tfor ;\n\tWed, 29 Jul 2020 18:21:13 +0200 (CEST)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 8E66E1C000B;\n\tWed, 29 Jul 2020 16:21:12 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","Date":"Wed, 29 Jul 2020 18:24:51 +0200","From":"Jacopo Mondi ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Message-ID":"<20200729162451.cngsiiqpbp26oz3e@uno.localdomain>","References":"<20200729111202.3812677-1-niklas.soderlund@ragnatech.se>\n\t<20200729111202.3812677-4-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200729111202.3812677-4-niklas.soderlund@ragnatech.se>","Subject":"Re: [libcamera-devel] [PATCH v2 3/3] android: camera_device: Report\n\tRAW capability if supported","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]