[{"id":11724,"web_url":"https://patchwork.libcamera.org/comment/11724/","msgid":"<20200729161914.ek7mvflr35gknqvp@uno.localdomain>","date":"2020-07-29T16:19:14","subject":"Re: [libcamera-devel] [PATCH v2 1/3] android: camera_device:\n\tPrepare for none-mandatory formats","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Niklas,\n\nOn Wed, Jul 29, 2020 at 01:12:00PM +0200, Niklas Söderlund wrote:\n> When probing what formats a libcamera Camera supports we want to allow\n> to probe for none-mandatory formats. Add a new flag to indicate if a\n\ns/none/not\n\n> format in camera3FormatsMap is mandatory or not.\n>\n> All current defined formats are mandatory.\n\nNice, this makes sense. In the future we might want to define if a\nformat is mandatory depending on the reported hw level, but at this\ntime this is a good step forward\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n>\n> Signed-off-by: Niklas Söderlund \n> ---\n> src/android/camera_device.cpp | 6 +++++-\n> 1 file changed, 5 insertions(+), 1 deletion(-)\n>\n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index b49d6681e5a52d32..ce37fcb8cf5cd4b3 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -46,6 +46,7 @@ const std::vector camera3Resolutions = {\n> */\n> struct Camera3Format {\n> \tstd::vector libcameraFormats;\n> +\tbool mandatory;\n> \tconst char *name;\n> };\n>\n> @@ -57,11 +58,13 @@ const std::map camera3FormatsMap = {\n> \t{\n> \t\tHAL_PIXEL_FORMAT_BLOB, {\n> \t\t\t{ formats::MJPEG },\n> +\t\t\ttrue,\n> \t\t\t\"BLOB\"\n> \t\t}\n> \t}, {\n> \t\tHAL_PIXEL_FORMAT_YCbCr_420_888, {\n> \t\t\t{ formats::NV12, formats::NV21 },\n> +\t\t\ttrue,\n> \t\t\t\"YCbCr_420_888\"\n> \t\t}\n> \t}, {\n> @@ -71,6 +74,7 @@ const std::map camera3FormatsMap = {\n> \t\t */\n> \t\tHAL_PIXEL_FORMAT_IMPLEMENTATION_DEFINED, {\n> \t\t\t{ formats::NV12, formats::NV21 },\n> +\t\t\ttrue,\n> \t\t\t\"IMPLEMENTATION_DEFINED\"\n> \t\t}\n> \t},\n> @@ -281,7 +285,7 @@ int CameraDevice::initializeStreamConfigurations()\n> \t\t\t\tbreak;\n> \t\t\t}\n> \t\t}\n> -\t\tif (!mappedFormat.isValid()) {\n> +\t\tif (format.mandatory && !mappedFormat.isValid()) {\n> \t\t\tLOG(HAL, Error) << \"Failed to map Android format \"\n> \t\t\t\t\t<< camera3Format.name << \" (\"\n> \t\t\t\t\t<< utils::hex(androidFormat) << \")\";\n> --\n> 2.27.0\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1E276BD878\n\tfor ;\n\tWed, 29 Jul 2020 16:15:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 87037613C6;\n\tWed, 29 Jul 2020 18:15:37 +0200 (CEST)","from relay12.mail.gandi.net (relay12.mail.gandi.net\n\t[217.70.178.232])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D85766039D\n\tfor ;\n\tWed, 29 Jul 2020 18:15:35 +0200 (CEST)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay12.mail.gandi.net (Postfix) with ESMTPSA id 325DB200004;\n\tWed, 29 Jul 2020 16:15:34 +0000 (UTC)"],"Date":"Wed, 29 Jul 2020 18:19:14 +0200","From":"Jacopo Mondi ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Message-ID":"<20200729161914.ek7mvflr35gknqvp@uno.localdomain>","References":"<20200729111202.3812677-1-niklas.soderlund@ragnatech.se>\n\t<20200729111202.3812677-2-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200729111202.3812677-2-niklas.soderlund@ragnatech.se>","Subject":"Re: [libcamera-devel] [PATCH v2 1/3] android: camera_device:\n\tPrepare for none-mandatory formats","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]