[{"id":11656,"web_url":"https://patchwork.libcamera.org/comment/11656/","msgid":"","date":"2020-07-27T20:23:07","subject":"Re: [libcamera-devel] [PATCH] test: Remove list-cameras test","submitter":{"id":1,"url":"https://patchwork.libcamera.org/api/people/1/","name":"Umang Jain","email":"email@uajain.com"},"content":"Hi Laurent,\n\nThanks for the patch.\n\nOn 7/28/20 12:27 AM, Laurent Pinchart wrote:\n> The list-cameras test case is the very first test case that has been\n> added to libcamera. It has served to start the development of the unit\n> tests infrastructure. Since then, libcamera has grown several tests that\n> cover the same API, and more. It's time for list-cameras to retire.\n>\n> Signed-off-by: Laurent Pinchart \nI agree with the changes, even with given limited experience with codebase\nand test coverage of libcamera. Hence,\n\nReviewed-by: Umang Jain \n\n> ---\n> test/list-cameras.cpp | 54 -------------------------------------------\n> test/meson.build | 1 -\n> 2 files changed, 55 deletions(-)\n> delete mode 100644 test/list-cameras.cpp\n>\n> diff --git a/test/list-cameras.cpp b/test/list-cameras.cpp\n> deleted file mode 100644\n> index e6a407aca7f8..000000000000\n> --- a/test/list-cameras.cpp\n> +++ /dev/null\n> @@ -1,54 +0,0 @@\n> -/* SPDX-License-Identifier: GPL-2.0-or-later */\n> -/*\n> - * Copyright (C) 2018, Google Inc.\n> - *\n> - * list.cpp - camera list tests\n> - */\n> -\n> -#include \n> -\n> -#include \n> -#include \n> -\n> -#include \"test.h\"\n> -\n> -using namespace std;\n> -using namespace libcamera;\n> -\n> -class ListTest : public Test\n> -{\n> -protected:\n> -\tint init()\n> -\t{\n> -\t\tcm_ = new CameraManager();\n> -\t\tif (cm_->start()) {\n> -\t\t\tstd::cout << \"Failed to start camera\" << std::endl;\n> -\t\t\treturn TestFail;\n> -\t\t}\n> -\n> -\t\treturn 0;\n> -\t}\n> -\n> -\tint run()\n> -\t{\n> -\t\tunsigned int count = 0;\n> -\n> -\t\tfor (const std::shared_ptr &camera : cm_->cameras()) {\n> -\t\t\tcout << \"- \" << camera->name() << endl;\n> -\t\t\tcount++;\n> -\t\t}\n> -\n> -\t\treturn count ? 0 : -ENODEV;\n> -\t}\n> -\n> -\tvoid cleanup()\n> -\t{\n> -\t\tcm_->stop();\n> -\t\tdelete cm_;\n> -\t}\n> -\n> -private:\n> -\tCameraManager *cm_;\n> -};\n> -\n> -TEST_REGISTER(ListTest)\n> diff --git a/test/meson.build b/test/meson.build\n> index f41d6e740e6a..c0fb9bdfac17 100644\n> --- a/test/meson.build\n> +++ b/test/meson.build\n> @@ -18,7 +18,6 @@ subdir('v4l2_videodevice')\n> \n> public_tests = [\n> ['geometry', 'geometry.cpp'],\n> - ['list-cameras', 'list-cameras.cpp'],\n> ['signal', 'signal.cpp'],\n> ['span', 'span.cpp'],\n> ]","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CEA98BD86F\n\tfor ;\n\tMon, 27 Jul 2020 20:23:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 66A9761223;\n\tMon, 27 Jul 2020 22:23:10 +0200 (CEST)","from o1.f.az.sendgrid.net (o1.f.az.sendgrid.net [208.117.55.132])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E8FC760536\n\tfor ;\n\tMon, 27 Jul 2020 22:23:08 +0200 (CEST)","by filterdrecv-p3iad2-5b55dcd864-pbk2w with SMTP id\n\tfilterdrecv-p3iad2-5b55dcd864-pbk2w-17-5F1F37AB-3F\n\t2020-07-27 20:23:07.582782139 +0000 UTC m=+2690027.706186246","from mail.uajain.com (unknown) by geopod-ismtpd-3-1 (SG) with ESMTP\n\tid 2x5t6AORQ6SIgS2SYn-3gA Mon, 27 Jul 2020 20:23:07.322 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=uajain.com header.i=@uajain.com\n\theader.b=\"JmKctUU0\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=uajain.com;\n\th=subject:references:from:mime-version:in-reply-to:to:content-type:\n\tcontent-transfer-encoding;\n\ts=s1; bh=QVCvRyL6AMhiKj/Yd0reHhA3a51MDNmF1sv+0SuCY3o=;\n\tb=JmKctUU0yY6tDZ3k1Vk3oIjwnDET0C4dsa3rDj46404pDLDRn7Q2a0F0siN+Ibf6vn2S\n\tLdWo5ZFADf7AgpRQ5HUfe3NU1HHQxnPBQPYFj8Onf54JelWwkrz17/dMhRFI9drDv83hgJ\n\tGe4VKrFN+G5YoE8adwOMbd9S/MW26Qguk=","References":"<20200727185731.21618-1-laurent.pinchart@ideasonboard.com>","From":"Umang Jain ","Message-ID":"","Date":"Mon, 27 Jul 2020 20:23:07 +0000 (UTC)","Mime-Version":"1.0","In-Reply-To":"<20200727185731.21618-1-laurent.pinchart@ideasonboard.com>","X-SG-EID":"1Q40EQ7YGir8a9gjSIAdTjhngY657NMk9ckeo4dbHZDiOpywc/L3L9rFqlwE4KPcmBmDZ9oXlLxgt7qcU8kJXEJXBktoOXWaojqfRKVU4AMs31ivBfIcVhGUL5WTgyBLvD0Calx0TxiUDdy6YKrWMoqtlO1EjMSBflkvg7lkiPN6zjFenFc2/dACWeLd49KE54LnYdqI9X9CnLyMIgtOxOI7OfGKxxLQe5ncmv1L0XgFqxDzmdvxNq9IP9Fvd+nYoik92io7VJh8Y86Wd11ERA==","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH] test: Remove list-cameras test","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=\"us-ascii\"; Format=\"flowed\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":11657,"web_url":"https://patchwork.libcamera.org/comment/11657/","msgid":"<20200727221946.GJ2729799@oden.dyn.berto.se>","date":"2020-07-27T22:19:46","subject":"Re: [libcamera-devel] [PATCH] test: Remove list-cameras test","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your patch.\n\nOn 2020-07-27 21:57:31 +0300, Laurent Pinchart wrote:\n> The list-cameras test case is the very first test case that has been\n> added to libcamera. It has served to start the development of the unit\n> tests infrastructure. Since then, libcamera has grown several tests that\n> cover the same API, and more. It's time for list-cameras to retire.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> test/list-cameras.cpp | 54 -------------------------------------------\n> test/meson.build | 1 -\n> 2 files changed, 55 deletions(-)\n> delete mode 100644 test/list-cameras.cpp\n> \n> diff --git a/test/list-cameras.cpp b/test/list-cameras.cpp\n> deleted file mode 100644\n> index e6a407aca7f8..000000000000\n> --- a/test/list-cameras.cpp\n> +++ /dev/null\n> @@ -1,54 +0,0 @@\n> -/* SPDX-License-Identifier: GPL-2.0-or-later */\n> -/*\n> - * Copyright (C) 2018, Google Inc.\n> - *\n> - * list.cpp - camera list tests\n> - */\n> -\n> -#include \n> -\n> -#include \n> -#include \n> -\n> -#include \"test.h\"\n> -\n> -using namespace std;\n> -using namespace libcamera;\n> -\n> -class ListTest : public Test\n> -{\n> -protected:\n> -\tint init()\n> -\t{\n> -\t\tcm_ = new CameraManager();\n> -\t\tif (cm_->start()) {\n> -\t\t\tstd::cout << \"Failed to start camera\" << std::endl;\n> -\t\t\treturn TestFail;\n> -\t\t}\n> -\n> -\t\treturn 0;\n> -\t}\n> -\n> -\tint run()\n> -\t{\n> -\t\tunsigned int count = 0;\n> -\n> -\t\tfor (const std::shared_ptr &camera : cm_->cameras()) {\n> -\t\t\tcout << \"- \" << camera->name() << endl;\n> -\t\t\tcount++;\n> -\t\t}\n> -\n> -\t\treturn count ? 0 : -ENODEV;\n> -\t}\n> -\n> -\tvoid cleanup()\n> -\t{\n> -\t\tcm_->stop();\n> -\t\tdelete cm_;\n> -\t}\n> -\n> -private:\n> -\tCameraManager *cm_;\n> -};\n> -\n> -TEST_REGISTER(ListTest)\n> diff --git a/test/meson.build b/test/meson.build\n> index f41d6e740e6a..c0fb9bdfac17 100644\n> --- a/test/meson.build\n> +++ b/test/meson.build\n> @@ -18,7 +18,6 @@ subdir('v4l2_videodevice')\n> \n> public_tests = [\n> ['geometry', 'geometry.cpp'],\n> - ['list-cameras', 'list-cameras.cpp'],\n> ['signal', 'signal.cpp'],\n> ['span', 'span.cpp'],\n> ]\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 31AB7BD878\n\tfor ;\n\tMon, 27 Jul 2020 22:19:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 89ED5616FF;\n\tTue, 28 Jul 2020 00:19:51 +0200 (CEST)","from mail-lj1-x244.google.com (mail-lj1-x244.google.com\n\t[IPv6:2a00:1450:4864:20::244])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A20FC6053C\n\tfor ;\n\tTue, 28 Jul 2020 00:19:49 +0200 (CEST)","by mail-lj1-x244.google.com with SMTP id b25so18987988ljp.6\n\tfor ;\n\tMon, 27 Jul 2020 15:19:49 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id 3sm677203ljq.57.2020.07.27.15.19.47\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 27 Jul 2020 15:19:47 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"KABPFYB2\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=5HsfEtlJoip7bDhdcudSB4cfIabaqnFLtxze8W51Rck=;\n\tb=KABPFYB2gvKAg3gYH9XeE3QRQehJLQiNKwUNh12tvhBOtjqN+/yhon3fvN0nqvfS0t\n\ttW4BffqZl1OclGY3CRYkC+RzHa7YxMgmUafUfyvqx5q0EgoePhaBxfzqA5uF3RSRCWE4\n\tci1ZY5SqqWawjt+hZ7Zaa6SvqA5x64zu1WoXZcf+cQqEg+AGv2cD0NSSXbdYw1o1R52Q\n\t0LAT+B4VvkQbU5b1kjdXWPi/p2gUUo1JqgUJiaUBm7Rf4ip5B15EGgAWLnZXZaXgF1ZB\n\tHr8lsLAfJe+oVQQ7E+7Hw+MLdlBhVFFFCYpSIHTXM8SX1OMJZLz7M/UfvxF7QpPDaf3N\n\tipCQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=5HsfEtlJoip7bDhdcudSB4cfIabaqnFLtxze8W51Rck=;\n\tb=UiOWn4pEVwOWWEK589vR+eO/ZIKfyGsnbLF95SH6C1PiA4r7NMjzKkOlE91OI1CDF+\n\tgi7l9zGNKroyC1FF25mpsoRW1asSPAWf7PtMBUnWqZ8ExK4RjJ/2gLI7tTqXBSbT+1jA\n\tQQ3au5sY3fuVmpXjyWw+Ktcxg47WoW1aszZlQZZLYUTUSNUjWTbg4e+wI/D+EhdjBt2O\n\tJ5Kb5QfJBbickwNMy1fTpteMs3XJhsg/S9TtlFebpym+cj1TS20G35Nb9r+Rgn1ue98L\n\tb8kbE/k6dv5Vg5t+p9R+235FClfEMilL/hzGt/ZNuv9WsrfXL141reaEesUv5m49oplm\n\thfeQ==","X-Gm-Message-State":"AOAM530ZnVQBJh6KMhsz6QRh3QPAj8+TMsXKH8D+UciL3Zco2mvSiSpi\n\tQxmVAPvoVHCdz59YNItRpmFRWg==","X-Google-Smtp-Source":"ABdhPJyRlPqiatrwYWL1oswS6OX21vA9+FToxEK37yI+jwvr8LFb7mSVcVnLukbtsIwLq7wMX0M9xw==","X-Received":"by 2002:a2e:b004:: with SMTP id\n\ty4mr11186807ljk.175.1595888388622; \n\tMon, 27 Jul 2020 15:19:48 -0700 (PDT)","Date":"Tue, 28 Jul 2020 00:19:46 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Message-ID":"<20200727221946.GJ2729799@oden.dyn.berto.se>","References":"<20200727185731.21618-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200727185731.21618-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] test: Remove list-cameras test","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]