[{"id":11665,"web_url":"https://patchwork.libcamera.org/comment/11665/","msgid":"<816c6f58-90d3-0371-a9ea-7be6ce8d9b77@ideasonboard.com>","date":"2020-07-28T10:47:19","subject":"Re: [libcamera-devel] [PATCH v4 3/3] libcamera: stream_option: use\n\tformat name to set cam/qcam format","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Kaaira,\n\nOn 27/07/2020 17:21, Kaaira Gupta wrote:\n> Replace hex input for pixel formats with their format names, for input in\n> cam and qcam.\n> Hence, remove the todo.\n> \n> Signed-off-by: Kaaira Gupta \n> ---\n> src/cam/stream_options.cpp | 5 ++---\n> 1 file changed, 2 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/cam/stream_options.cpp b/src/cam/stream_options.cpp\n> index bd12c8f..4168e5d 100644\n> --- a/src/cam/stream_options.cpp\n> +++ b/src/cam/stream_options.cpp\n> @@ -19,7 +19,7 @@ StreamKeyValueParser::StreamKeyValueParser()\n> \t\t ArgumentRequired);\n> \taddOption(\"height\", OptionInteger, \"Height in pixels\",\n> \t\t ArgumentRequired);\n> -\taddOption(\"pixelformat\", OptionInteger, \"Pixel format\",\n> +\taddOption(\"pixelformat\", OptionString, \"Pixel format name\",\n> \t\t ArgumentRequired);\n> }\n> \n> @@ -95,9 +95,8 @@ int StreamKeyValueParser::updateConfiguration(CameraConfiguration *config,\n> \t\t\tcfg.size.height = opts[\"height\"];\n> \t\t}\n> \n> -\t\t/* \\todo Translate 4CC string to pixelformat with modifier. */\n> \t\tif (opts.isSet(\"pixelformat\"))\n> -\t\t\tcfg.pixelFormat = PixelFormat(opts[\"pixelformat\"]);\n> +\t\t\tcfg.pixelFormat = PixelFormat::fromString(opts[\"pixelformat\"].toString());\n\nI'm looking forward to this:\n\n -s pixelformat=NV12\n\nis so much nicer than:\n -s pixelformat=0x3231564e\n\nReviewed-by: Kieran Bingham \n\n\n> \t}\n> \n> \treturn 0;\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A57F3BD86F\n\tfor ;\n\tTue, 28 Jul 2020 10:47:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1E8476118A;\n\tTue, 28 Jul 2020 12:47:23 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 62A846039B\n\tfor ;\n\tTue, 28 Jul 2020 12:47:22 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C1C9B563;\n\tTue, 28 Jul 2020 12:47:21 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"XTFLhF1U\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1595933242;\n\tbh=VojCKtX9+71zdRYZ5D3Bp78BmU8iVUQ+Uvonvfbehvo=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=XTFLhF1UYwtjJe7tLc9XmbKGLGEZgmIEFnaRsV0e/GcJe74AtQ8BVh1yLXmWcV8Yn\n\t3EB1EXY8rS4fA82enOfMeF+zYZY2pzGhJMPesu+zp+/aBQKn3xapKUIFaPNYxO6vgM\n\tq+6FlULKD9ZcixKsOgvJ5mzoS5yiKHCTQMdu85ag=","To":"Kaaira Gupta , libcamera-devel@lists.libcamera.org,\n\t=?utf-8?q?Niklas_S=C3=B6derlund?= ","References":"<20200727162143.31317-1-kgupta@es.iitr.ac.in>\n\t<20200727162143.31317-4-kgupta@es.iitr.ac.in>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<816c6f58-90d3-0371-a9ea-7be6ce8d9b77@ideasonboard.com>","Date":"Tue, 28 Jul 2020 11:47:19 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20200727162143.31317-4-kgupta@es.iitr.ac.in>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH v4 3/3] libcamera: stream_option: use\n\tformat name to set cam/qcam format","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":11668,"web_url":"https://patchwork.libcamera.org/comment/11668/","msgid":"<20200728120633.GB13753@pendragon.ideasonboard.com>","date":"2020-07-28T12:06:33","subject":"Re: [libcamera-devel] [PATCH v4 3/3] libcamera: stream_option: use\n\tformat name to set cam/qcam format","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Tue, Jul 28, 2020 at 11:47:19AM +0100, Kieran Bingham wrote:\n> On 27/07/2020 17:21, Kaaira Gupta wrote:\n> > Replace hex input for pixel formats with their format names, for input in\n> > cam and qcam.\n> > Hence, remove the todo.\n> > \n> > Signed-off-by: Kaaira Gupta \n> > ---\n> > src/cam/stream_options.cpp | 5 ++---\n> > 1 file changed, 2 insertions(+), 3 deletions(-)\n> > \n> > diff --git a/src/cam/stream_options.cpp b/src/cam/stream_options.cpp\n> > index bd12c8f..4168e5d 100644\n> > --- a/src/cam/stream_options.cpp\n> > +++ b/src/cam/stream_options.cpp\n> > @@ -19,7 +19,7 @@ StreamKeyValueParser::StreamKeyValueParser()\n> > \t\t ArgumentRequired);\n> > \taddOption(\"height\", OptionInteger, \"Height in pixels\",\n> > \t\t ArgumentRequired);\n> > -\taddOption(\"pixelformat\", OptionInteger, \"Pixel format\",\n> > +\taddOption(\"pixelformat\", OptionString, \"Pixel format name\",\n> > \t\t ArgumentRequired);\n> > }\n> > \n> > @@ -95,9 +95,8 @@ int StreamKeyValueParser::updateConfiguration(CameraConfiguration *config,\n> > \t\t\tcfg.size.height = opts[\"height\"];\n> > \t\t}\n> > \n> > -\t\t/* \\todo Translate 4CC string to pixelformat with modifier. */\n> > \t\tif (opts.isSet(\"pixelformat\"))\n> > -\t\t\tcfg.pixelFormat = PixelFormat(opts[\"pixelformat\"]);\n> > +\t\t\tcfg.pixelFormat = PixelFormat::fromString(opts[\"pixelformat\"].toString());\n> \n> I'm looking forward to this:\n> \n> -s pixelformat=NV12\n> \n> is so much nicer than:\n> -s pixelformat=0x3231564e\n\nI wonder if there's a need to support both, but that's something we can\neasily add later if needed.\n\nReviewed-by: Laurent Pinchart \n\n> Reviewed-by: Kieran Bingham \n> \n> > \t}\n> > \n> > \treturn 0;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9018FBD86F\n\tfor ;\n\tTue, 28 Jul 2020 12:06:50 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5ECAB6118A;\n\tTue, 28 Jul 2020 14:06:50 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0F6EC6039B\n\tfor ;\n\tTue, 28 Jul 2020 14:06:49 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8A329563;\n\tTue, 28 Jul 2020 14:06:42 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"IYQEC6Mz\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1595938002;\n\tbh=VY5hoolAp4cIvwy4NPyI1JGJwCQ7lSyMXz1ZdAC5wuM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=IYQEC6MzWmVLXn9jdcqMhr3q9PATJrr2L5mjRmo7zNjElr/8XmHmRC7vQxzGMe0Bo\n\thZ+wGidSAkCCqeDaaaRN/o7oBDLyDinlyMF6kjZbq83/R92B+0FW8ugvmzyvUJVuZ1\n\tPwTwRqnNQo9Ec+fadTFt2vAbs9Y0yROhD9CwhkA4=","Date":"Tue, 28 Jul 2020 15:06:33 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"<20200728120633.GB13753@pendragon.ideasonboard.com>","References":"<20200727162143.31317-1-kgupta@es.iitr.ac.in>\n\t<20200727162143.31317-4-kgupta@es.iitr.ac.in>\n\t<816c6f58-90d3-0371-a9ea-7be6ce8d9b77@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<816c6f58-90d3-0371-a9ea-7be6ce8d9b77@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v4 3/3] libcamera: stream_option: use\n\tformat name to set cam/qcam format","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Kaaira Gupta , libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]