[{"id":11664,"web_url":"https://patchwork.libcamera.org/comment/11664/","msgid":"<9954cede-790e-1cf4-75d8-4d27f47e79f4@ideasonboard.com>","date":"2020-07-28T10:43:28","subject":"Re: [libcamera-devel] [PATCH v4 2/3] libcamera: pixel_format: Add a\n\tfunction to return format based on string","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Kaaira,\n\nOn 27/07/2020 17:21, Kaaira Gupta wrote:\n> Add a function which retrieves pixel format corrsponding to its name\n\ns/corrsponding/corresponding/\n\n> from PixelFormatInfo.\n> \n> Signed-off-by: Kaaira Gupta \n> ---\n> include/libcamera/pixel_format.h | 2 ++\n> src/libcamera/pixel_format.cpp | 9 +++++++++\n> 2 files changed, 11 insertions(+)\n> \n> diff --git a/include/libcamera/pixel_format.h b/include/libcamera/pixel_format.h\n> index 6727315..c4ae088 100644\n> --- a/include/libcamera/pixel_format.h\n> +++ b/include/libcamera/pixel_format.h\n> @@ -38,6 +38,8 @@ public:\n> \n> \tstd::string toString() const;\n> \n> +\tstatic PixelFormat fromString(const std::string &name);\n> +\n> private:\n> \tuint32_t fourcc_;\n> \tuint64_t modifier_;\n> diff --git a/src/libcamera/pixel_format.cpp b/src/libcamera/pixel_format.cpp\n> index 14addb5..9b07781 100644\n> --- a/src/libcamera/pixel_format.cpp\n> +++ b/src/libcamera/pixel_format.cpp\n> @@ -130,4 +130,13 @@ std::string PixelFormat::toString() const\n> \treturn info.name;\n> }\n> \n> +/**\n> + * \\brief Retrive pixel format corresponding to the string\n\ns/Retrive/Retrieve/\n\n\n\n> + * \\return Pixel format\n> + */\n\nWe might want to express a bit more about what is returned, especially\nas this function is in the user-facing API.\n\n\"\\return The PixelFormat represented by the \\a name if known, or an\ninvalid pixel format otherwise.\"\n\n\nThose can also be fixed on applying if there's nothing else.\n\nReviewed-by: Kieran Bingham \n\n\n> +PixelFormat PixelFormat::fromString(const std::string &name)\n\nActually, could this return a const reference? (which will save a copy).\n\nconst PixelFormat &PixelFormat::fromString....\n\n> +{\n> +\treturn PixelFormatInfo::info(name).format;\n> +}\n> +\n> } /* namespace libcamera */\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DAABFBD878\n\tfor ;\n\tTue, 28 Jul 2020 10:43:33 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 553416118A;\n\tTue, 28 Jul 2020 12:43:33 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C56966039B\n\tfor ;\n\tTue, 28 Jul 2020 12:43:31 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 34378563;\n\tTue, 28 Jul 2020 12:43:31 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"pWMaWIsC\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1595933011;\n\tbh=6bAzViVvEoGiAtzagfeH9Awdy6mFf5br24a0ESDufjg=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=pWMaWIsCjufEQORvXOVcUYcOKCOaB3BYZ/IoDEJxvmgrdi+74f9z4XVixfQOVi+i7\n\tvwPc40b9BPtvD4vkjduTQz47D4eq1C9Dy87WfAHkq6dIlkRoibid4Jgq44TPB2fo/G\n\tnFJOw6HXCAEEgFMBhmiz8StLXTxqy/JHU0txkA3Y=","To":"Kaaira Gupta , libcamera-devel@lists.libcamera.org,\n\t=?utf-8?q?Niklas_S=C3=B6derlund?= ","References":"<20200727162143.31317-1-kgupta@es.iitr.ac.in>\n\t<20200727162143.31317-3-kgupta@es.iitr.ac.in>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<9954cede-790e-1cf4-75d8-4d27f47e79f4@ideasonboard.com>","Date":"Tue, 28 Jul 2020 11:43:28 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20200727162143.31317-3-kgupta@es.iitr.ac.in>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH v4 2/3] libcamera: pixel_format: Add a\n\tfunction to return format based on string","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":11667,"web_url":"https://patchwork.libcamera.org/comment/11667/","msgid":"<20200728120512.GA13753@pendragon.ideasonboard.com>","date":"2020-07-28T12:05:12","subject":"Re: [libcamera-devel] [PATCH v4 2/3] libcamera: pixel_format: Add a\n\tfunction to return format based on string","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Tue, Jul 28, 2020 at 11:43:28AM +0100, Kieran Bingham wrote:\n> Hi Kaaira,\n> \n> On 27/07/2020 17:21, Kaaira Gupta wrote:\n> > Add a function which retrieves pixel format corrsponding to its name\n> \n> s/corrsponding/corresponding/\n> \n> > from PixelFormatInfo.\n> > \n> > Signed-off-by: Kaaira Gupta \n> > ---\n> > include/libcamera/pixel_format.h | 2 ++\n> > src/libcamera/pixel_format.cpp | 9 +++++++++\n> > 2 files changed, 11 insertions(+)\n> > \n> > diff --git a/include/libcamera/pixel_format.h b/include/libcamera/pixel_format.h\n> > index 6727315..c4ae088 100644\n> > --- a/include/libcamera/pixel_format.h\n> > +++ b/include/libcamera/pixel_format.h\n> > @@ -38,6 +38,8 @@ public:\n> > \n> > \tstd::string toString() const;\n> > \n> > +\tstatic PixelFormat fromString(const std::string &name);\n> > +\n> > private:\n> > \tuint32_t fourcc_;\n> > \tuint64_t modifier_;\n> > diff --git a/src/libcamera/pixel_format.cpp b/src/libcamera/pixel_format.cpp\n> > index 14addb5..9b07781 100644\n> > --- a/src/libcamera/pixel_format.cpp\n> > +++ b/src/libcamera/pixel_format.cpp\n> > @@ -130,4 +130,13 @@ std::string PixelFormat::toString() const\n> > \treturn info.name;\n> > }\n> > \n> > +/**\n> > + * \\brief Retrive pixel format corresponding to the string\n> \n> s/Retrive/Retrieve/\n\nI'd say \"Create a PixelFormat from a string\". It's a static function\nthat returns an instance, not a reference or pointer, so it's not\nretrieving anything pre-existing.\n\n> > + * \\return Pixel format\n> > + */\n> \n> We might want to express a bit more about what is returned, especially\n> as this function is in the user-facing API.\n> \n> \"\\return The PixelFormat represented by the \\a name if known, or an\n> invalid pixel format otherwise.\"\n> \n> \n> Those can also be fixed on applying if there's nothing else.\n> \n> Reviewed-by: Kieran Bingham \n> \n> > +PixelFormat PixelFormat::fromString(const std::string &name)\n> \n> Actually, could this return a const reference? (which will save a copy).\n> \n> const PixelFormat &PixelFormat::fromString....\n\nPixelFormat is a lightweight class meant to be copied, returning an\ninstance instance of a reference should be fine here.\n\nReviewed-by: Laurent Pinchart \n\n> > +{\n> > +\treturn PixelFormatInfo::info(name).format;\n> > +}\n> > +\n> > } /* namespace libcamera */\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2FD1DBD86F\n\tfor ;\n\tTue, 28 Jul 2020 12:05:34 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9B7B06118A;\n\tTue, 28 Jul 2020 14:05:33 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AC9D46039B\n\tfor ;\n\tTue, 28 Jul 2020 14:05:31 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2FF0E563;\n\tTue, 28 Jul 2020 14:05:20 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"QPE0OHUs\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1595937924;\n\tbh=NtEQMxpO+uBh5LtioonijPb9sRPDwtgxWG6OCAFoEGw=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=QPE0OHUsMHcvhlyqU67Nc/FSC84eQvQOJo4Oyu9RUoqDEfc71xUJs5TsykjX0kMAZ\n\tI1pGvXbDE6BE8KR7mwbhL8xSqplZ8yLPN4lcF/V9VUADNtw/mFii3zD8wXd4cjJSW9\n\t0CL6RHRzAQLgotFzxcIVcQndx4kbtJN3uY8XNNHw=","Date":"Tue, 28 Jul 2020 15:05:12 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"<20200728120512.GA13753@pendragon.ideasonboard.com>","References":"<20200727162143.31317-1-kgupta@es.iitr.ac.in>\n\t<20200727162143.31317-3-kgupta@es.iitr.ac.in>\n\t<9954cede-790e-1cf4-75d8-4d27f47e79f4@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<9954cede-790e-1cf4-75d8-4d27f47e79f4@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v4 2/3] libcamera: pixel_format: Add a\n\tfunction to return format based on string","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Kaaira Gupta , libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]