[{"id":1245,"web_url":"https://patchwork.libcamera.org/comment/1245/","msgid":"<20190403103529.GF12646@pendragon.ideasonboard.com>","date":"2019-04-03T10:35:29","subject":"Re: [libcamera-devel] [PATCH 2/2] qcam: meson: Use pkg-config\n\tmethod for qt5 dependencies","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Wed, Apr 03, 2019 at 05:25:45PM +0700, Kieran Bingham wrote:\n> Meson searches for qmake to determine if QT5 is available to support the\n> optional qcam component.\n> \n> When cross compiling, meson can incorrectly identify the host qmake\n> which will cause incorrect linkage and usage of system headers.\n> \n> Set the dependency method to specify pkg-config which resolves the\n> issue.\n> \n> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n> ---\n>  src/qcam/meson.build | 5 ++++-\n>  1 file changed, 4 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/qcam/meson.build b/src/qcam/meson.build\n> index 8a71cda3dfe5..3d8b1b3b759d 100644\n> --- a/src/qcam/meson.build\n> +++ b/src/qcam/meson.build\n> @@ -8,7 +8,10 @@ qcam_sources = files([\n>  ])\n>  \n>  import('qt5')\n> -qt5_dep = dependency('qt5', modules: ['Core', 'Gui', 'Widgets'], required : false)\n> +qt5_dep = dependency('qt5',\n> +                     method : 'pkg-config',\n> +                     modules : ['Core', 'Gui', 'Widgets'],\n> +                     required : false)\n>  \n>  if qt5_dep.found()\n>      qcam  = executable('qcam', qcam_sources,","headers":{"Return-Path":"<laurent.pinchart@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 838FB600FD\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed,  3 Apr 2019 12:35:40 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E17F89AA;\n\tWed,  3 Apr 2019 12:35:39 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1554287740;\n\tbh=Taj4L1eKIglPbx6/lMcqSU2XnYiAb71yWbr/PIBkCo8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=WUmYqRITVhuel6vdsI1Lj2wukGQEmohBudhbwtArvP6fHT9sMHE/yt5aTf8aFo2YX\n\tHnT8wtBbry8h5HnKtFCyfN5bZ7EWEGz5rl1O9IR1MmRngqfUx7M4mcGVVIWW9D2IdO\n\tK/bRlaOxNE0++BICcLtSHD6BB6XgNlszXX35ppM4=","Date":"Wed, 3 Apr 2019 13:35:29 +0300","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Cc":"LibCamera Devel <libcamera-devel@lists.libcamera.org>","Message-ID":"<20190403103529.GF12646@pendragon.ideasonboard.com>","References":"<20190403102545.7143-1-kieran.bingham@ideasonboard.com>\n\t<20190403102545.7143-3-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20190403102545.7143-3-kieran.bingham@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 2/2] qcam: meson: Use pkg-config\n\tmethod for qt5 dependencies","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Wed, 03 Apr 2019 10:35:40 -0000"}}]